Patch Detail
Show a patch.
GET /api/1.1/patches/10510/?format=api
{ "id": 10510, "url": "https://patchwork.libcamera.org/api/1.1/patches/10510/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10510/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201126142321.5563-5-david.plowman@raspberrypi.com>", "date": "2020-11-26T14:23:21", "name": "[libcamera-devel,v3,4/4] src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor", "commit_ref": "5815bd0397bc63772642820a3c296b2c5fd7c791", "pull_url": null, "state": "accepted", "archived": false, "hash": "94ad3560d8abf3c20c8a2be5b9dc3e2829a59a53", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10510/mbox/", "series": [ { "id": 1484, "url": "https://patchwork.libcamera.org/api/1.1/series/1484/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1484", "date": "2020-11-26T14:23:17", "name": "Raspberry Pi AGC improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1484/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10510/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10510/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AB0CBE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Nov 2020 14:23:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D83EA63479;\n\tThu, 26 Nov 2020 15:23:30 +0100 (CET)", "from mail-ed1-x531.google.com (mail-ed1-x531.google.com\n\t[IPv6:2a00:1450:4864:20::531])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3668263469\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Nov 2020 15:23:29 +0100 (CET)", "by mail-ed1-x531.google.com with SMTP id q3so2438808edr.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Nov 2020 06:23:29 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tf24sm3237003edx.90.2020.11.26.06.23.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 26 Nov 2020 06:23:27 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"WD+BbYp7\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=+NVlZDjzRN8Jm3viX7G6HYZHjp/sXYM7h/3wGLb47/w=;\n\tb=WD+BbYp7l8eIBxxcNNrqCYiD2jWTEyGzPHrCHoBEd1qY6BSlAuxudNMiUfu8K+aa2+\n\tOwaGYTaOFA15/thlL9mVtgmQeTPrqk3VB86MMf3Wx2GA7kcEiPMhu+bdHL1MzqLJ9fPc\n\tFxCfB3KxRaDWUo082B1qoiefUUTYC2jX6jx0XfKjfNIISlLJ6Rz0p2hpjdHjhN4dXOXY\n\tcVNpcrgCxgOuGu8KDajm+abjQP/bbmfplfd36hGvkfUoAJG/E5x05O8wRMU80laSq1DJ\n\tFC1jbRoxzRcqnXk4UbghmlbRQOk/EAmJLzNhYvxuSTsIR5eKw9Z79c65tEWYnuPejktU\n\tz1AQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=+NVlZDjzRN8Jm3viX7G6HYZHjp/sXYM7h/3wGLb47/w=;\n\tb=kE4uC3C/E+amY7wqdAoQXQ1LN8Y6kvYtZaMOuN/feFBMgptqORujwW6ro6FzEokmVR\n\tP+VydJR/3TGsKVu9mOPIL6vgm4oCKOqmS19cyFOUWNU01JPfhF8O6ZgH3ErWTl4LSXnw\n\tjRFysxW3zrj6XVLx4LJtVoz3fusUwRuzblt6XO0Rr+TvBhpn971TywVI1DsyaA9SHWbh\n\tFjCv/DcEMnOrl+ax45DHwZHyc7mxTPWb6u/Ncp8RnRglsTePGVAhM5XEtvZPe4+ynSlM\n\ty20m1jcMPWAZt8Ptg/RG0OrOnq9qKBfqbKk94UkE64SsLmtZYBw3Woqu25NfytCgwK9a\n\t7UwA==", "X-Gm-Message-State": "AOAM531CxMjtZLlkQUTDCj8h0lzpfkAlI/jwqWp8wSVZY8MguziVo6Yw\n\tOurpIlZ9t8hGjOZvJ42WFaPXVUi0n3WamQEZ", "X-Google-Smtp-Source": "ABdhPJyE5XahOHpkiCcDLds5n9pKrrgP++onXpaQkVKdkEVOaDXqL7ZOg8UwTYYXqal3Uy40XS66Sg==", "X-Received": "by 2002:aa7:d791:: with SMTP id\n\ts17mr2879448edq.272.1606400608657; \n\tThu, 26 Nov 2020 06:23:28 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 26 Nov 2020 14:23:21 +0000", "Message-Id": "<20201126142321.5563-5-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20201126142321.5563-1-david.plowman@raspberrypi.com>", "References": "<20201126142321.5563-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 4/4] src: ipa: raspberrypi: Fix initial\n\tAGC oscillation for imx219 sensor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The exposure times in the exposure modes were causing AGC oscillations\nbecause the algorithm was demanding long unachievable exposure times\nbut, without working sensor metadata, thought it was getting them when\nactually it was not. We fix it by making the exposure profile request\nonly achievable exposure times, as we do for the ov5647 tuning.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/data/imx219.json | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\nindex b03a7beb..212f8b9a 100644\n--- a/src/ipa/raspberrypi/data/imx219.json\n+++ b/src/ipa/raspberrypi/data/imx219.json\n@@ -133,7 +133,7 @@\n {\n \"shutter\":\n [\n- 100, 10000, 30000, 60000, 120000\n+ 100, 10000, 30000, 30000, 30000\n ],\n \"gain\":\n [\n@@ -144,7 +144,7 @@\n {\n \"shutter\":\n [\n- 100, 5000, 10000, 20000, 120000\n+ 100, 5000, 10000, 20000, 30000\n ],\n \"gain\":\n [\n", "prefixes": [ "libcamera-devel", "v3", "4/4" ] }