Patch Detail
Show a patch.
GET /api/1.1/patches/10470/?format=api
{ "id": 10470, "url": "https://patchwork.libcamera.org/api/1.1/patches/10470/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10470/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201123090329.9486-1-jacopo@jmondi.org>", "date": "2020-11-23T09:03:29", "name": "[libcamera-devel] libcamera: control_ids: Keep draft controls last", "commit_ref": "20cf381c65df4c8cd45f00061f14f44e3780072e", "pull_url": null, "state": "accepted", "archived": false, "hash": "cf5d411072a5b7d94da18e5205e87d8634ecf3a9", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10470/mbox/", "series": [ { "id": 1476, "url": "https://patchwork.libcamera.org/api/1.1/series/1476/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1476", "date": "2020-11-23T09:03:29", "name": "[libcamera-devel] libcamera: control_ids: Keep draft controls last", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1476/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10470/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10470/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FC3DBE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 23 Nov 2020 09:03:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D42F663327;\n\tMon, 23 Nov 2020 10:03:31 +0100 (CET)", "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9457E632E2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Nov 2020 10:03:30 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 4CE671C00A8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 23 Nov 2020 09:03:30 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 23 Nov 2020 10:03:29 +0100", "Message-Id": "<20201123090329.9486-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.29.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: control_ids: Keep draft\n\tcontrols last", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Let's try not to mix draft controls and regular controls.\n\nKeep draft controls at the end of the control_ids.yaml file and\nadd a comment to make clear where the draft controls section begins.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 28 ++++++++++++++++------------\n 1 file changed, 16 insertions(+), 12 deletions(-)", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex c8874fa91965..a883e27e22e9 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -273,6 +273,22 @@ controls:\n \n size: [3x3]\n \n+ - ScalerCrop:\n+ type: Rectangle\n+ description: |\n+ Sets the image portion that will be scaled to form the whole of\n+ the final output image. The (x,y) location of this rectangle is\n+ relative to the PixelArrayActiveAreas that is being used. The units\n+ remain native sensor pixels, even if the sensor is being used in\n+ a binning or skipping mode.\n+\n+ This control is only present when the pipeline supports scaling. Its\n+ maximum valid value is given by the properties::ScalerCropMaximum\n+ property, and the two can be used to implement digital zoom.\n+\n+ # ----------------------------------------------------------------------------\n+ # Draft controls section\n+\n - AePrecaptureTrigger:\n type: int32_t\n draft: true\n@@ -518,16 +534,4 @@ controls:\n detection, additional format conversions etc) count as an additional\n pipeline stage.\n \n- - ScalerCrop:\n- type: Rectangle\n- description: |\n- Sets the image portion that will be scaled to form the whole of\n- the final output image. The (x,y) location of this rectangle is\n- relative to the PixelArrayActiveAreas that is being used. The units\n- remain native sensor pixels, even if the sensor is being used in\n- a binning or skipping mode.\n-\n- This control is only present when the pipeline supports scaling. Its\n- maximum valid value is given by the properties::ScalerCropMaximum\n- property, and the two can be used to implement digital zoom.\n ...\n", "prefixes": [ "libcamera-devel" ] }