Patch Detail
Show a patch.
GET /api/1.1/patches/10447/?format=api
{ "id": 10447, "url": "https://patchwork.libcamera.org/api/1.1/patches/10447/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10447/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201119123427.53864-2-email@uajain.com>", "date": "2020-11-19T12:34:24", "name": "[libcamera-devel,1/3] Early return if no cameras are found on the system.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "51964657000a4b982e8f68acf0bdb28327a0927f", "submitter": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/people/1/?format=api", "name": "Umang Jain", "email": "email@uajain.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10447/mbox/", "series": [ { "id": 1469, "url": "https://patchwork.libcamera.org/api/1.1/series/1469/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1469", "date": "2020-11-19T12:34:23", "name": "simple-cam: Provide event-loop backed by libevent", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1469/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10447/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10447/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F031CBE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Nov 2020 12:34:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0166C615AA;\n\tThu, 19 Nov 2020 13:34:38 +0100 (CET)", "from mail.uajain.com (static.126.159.217.95.clients.your-server.de\n\t[95.217.159.126])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B1AF4615A3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Nov 2020 13:34:36 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=uajain.com header.i=@uajain.com\n\theader.b=\"IAjwfltC\"; dkim-atps=neutral", "From": "Umang Jain <email@uajain.com>", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=uajain.com; s=mail;\n\tt=1605789276; bh=/smKCARF6HosYrSKrlAnihdgx7dKq8n6xByKatoxOqs=;\n\th=From:To:Cc:Subject:In-Reply-To:References;\n\tb=IAjwfltCrVdIjk0CtKUFV/PX9jHvTKV8ZsSYmfUO1cHVAirXmYZrBzhuB+oRWIub+\n\tqyCq18dB18qADwrwXDZ3Hznn1R+VvKmu9K3iIXvIuTkHJTUk68bOCeAH4ro04psJoh\n\tPXH2xljF56tHHgCik7GraYQNxJ7ZtoxJcuraE59OGbiaXP7CFNb9KuHT1J33d1G+q7\n\tFEiCxeMzXqFkTB+EH2JgeqsGXiCXzzIqpmX3uau+lHrjI2FM18ZpX9mi7dbzRY+ZBX\n\tZ7JxmuXgjtZSy4/xtvb8QCvqfmWuLKVhbBwzwJa44aR4BBxtyQdMjX5asB6TcoLNVO\n\t+j/fWM5a6UYAA==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 19 Nov 2020 18:04:24 +0530", "Message-Id": "<20201119123427.53864-2-email@uajain.com>", "In-Reply-To": "<20201119123427.53864-1-email@uajain.com>", "References": "<20201119123427.53864-1-email@uajain.com>", "Mime-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 1/3] Early return if no cameras are found\n\ton the system.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Failing to do so, the codepath will segfault while trying to acquire\na non-existent camera.\n\nSigned-off-by: Umang Jain <email@uajain.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n simple-cam.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/simple-cam.cpp b/simple-cam.cpp\nindex 727bb6d..af9c8b1 100644\n--- a/simple-cam.cpp\n+++ b/simple-cam.cpp\n@@ -307,6 +307,13 @@ int main()\n \tfor (std::unique_ptr<Request> &request : requests)\n \t\tcamera->queueRequest(request.get());\n \n+\tif(!cm->cameras().size()) {\n+\t\tstd::cout << \"No cameras were identified on the system.\"\n+\t\t\t << std::endl;\n+\t\tcm->stop();\n+\t\treturn -1;\n+\t}\n+\n \t/*\n \t * --------------------------------------------------------------------\n \t * Run an EventLoop\n", "prefixes": [ "libcamera-devel", "1/3" ] }