Patch Detail
Show a patch.
GET /api/1.1/patches/10364/?format=api
{ "id": 10364, "url": "https://patchwork.libcamera.org/api/1.1/patches/10364/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10364/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201106103707.49660-17-paul.elder@ideasonboard.com>", "date": "2020-11-06T10:36:46", "name": "[libcamera-devel,v4,16/37] libcamera: IPAProxy: Add isolate parameter to create()", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c70f266b25e60bc3e9c5efd48ffb19a6e622f3a3", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10364/mbox/", "series": [ { "id": 1448, "url": "https://patchwork.libcamera.org/api/1.1/series/1448/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1448", "date": "2020-11-06T10:36:30", "name": "IPA isolation implementation", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1448/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10364/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10364/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26699BDB89\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Nov 2020 10:37:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E469C62D37;\n\tFri, 6 Nov 2020 11:37:57 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3582162D20\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Nov 2020 11:37:57 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EB9CB16;\n\tFri, 6 Nov 2020 11:37:55 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wZrkKOL4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604659076;\n\tbh=HqJPpZYPanBud+SdVbPAlSo6TlkyoYl15X4lqV+HJnw=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=wZrkKOL4bGHFBpNWm8oNvdkBrG4h7/2GQ9+wckp+d06+pmJ1+rvRCxCkQx0ivW4wO\n\tQ6D8/AwtxzRJNl904Gt5lNf4IeuhziqLo/JXus7gEFxm8ZJNw5/CsICIVbpiABst4t\n\t1EAbWWgVf5wrO5/Qi4+W3FBHDQBtPwVTmlXaGqiA=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 6 Nov 2020 19:36:46 +0900", "Message-Id": "<20201106103707.49660-17-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201106103707.49660-1-paul.elder@ideasonboard.com>", "References": "<20201106103707.49660-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 16/37] libcamera: IPAProxy: Add isolate\n\tparameter to create()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Since IPAProxy implementations now always encapsulate IPA modules, add a\nparameter to create() to signal if the proxy should isolate the IPA or not.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\n---\nNo change in v4\n\nNo change in v3\n\nChanges in v2:\n- document isolate argument\n---\n include/libcamera/internal/ipa_proxy.h | 22 +++++++++++-----------\n src/libcamera/ipa_proxy.cpp | 4 +++-\n 2 files changed, 14 insertions(+), 12 deletions(-)", "diff": "diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex 59a5b841..195d2cb4 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -42,7 +42,7 @@ public:\n \tIPAProxyFactory(const char *name);\n \tvirtual ~IPAProxyFactory() = default;\n \n-\tvirtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0;\n+\tvirtual std::unique_ptr<IPAProxy> create(IPAModule *ipam, bool isolate) = 0;\n \n \tconst std::string &name() const { return name_; }\n \n@@ -53,16 +53,16 @@ private:\n \tstd::string name_;\n };\n \n-#define REGISTER_IPA_PROXY(proxy)\t\t\t\\\n-class proxy##Factory final : public IPAProxyFactory\t\\\n-{\t\t\t\t\t\t\t\\\n-public:\t\t\t\t\t\t\t\\\n-\tproxy##Factory() : IPAProxyFactory(#proxy) {}\t\\\n-\tstd::unique_ptr<IPAProxy> create(IPAModule *ipam)\t\\\n-\t{\t\t\t\t\t\t\\\n-\t\treturn std::make_unique<proxy>(ipam);\t\\\n-\t}\t\t\t\t\t\t\\\n-};\t\t\t\t\t\t\t\\\n+#define REGISTER_IPA_PROXY(proxy)\t\t\t\t\t\\\n+class proxy##Factory final : public IPAProxyFactory\t\t\t\\\n+{\t\t\t\t\t\t\t\t\t\\\n+public:\t\t\t\t\t\t\t\t\t\\\n+\tproxy##Factory() : IPAProxyFactory(#proxy) {}\t\t\t\\\n+\tstd::unique_ptr<IPAProxy> create(IPAModule *ipam, bool isolate)\t\\\n+\t{\t\t\t\t\t\t\t\t\\\n+\t\treturn std::make_unique<proxy>(ipam, isolate);\t\t\\\n+\t}\t\t\t\t\t\t\t\t\\\n+};\t\t\t\t\t\t\t\t\t\\\n static proxy##Factory global_##proxy##Factory;\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/ipa_proxy.cpp b/src/libcamera/ipa_proxy.cpp\nindex 23be24ad..ee5e6f3e 100644\n--- a/src/libcamera/ipa_proxy.cpp\n+++ b/src/libcamera/ipa_proxy.cpp\n@@ -250,10 +250,12 @@ IPAProxyFactory::IPAProxyFactory(const char *name)\n * \\fn IPAProxyFactory::create()\n * \\brief Create an instance of the IPAProxy corresponding to the factory\n * \\param[in] ipam The IPA module\n+ * \\param[in] isolate Flag to isolate the IPA module\n *\n * This virtual function is implemented by the REGISTER_IPA_PROXY() macro.\n * It creates a IPAProxy instance that isolates an IPA interface designated\n- * by the IPA module \\a ipam.\n+ * by the IPA module \\a ipam. If \\a isolate is true, then the IPA module will\n+ * be isolated.\n *\n * \\return A pointer to a newly constructed instance of the IPAProxy subclass\n * corresponding to the factory\n", "prefixes": [ "libcamera-devel", "v4", "16/37" ] }