Patch Detail
Show a patch.
GET /api/1.1/patches/10333/?format=api
{ "id": 10333, "url": "https://patchwork.libcamera.org/api/1.1/patches/10333/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10333/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201104074841.21676-4-laurent.pinchart@ideasonboard.com>", "date": "2020-11-04T07:48:41", "name": "[libcamera-devel,v2,3/3] libcamera: Drop unnecessary explicit initialization of V4L2DeviceFormat", "commit_ref": "b394dc8b8001dd702dfa171a123f4e33c1e29c6b", "pull_url": null, "state": "accepted", "archived": false, "hash": "6e48fbe29bc947bb55acb76af8dc8232b03d30b0", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10333/mbox/", "series": [ { "id": 1443, "url": "https://patchwork.libcamera.org/api/1.1/series/1443/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1443", "date": "2020-11-04T07:48:38", "name": "libcamera: Fix uninitialized use of V4L2DeviceFormat members", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1443/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10333/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10333/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE586BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 4 Nov 2020 07:49:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D555962BDA;\n\tWed, 4 Nov 2020 08:49:35 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 549D160344\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Nov 2020 08:49:34 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9B44BB5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Nov 2020 08:49:33 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"PWAilPfr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604476174;\n\tbh=i6XuY8kIGS+d9rubR4xMyp3nMRcwAIa6IUuwOvZAuqg=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=PWAilPfrbNpKSAHVM/oJ4xiUzsmgYOIPhor6rDvfWjT0Nsb1FcI3U6bQuVie7mx4o\n\t+hFsb7DZnNMZ05mB4DRha30Ak/pisoJZShKX5XKqdbDoCIwx4R9HS9wjtfyet7hi66\n\tJFkjY3J/lsAzndMWRzuvWD4d76egZiL24+23nWew=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 4 Nov 2020 09:48:41 +0200", "Message-Id": "<20201104074841.21676-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201104074841.21676-1-laurent.pinchart@ideasonboard.com>", "References": "<20201104074841.21676-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 3/3] libcamera: Drop unnecessary\n\texplicit initialization of V4L2DeviceFormat", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The V4L2DeviceFormat class now has default initializers for all members,\nexplicit initialization isn't needed anymore.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 6 +++---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 ++--\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 4 ++--\n src/libcamera/pipeline/simple/converter.cpp | 2 +-\n src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 4 ++--\n src/libcamera/pipeline/vimc/vimc.cpp | 4 ++--\n 8 files changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 5a6ee1a83e45..4cedb32bc239 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -463,7 +463,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t * adjusted format to be propagated to the ImgU output devices.\n \t */\n \tconst Size &sensorSize = config->cio2Format().size;\n-\tV4L2DeviceFormat cio2Format = {};\n+\tV4L2DeviceFormat cio2Format;\n \tret = cio2->configure(sensorSize, &cio2Format);\n \tif (ret)\n \t\treturn ret;\ndiff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 0a60442cf570..7ad66f21ffa3 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -73,7 +73,7 @@ V4L2DeviceFormat findBestMode(V4L2VideoDevice::Formats &formatsMap,\n \t\t\t const Size &req)\n {\n \tdouble bestScore = std::numeric_limits<double>::max(), score;\n-\tV4L2DeviceFormat bestMode = {};\n+\tV4L2DeviceFormat bestMode;\n \n #define PENALTY_AR\t\t1500.0\n #define PENALTY_8BIT\t\t2000.0\n@@ -429,7 +429,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \t\t\tstatus = Adjusted;\n \t\t}\n \n-\t\tV4L2DeviceFormat format = {};\n+\t\tV4L2DeviceFormat format;\n \t\tformat.fourcc = dev->toV4L2PixelFormat(cfg.pixelFormat);\n \t\tformat.size = cfg.size;\n \n@@ -600,7 +600,7 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \t * See which streams are requested, and route the user\n \t * StreamConfiguration appropriately.\n \t */\n-\tV4L2DeviceFormat format = {};\n+\tV4L2DeviceFormat format;\n \tfor (unsigned i = 0; i < config->size(); i++) {\n \t\tStreamConfiguration &cfg = config->at(i);\n \ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex c74a2e9bd548..1b1922a9896c 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -720,13 +720,13 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \t\t\treturn ret;\n \t}\n \n-\tV4L2DeviceFormat paramFormat = {};\n+\tV4L2DeviceFormat paramFormat;\n \tparamFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_PARAMS);\n \tret = param_->setFormat(¶mFormat);\n \tif (ret)\n \t\treturn ret;\n \n-\tV4L2DeviceFormat statFormat = {};\n+\tV4L2DeviceFormat statFormat;\n \tstatFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_STAT_3A);\n \tret = stat_->setFormat(&statFormat);\n \tif (ret)\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\nindex e98515c878aa..80e1818d7907 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1_path.cpp\n@@ -85,7 +85,7 @@ CameraConfiguration::Status RkISP1Path::validate(StreamConfiguration *cfg)\n \tcfg->size.expandTo(minResolution_);\n \tcfg->bufferCount = RKISP1_BUFFER_COUNT;\n \n-\tV4L2DeviceFormat format = {};\n+\tV4L2DeviceFormat format;\n \tformat.fourcc = video_->toV4L2PixelFormat(cfg->pixelFormat);\n \tformat.size = cfg->size;\n \n@@ -146,7 +146,7 @@ int RkISP1Path::configure(const StreamConfiguration &config,\n \t\t<< ispFormat.toString();\n \n \tconst PixelFormatInfo &info = PixelFormatInfo::info(config.pixelFormat);\n-\tV4L2DeviceFormat outputFormat = {};\n+\tV4L2DeviceFormat outputFormat;\n \toutputFormat.fourcc = video_->toV4L2PixelFormat(config.pixelFormat);\n \toutputFormat.size = config.size;\n \toutputFormat.planesCount = info.numPlanes();\ndiff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\nindex c21479a191fe..57538ab08fcd 100644\n--- a/src/libcamera/pipeline/simple/converter.cpp\n+++ b/src/libcamera/pipeline/simple/converter.cpp\n@@ -265,7 +265,7 @@ std::tuple<unsigned int, unsigned int>\n SimpleConverter::strideAndFrameSize(const Size &size,\n \t\t\t\t const PixelFormat &pixelFormat)\n {\n-\tV4L2DeviceFormat format = {};\n+\tV4L2DeviceFormat format;\n \tformat.fourcc = m2m_->capture()->toV4L2PixelFormat(pixelFormat);\n \tformat.size = size;\n \ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 3d2039f3f269..0d3078f770cf 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -482,7 +482,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \n \t/* Set the stride and frameSize. */\n \tif (!needConversion_) {\n-\t\tV4L2DeviceFormat format = {};\n+\t\tV4L2DeviceFormat format;\n \t\tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n \t\tformat.size = cfg.size;\n \n@@ -587,7 +587,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \t/* Configure the video node. */\n \tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig.pixelFormat);\n \n-\tV4L2DeviceFormat captureFormat = {};\n+\tV4L2DeviceFormat captureFormat;\n \tcaptureFormat.fourcc = videoFormat;\n \tcaptureFormat.size = pipeConfig.captureSize;\n \ndiff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 3862631b7bed..0f3241cc873a 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -154,7 +154,7 @@ CameraConfiguration::Status UVCCameraConfiguration::validate()\n \n \tcfg.bufferCount = 4;\n \n-\tV4L2DeviceFormat format = {};\n+\tV4L2DeviceFormat format;\n \tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n \tformat.size = cfg.size;\n \n@@ -210,7 +210,7 @@ int PipelineHandlerUVC::configure(Camera *camera, CameraConfiguration *config)\n \tStreamConfiguration &cfg = config->at(0);\n \tint ret;\n \n-\tV4L2DeviceFormat format = {};\n+\tV4L2DeviceFormat format;\n \tformat.fourcc = data->video_->toV4L2PixelFormat(cfg.pixelFormat);\n \tformat.size = cfg.size;\n \ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 7416c37c6f5a..914b6b54b0c4 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -172,7 +172,7 @@ CameraConfiguration::Status VimcCameraConfiguration::validate()\n \n \tcfg.bufferCount = 4;\n \n-\tV4L2DeviceFormat format = {};\n+\tV4L2DeviceFormat format;\n \tformat.fourcc = data_->video_->toV4L2PixelFormat(cfg.pixelFormat);\n \tformat.size = cfg.size;\n \n@@ -276,7 +276,7 @@ int PipelineHandlerVimc::configure(Camera *camera, CameraConfiguration *config)\n \tif (ret)\n \t\treturn ret;\n \n-\tV4L2DeviceFormat format = {};\n+\tV4L2DeviceFormat format;\n \tformat.fourcc = data->video_->toV4L2PixelFormat(cfg.pixelFormat);\n \tformat.size = cfg.size;\n \n", "prefixes": [ "libcamera-devel", "v2", "3/3" ] }