Patch Detail
Show a patch.
GET /api/1.1/patches/10320/?format=api
{ "id": 10320, "url": "https://patchwork.libcamera.org/api/1.1/patches/10320/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10320/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201103133042.30341-2-laurent.pinchart@ideasonboard.com>", "date": "2020-11-03T13:30:42", "name": "[libcamera-devel,2/2] libcamera: pipeline: vivid: Print diagnostic on configuration failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "29b7aa19de4ec37eb6b9e2fcde10fd6a3bd97d53", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/1.1/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10320/mbox/", "series": [ { "id": 1440, "url": "https://patchwork.libcamera.org/api/1.1/series/1440/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1440", "date": "2020-11-03T13:30:41", "name": "[libcamera-devel,1/2] libcamera: pipeline: vivid: Set camera properties", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1440/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10320/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10320/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47575BDB89\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 3 Nov 2020 13:31:38 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 11A5C62BC9;\n\tTue, 3 Nov 2020 14:31:38 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3868962B7E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Nov 2020 14:31:35 +0100 (CET)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6AB3B9C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Nov 2020 14:31:34 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uEfZjTrf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604410294;\n\tbh=Vda8SY9J+d1/gw+XrGwD04H3h7nk7U/4VWbH1o8NR4o=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=uEfZjTrfQ8Wt10LXTBZ4tFQdSOr0kEQxWNAbBBGlCaE8eHGDy2jDNRvgbOw184lPV\n\tWSg/Yo1E0pCE2rhsjiOkP3D55HivpifAXD09C3L4qBnJ1zJcA90j2aXnL21y9YU4Ff\n\tMavMspbB0QU+HjSGslWoSmq+K6HDMrWClXLbCago=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 3 Nov 2020 15:30:42 +0200", "Message-Id": "<20201103133042.30341-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201103133042.30341-1-laurent.pinchart@ideasonboard.com>", "References": "<20201103133042.30341-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/2] libcamera: pipeline: vivid: Print\n\tdiagnostic on configuration failure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In case the setFormat() call on the video device fails to match the\nconfiguration, print both the requested and actual configurations to\nease debugging.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/vivid/vivid.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/vivid/vivid.cpp b/src/libcamera/pipeline/vivid/vivid.cpp\nindex bf8f82af981f..a0ccbd1e711e 100644\n--- a/src/libcamera/pipeline/vivid/vivid.cpp\n+++ b/src/libcamera/pipeline/vivid/vivid.cpp\n@@ -181,8 +181,13 @@ int PipelineHandlerVivid::configure(Camera *camera, CameraConfiguration *config)\n \t\treturn ret;\n \n \tif (format.size != cfg.size ||\n-\t format.fourcc != data->video_->toV4L2PixelFormat(cfg.pixelFormat))\n+\t format.fourcc != data->video_->toV4L2PixelFormat(cfg.pixelFormat)) {\n+\t\tLOG(VIVID, Error)\n+\t\t\t<< \"Requested \" << cfg.toString() << \", got \"\n+\t\t\t<< format.size.toString() << \"-\"\n+\t\t\t<< format.fourcc.toString();\n \t\treturn -EINVAL;\n+\t}\n \n \t/* Set initial controls specific to VIVID */\n \tControlList controls(data->video_->controls());\n", "prefixes": [ "libcamera-devel", "2/2" ] }