Patch Detail
Show a patch.
GET /api/1.1/patches/10308/?format=api
{ "id": 10308, "url": "https://patchwork.libcamera.org/api/1.1/patches/10308/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10308/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201030085756.79329-4-paul.elder@ideasonboard.com>", "date": "2020-10-30T08:57:54", "name": "[libcamera-devel,v4,3/5] tracepoints: Add pipeline tracepoints for tracing IPA calls", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d188c746c20ec13a4cd57559f6b9cfc73142a486", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/users/17/?format=api", "username": "epaul", "first_name": "Paul", "last_name": "Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10308/mbox/", "series": [ { "id": 1435, "url": "https://patchwork.libcamera.org/api/1.1/series/1435/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1435", "date": "2020-10-30T08:57:51", "name": "Tracing", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1435/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10308/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10308/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E640BDB1E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 30 Oct 2020 08:58:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0116D62995;\n\tFri, 30 Oct 2020 09:58:12 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0543F62034\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 30 Oct 2020 09:58:11 +0100 (CET)", "from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E1F99B7;\n\tFri, 30 Oct 2020 09:58:08 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aDmuHJPf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604048290;\n\tbh=vpp8Kl6o++fsPCHmkBXiH5ssIzgHm6Jg2FTrQyAcqro=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aDmuHJPfXWu7b2eDJIVB42LvfL7QnwCiYNPm8Lvg0/ZHcszM2N5iYweeL4Fjyr0S6\n\tIsxK5r3+2IQW5jjfx6lP+sItbww2mmtobzeHqovtrIwiFmCKfv2BodV8cFE45/iNQW\n\tl6dyKESQopqRkYQwXjz0L5hn56XbqGUTsN+7FmT8=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 30 Oct 2020 17:57:54 +0900", "Message-Id": "<20201030085756.79329-4-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201030085756.79329-1-paul.elder@ideasonboard.com>", "References": "<20201030085756.79329-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 3/5] tracepoints: Add pipeline\n\ttracepoints for tracing IPA calls", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add a pair of tracepoints to a general pipeline tracepoints file,\nlibcamera:ipa_call_start and libcamera:ipa_call_finish, to trace IPA\ncalls. This allows us to obtain the time taken for the IPA call.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v4\n\nChanges in v3:\n- rename the ipa tracepoints to ipa_call_begin and ipa_call_end\n- make string args const, so that strings can be passed directly\n\nNew in v2\n---\n .../internal/tracepoints/meson.build | 1 +\n .../internal/tracepoints/pipeline.tp | 25 +++++++++++++++++++\n 2 files changed, 26 insertions(+)\n create mode 100644 include/libcamera/internal/tracepoints/pipeline.tp", "diff": "diff --git a/include/libcamera/internal/tracepoints/meson.build b/include/libcamera/internal/tracepoints/meson.build\nindex fee0758f..e2a5470a 100644\n--- a/include/libcamera/internal/tracepoints/meson.build\n+++ b/include/libcamera/internal/tracepoints/meson.build\n@@ -5,5 +5,6 @@ tracepoint_files = files([\n 'buffer_enums.tp',\n 'request_enums.tp',\n \n+ 'pipeline.tp',\n 'request.tp',\n ])\ndiff --git a/include/libcamera/internal/tracepoints/pipeline.tp b/include/libcamera/internal/tracepoints/pipeline.tp\nnew file mode 100644\nindex 00000000..c0a94635\n--- /dev/null\n+++ b/include/libcamera/internal/tracepoints/pipeline.tp\n@@ -0,0 +1,25 @@\n+TRACEPOINT_EVENT(\n+\tlibcamera,\n+\tipa_call_begin,\n+\tTP_ARGS(\n+\t\tconst char *, pipe,\n+\t\tconst char *, func\n+\t),\n+\tTP_FIELDS(\n+\t\tctf_string(pipeline_name, pipe)\n+\t\tctf_string(function_name, func)\n+\t)\n+)\n+\n+TRACEPOINT_EVENT(\n+\tlibcamera,\n+\tipa_call_end,\n+\tTP_ARGS(\n+\t\tconst char *, pipe,\n+\t\tconst char *, func\n+\t),\n+\tTP_FIELDS(\n+\t\tctf_string(pipeline_name, pipe)\n+\t\tctf_string(function_name, func)\n+\t)\n+)\n", "prefixes": [ "libcamera-devel", "v4", "3/5" ] }