Patch Detail
Show a patch.
GET /api/1.1/patches/10285/?format=api
{ "id": 10285, "url": "https://patchwork.libcamera.org/api/1.1/patches/10285/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10285/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201028095023.3004701-1-hiroh@chromium.org>", "date": "2020-10-28T09:50:23", "name": "[libcamera-devel] android: camera_device: Mark ToPixelFormat() a const function", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "cc3a0a3273edfea11da5daa1c8d317be95da3cb5", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10285/mbox/", "series": [ { "id": 1426, "url": "https://patchwork.libcamera.org/api/1.1/series/1426/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1426", "date": "2020-10-28T09:50:23", "name": "[libcamera-devel] android: camera_device: Mark ToPixelFormat() a const function", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1426/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10285/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10285/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 16C44BDB1E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Oct 2020 09:50:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C85062390;\n\tWed, 28 Oct 2020 10:50:35 +0100 (CET)", "from mail-pj1-x102e.google.com (mail-pj1-x102e.google.com\n\t[IPv6:2607:f8b0:4864:20::102e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8CBF62067\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Oct 2020 10:50:33 +0100 (CET)", "by mail-pj1-x102e.google.com with SMTP id m3so2199862pjf.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Oct 2020 02:50:33 -0700 (PDT)", "from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\ty5sm2110690pfq.79.2020.10.28.02.50.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 28 Oct 2020 02:50:31 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"GTq3Q2cf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=bLkHLnV8q68/sx9Q6XEgYitTeMG/ymIiiObsKiDa7Ts=;\n\tb=GTq3Q2cfVlRpC64X21BuZWPIeVdaLx2FnhDvqAJGnpcLjNYvpcndDWoLHTeaWZfbzE\n\tH6hqpY0u29+Noxh3J+lkLmDDRUoIwl32rBbyR6n/2I4j2hTfmf4gd6b/jCP0xZZOFJl5\n\t0iKKy6ph297bPiTQqd2a9EaU4agQtcKVOy+y8=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=bLkHLnV8q68/sx9Q6XEgYitTeMG/ymIiiObsKiDa7Ts=;\n\tb=U60fzuCyfmLkNsn3f22VsCuawdEPcgbc9IW7N2ZZnCm766ioscLAPIkkVF0plJ18Tu\n\tinw6K6i8jgnNQIwIMc/21VWBJRBqxUkZOLfgpMP2wRX7xFOFMM0O3S9HbIfmqhW0njcT\n\tqudX+TWSNseujlIMXzzKuaw3mydFwe2hKi9GggMnIqERscaqr7SGPCAJvudpp5c76ts0\n\t4cAI8eezsv4TZKDbg3PSVivzMQxMPHwEb7A4suGbD76mnt4Mp70I6CILYYXaXe2TiOyv\n\tPj4yMGcerzk8uaa+Pa9V6VwPeXSti5/vs7EtRqca2fPFFrPeFonEILTSX7hCFZiXTdfS\n\tE4tw==", "X-Gm-Message-State": "AOAM532Hrsbf83O9U1sTcCK25+enmoZZer+DA7DCBEzJytPZfaiDUaNv\n\tc1MNOSZouqdCe7G+kwF/oyP/pZ8gQd2F5A==", "X-Google-Smtp-Source": "ABdhPJzAhDVhfXTC8gE+lXP1JAze8eBrMhv2MUKCAnfpMZpMUS/OAM7Krl57qkgbvyKiwYTsITu/cw==", "X-Received": "by 2002:a17:90a:318d:: with SMTP id\n\tj13mr6180029pjb.209.1603878632248; \n\tWed, 28 Oct 2020 02:50:32 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 28 Oct 2020 18:50:23 +0900", "Message-Id": "<20201028095023.3004701-1-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.29.0.rc2.309.g374f81d7ae-goog", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] android: camera_device: Mark\n\tToPixelFormat() a const function", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "CameraDevice::ToPixelFormat() doesn't change the state of the\nCameraDevice. Marks it a const function so that it can be called\nin const functions.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/camera_device.cpp | 2 +-\n src/android/camera_device.h | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\n--\n2.29.0.rc2.309.g374f81d7ae-goog", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex ca60f51..6369d49 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1188,7 +1188,7 @@ const camera_metadata_t *CameraDevice::constructDefaultRequestSettings(int type)\n \treturn requestTemplate->get();\n }\n\n-PixelFormat CameraDevice::toPixelFormat(int format)\n+PixelFormat CameraDevice::toPixelFormat(int format) const\n {\n \t/* Translate Android format code to libcamera pixel format. */\n \tauto it = formatsMap_.find(format);\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex fd08738..45efcf4 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -104,7 +104,7 @@ private:\n \tvoid notifyShutter(uint32_t frameNumber, uint64_t timestamp);\n \tvoid notifyError(uint32_t frameNumber, camera3_stream_t *stream);\n \tCameraMetadata *requestTemplatePreview();\n-\tlibcamera::PixelFormat toPixelFormat(int format);\n+\tlibcamera::PixelFormat toPixelFormat(int format) const;\n \tstd::unique_ptr<CameraMetadata> getResultMetadata(int frame_number,\n \t\t\t\t\t\t\t int64_t timestamp);\n\n", "prefixes": [ "libcamera-devel" ] }