Patch Detail
Show a patch.
GET /api/1.1/patches/1027/?format=api
{ "id": 1027, "url": "https://patchwork.libcamera.org/api/1.1/patches/1027/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1027/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190417135858.23914-5-jacopo@jmondi.org>", "date": "2019-04-17T13:58:54", "name": "[libcamera-devel,v7,4/8] libcamera: v4l2_device: Propagate releaseBuffers() error", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "71ba44bf0a75b3be165e3241e789d718cd15f53b", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1027/mbox/", "series": [ { "id": 254, "url": "https://patchwork.libcamera.org/api/1.1/series/254/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=254", "date": "2019-04-17T13:58:50", "name": "libcamera: Framework changes to prepare for multiple streams support", "version": 7, "mbox": "https://patchwork.libcamera.org/series/254/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1027/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1027/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AACD560DC5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Apr 2019 15:58:18 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 3B26340004;\n\tWed, 17 Apr 2019 13:58:18 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 17 Apr 2019 15:58:54 +0200", "Message-Id": "<20190417135858.23914-5-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190417135858.23914-1-jacopo@jmondi.org>", "References": "<20190417135858.23914-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 4/8] libcamera: v4l2_device: Propagate\n\treleaseBuffers() error", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 17 Apr 2019 13:58:19 -0000" }, "content": "The error code returned by requestBuffers(0) was not propagated to the\ncaller. Fix it.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/v4l2_device.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 4cc4a6d656b1..d394632dad4c 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -737,10 +737,9 @@ int V4L2Device::releaseBuffers()\n {\n \tLOG(V4L2, Debug) << \"Releasing bufferPool\";\n \n-\trequestBuffers(0);\n \tbufferPool_ = nullptr;\n \n-\treturn 0;\n+\treturn requestBuffers(0);\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "v7", "4/8" ] }