Patch Detail
Show a patch.
GET /api/1.1/patches/1024/?format=api
{ "id": 1024, "url": "https://patchwork.libcamera.org/api/1.1/patches/1024/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1024/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190417135858.23914-2-jacopo@jmondi.org>", "date": "2019-04-17T13:58:51", "name": "[libcamera-devel,v7,1/8] libcamera: stream: Make Stream inheritable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fa34d1368a9c04cc43dad55009786e0b2cddd7af", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1024/mbox/", "series": [ { "id": 254, "url": "https://patchwork.libcamera.org/api/1.1/series/254/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=254", "date": "2019-04-17T13:58:50", "name": "libcamera: Framework changes to prepare for multiple streams support", "version": 7, "mbox": "https://patchwork.libcamera.org/series/254/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1024/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1024/checks/", "tags": {}, "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F68D60DBF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 17 Apr 2019 15:58:16 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 985064000C;\n\tWed, 17 Apr 2019 13:58:15 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 17 Apr 2019 15:58:51 +0200", "Message-Id": "<20190417135858.23914-2-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190417135858.23914-1-jacopo@jmondi.org>", "References": "<20190417135858.23914-1-jacopo@jmondi.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 1/8] libcamera: stream: Make Stream\n\tinheritable", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 17 Apr 2019 13:58:17 -0000" }, "content": "In preparation for multiple streams support prepare to allow sub-classing\nthe Stream class by removing the 'final' specifier from the class\ndefinition and make its private members protected.\n\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n include/libcamera/stream.h | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex d0f7b0e12485..8a47930f8614 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -43,7 +43,7 @@ private:\n \tSize size_;\n };\n \n-class Stream final\n+class Stream\n {\n public:\n \tclass StillCapture : public StreamUsage\n@@ -68,7 +68,7 @@ public:\n \tBufferPool &bufferPool() { return bufferPool_; }\n \tconst StreamConfiguration &configuration() const { return configuration_; }\n \n-private:\n+protected:\n \tfriend class Camera;\n \n \tBufferPool bufferPool_;\n", "prefixes": [ "libcamera-devel", "v7", "1/8" ] }