Patch Detail
Show a patch.
GET /api/1.1/patches/10207/?format=api
{ "id": 10207, "url": "https://patchwork.libcamera.org/api/1.1/patches/10207/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10207/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201023051021.16389-4-laurent.pinchart@ideasonboard.com>", "date": "2020-10-23T05:10:21", "name": "[libcamera-devel,3/3] libcamera: Declare empty virtual destructors as defaulted", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "fc0a9e76241e601fde992c944edb427a56c86f68", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10207/mbox/", "series": [ { "id": 1405, "url": "https://patchwork.libcamera.org/api/1.1/series/1405/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1405", "date": "2020-10-23T05:10:18", "name": "libcamera: Miscellaneous constructors and destructors cleanups", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1405/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10207/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10207/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23F55C3D3D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 23 Oct 2020 05:11:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E0317615DA;\n\tFri, 23 Oct 2020 07:11:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B352D615D9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Oct 2020 07:11:12 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 52D72BB5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 23 Oct 2020 07:11:12 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Bb5hZaOH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603429872;\n\tbh=QAGVhCbLb7knPbdhW0HJX/WL+MdJh2JgrEf0STmg3dw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Bb5hZaOHFBZID9ramC4glbdtpxdpACqA4SxHpWpJc9U7+dVEokOOxQr6ZYY03boHn\n\tEdzJb3payZr6xQSh4lNJTeVWrbevPWiRDOa43XEY2D7gYG3tErLEus6uf8zQXDzVdq\n\tfAE+pFSvKiNJ2po+EDKKzcA+vIWDD9GLsLrES5LI=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 23 Oct 2020 08:10:21 +0300", "Message-Id": "<20201023051021.16389-4-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>", "References": "<20201023051021.16389-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/3] libcamera: Declare empty virtual\n\tdestructors as defaulted", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The base class of polymorphic classes is required to declare a\ndestructor. Several of these are empty, and can thus be declared as\ndefaulted.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n include/libcamera/bound_method.h | 4 ++--\n include/libcamera/internal/control_validator.h | 2 +-\n include/libcamera/internal/ipa_proxy.h | 2 +-\n include/libcamera/internal/media_object.h | 2 +-\n include/libcamera/internal/pipeline_handler.h | 4 ++--\n include/libcamera/ipa/ipa_interface.h | 2 +-\n src/android/jpeg/encoder.h | 2 +-\n src/android/post_processor.h | 2 +-\n src/cam/options.h | 2 +-\n src/libcamera/pipeline/rkisp1/timeline.h | 4 ++--\n src/qcam/viewfinder.h | 2 +-\n 11 files changed, 14 insertions(+), 14 deletions(-)", "diff": "diff --git a/include/libcamera/bound_method.h b/include/libcamera/bound_method.h\nindex d1e4448304a9..95a956530877 100644\n--- a/include/libcamera/bound_method.h\n+++ b/include/libcamera/bound_method.h\n@@ -26,7 +26,7 @@ enum ConnectionType {\n class BoundMethodPackBase\n {\n public:\n-\tvirtual ~BoundMethodPackBase() {}\n+\tvirtual ~BoundMethodPackBase() = default;\n };\n \n template<typename R, typename... Args>\n@@ -61,7 +61,7 @@ public:\n \t\t: obj_(obj), object_(object), connectionType_(type)\n \t{\n \t}\n-\tvirtual ~BoundMethodBase() {}\n+\tvirtual ~BoundMethodBase() = default;\n \n \ttemplate<typename T, typename std::enable_if_t<!std::is_same<Object, T>::value> * = nullptr>\n \tbool match(T *obj) { return obj == obj_; }\ndiff --git a/include/libcamera/internal/control_validator.h b/include/libcamera/internal/control_validator.h\nindex 4a00b9b7f686..206006954cd9 100644\n--- a/include/libcamera/internal/control_validator.h\n+++ b/include/libcamera/internal/control_validator.h\n@@ -16,7 +16,7 @@ class ControlId;\n class ControlValidator\n {\n public:\n-\tvirtual ~ControlValidator() {}\n+\tvirtual ~ControlValidator() = default;\n \n \tvirtual const std::string &name() const = 0;\n \tvirtual bool validate(unsigned int id) const = 0;\ndiff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h\nindex b429ce5a68a3..49399f4eb856 100644\n--- a/include/libcamera/internal/ipa_proxy.h\n+++ b/include/libcamera/internal/ipa_proxy.h\n@@ -42,7 +42,7 @@ class IPAProxyFactory\n {\n public:\n \tIPAProxyFactory(const char *name);\n-\tvirtual ~IPAProxyFactory() {}\n+\tvirtual ~IPAProxyFactory() = default;\n \n \tvirtual std::unique_ptr<IPAProxy> create(IPAModule *ipam) = 0;\n \ndiff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\nindex 54311c14895b..43a35bef8f35 100644\n--- a/include/libcamera/internal/media_object.h\n+++ b/include/libcamera/internal/media_object.h\n@@ -31,7 +31,7 @@ protected:\n \t\t: dev_(dev), id_(id)\n \t{\n \t}\n-\tvirtual ~MediaObject() {}\n+\tvirtual ~MediaObject() = default;\n \n \tMediaDevice *dev_;\n \tunsigned int id_;\ndiff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\nindex a4e1b529c461..c12c8904858e 100644\n--- a/include/libcamera/internal/pipeline_handler.h\n+++ b/include/libcamera/internal/pipeline_handler.h\n@@ -40,7 +40,7 @@ public:\n \t\t: pipe_(pipe)\n \t{\n \t}\n-\tvirtual ~CameraData() {}\n+\tvirtual ~CameraData() = default;\n \n \tCamera *camera_;\n \tPipelineHandler *pipe_;\n@@ -118,7 +118,7 @@ class PipelineHandlerFactory\n {\n public:\n \tPipelineHandlerFactory(const char *name);\n-\tvirtual ~PipelineHandlerFactory() {}\n+\tvirtual ~PipelineHandlerFactory() = default;\n \n \tstd::shared_ptr<PipelineHandler> create(CameraManager *manager);\n \ndiff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\nindex 5016ec25ea9c..322b7079070e 100644\n--- a/include/libcamera/ipa/ipa_interface.h\n+++ b/include/libcamera/ipa/ipa_interface.h\n@@ -150,7 +150,7 @@ struct CameraSensorInfo;\n class IPAInterface\n {\n public:\n-\tvirtual ~IPAInterface() {}\n+\tvirtual ~IPAInterface() = default;\n \n \tvirtual int init(const IPASettings &settings) = 0;\n \tvirtual int start() = 0;\ndiff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\nindex 270ea6091798..0ca2ba38c528 100644\n--- a/src/android/jpeg/encoder.h\n+++ b/src/android/jpeg/encoder.h\n@@ -14,7 +14,7 @@\n class Encoder\n {\n public:\n-\tvirtual ~Encoder() {}\n+\tvirtual ~Encoder() = default;\n \n \tvirtual int configure(const libcamera::StreamConfiguration &cfg) = 0;\n \tvirtual int encode(const libcamera::FrameBuffer &source,\ndiff --git a/src/android/post_processor.h b/src/android/post_processor.h\nindex 5f87a5d1bc30..e0f91880f0bf 100644\n--- a/src/android/post_processor.h\n+++ b/src/android/post_processor.h\n@@ -16,7 +16,7 @@ class CameraMetadata;\n class PostProcessor\n {\n public:\n-\tvirtual ~PostProcessor() {}\n+\tvirtual ~PostProcessor() = default;\n \n \tvirtual int configure(const libcamera::StreamConfiguration &inCfg,\n \t\t\t const libcamera::StreamConfiguration &outCfg) = 0;\ndiff --git a/src/cam/options.h b/src/cam/options.h\nindex 184866195eef..f02eeca2eef9 100644\n--- a/src/cam/options.h\n+++ b/src/cam/options.h\n@@ -73,7 +73,7 @@ public:\n \t{\n \t};\n \n-\tvirtual ~KeyValueParser() {}\n+\tvirtual ~KeyValueParser() = default;\n \n \tbool addOption(const char *name, OptionType type, const char *help,\n \t\t OptionArgument argument = ArgumentNone);\ndiff --git a/src/libcamera/pipeline/rkisp1/timeline.h b/src/libcamera/pipeline/rkisp1/timeline.h\nindex 88f99329873d..0c37b06fa6df 100644\n--- a/src/libcamera/pipeline/rkisp1/timeline.h\n+++ b/src/libcamera/pipeline/rkisp1/timeline.h\n@@ -22,7 +22,7 @@ public:\n \tFrameAction(unsigned int frame, unsigned int type)\n \t\t: frame_(frame), type_(type) {}\n \n-\tvirtual ~FrameAction() {}\n+\tvirtual ~FrameAction() = default;\n \n \tunsigned int frame() const { return frame_; }\n \tunsigned int type() const { return type_; }\n@@ -38,7 +38,7 @@ class Timeline\n {\n public:\n \tTimeline();\n-\tvirtual ~Timeline() {}\n+\tvirtual ~Timeline() = default;\n \n \tvirtual void reset();\n \tvirtual void scheduleAction(std::unique_ptr<FrameAction> action);\ndiff --git a/src/qcam/viewfinder.h b/src/qcam/viewfinder.h\nindex 67da1df26a0c..e33dc4525224 100644\n--- a/src/qcam/viewfinder.h\n+++ b/src/qcam/viewfinder.h\n@@ -22,7 +22,7 @@ struct MappedBuffer {\n class ViewFinder\n {\n public:\n-\tvirtual ~ViewFinder() {}\n+\tvirtual ~ViewFinder() = default;\n \n \tvirtual const QList<libcamera::PixelFormat> &nativeFormats() const = 0;\n \n", "prefixes": [ "libcamera-devel", "3/3" ] }