Patch Detail
Show a patch.
GET /api/1.1/patches/10201/?format=api
{ "id": 10201, "url": "https://patchwork.libcamera.org/api/1.1/patches/10201/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10201/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201022135605.614240-4-kieran.bingham@ideasonboard.com>", "date": "2020-10-22T13:56:03", "name": "[libcamera-devel,3/5] libcamera: media_object: Utilise DELETE_COPY_AND_ASSIGN", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6553c3b2fc5da3b10cd278f11f6c1f440bdd9c97", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10201/mbox/", "series": [ { "id": 1404, "url": "https://patchwork.libcamera.org/api/1.1/series/1404/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1404", "date": "2020-10-22T13:56:00", "name": "Delete Copy-Move-Assign", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1404/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10201/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10201/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36013C3D3C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Oct 2020 13:56:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04B8061454;\n\tThu, 22 Oct 2020 15:56:15 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 522E16145E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Oct 2020 15:56:11 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B1FB6A43;\n\tThu, 22 Oct 2020 15:56:10 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nxJflIFB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603374970;\n\tbh=cIbVd7dh1s4WlnHThYctC8seCrPnYhJyU/p31yBgpjI=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=nxJflIFBXZCLfui/KiwTT5/ZUh9hZrnnfCWDvl+Q20pN8gks1LoFiqCnBoB42AqzI\n\tnysGF22izx43aEW3XaxRkKGzhWvVrilFmbOb38WTfDWSIrSKQu2KWmDLAjipebMtDP\n\tdGc0Ku7iHnn8kUBTsJ6VwtlXtrw1EuS+8BiXQZEo=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 22 Oct 2020 14:56:03 +0100", "Message-Id": "<20201022135605.614240-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201022135605.614240-1-kieran.bingham@ideasonboard.com>", "References": "<20201022135605.614240-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/5] libcamera: media_object: Utilise\n\tDELETE_COPY_AND_ASSIGN", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Convert MediaLink, MediaPad, and MediaEntity to declare DELETE_COPY_AND_ASSIGN.\nThese classes already deleted their copy constructor but not the assignment operator.\n\nUtilising the DELETE_COPY_AND_ASSIGN prevents all copying of these classes.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/internal/media_object.h | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/include/libcamera/internal/media_object.h b/include/libcamera/internal/media_object.h\nindex be6fb8961349..f467883072d2 100644\n--- a/include/libcamera/internal/media_object.h\n+++ b/include/libcamera/internal/media_object.h\n@@ -12,6 +12,8 @@\n \n #include <linux/media.h>\n \n+#include <libcamera/class.h>\n+\n namespace libcamera {\n \n class MediaDevice;\n@@ -50,7 +52,7 @@ private:\n \n \tMediaLink(const struct media_v2_link *link,\n \t\t MediaPad *source, MediaPad *sink);\n-\tMediaLink(const MediaLink &) = delete;\n+\tDELETE_COPY_AND_ASSIGN(MediaLink);\n \t~MediaLink() {}\n \n \tMediaPad *source_;\n@@ -72,7 +74,7 @@ private:\n \tfriend class MediaDevice;\n \n \tMediaPad(const struct media_v2_pad *pad, MediaEntity *entity);\n-\tMediaPad(const MediaPad &) = delete;\n+\tDELETE_COPY_AND_ASSIGN(MediaPad);\n \t~MediaPad();\n \n \tunsigned int index_;\n@@ -104,7 +106,7 @@ private:\n \n \tMediaEntity(MediaDevice *dev, const struct media_v2_entity *entity,\n \t\t unsigned int major = 0, unsigned int minor = 0);\n-\tMediaEntity(const MediaEntity &) = delete;\n+\tDELETE_COPY_AND_ASSIGN(MediaEntity);\n \t~MediaEntity();\n \n \tvoid addPad(MediaPad *pad);\n", "prefixes": [ "libcamera-devel", "3/5" ] }