Patch Detail
Show a patch.
GET /api/1.1/patches/10200/?format=api
{ "id": 10200, "url": "https://patchwork.libcamera.org/api/1.1/patches/10200/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10200/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201022135605.614240-3-kieran.bingham@ideasonboard.com>", "date": "2020-10-22T13:56:02", "name": "[libcamera-devel,2/5] libcamera: buffer: Utilise DELETE_COPY_MOVE_AND_ASSIGN", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "9de5614f7758fb874df99f4245dbc7e3d43c1604", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10200/mbox/", "series": [ { "id": 1404, "url": "https://patchwork.libcamera.org/api/1.1/series/1404/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1404", "date": "2020-10-22T13:56:00", "name": "Delete Copy-Move-Assign", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1404/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10200/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10200/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE87FC3D3C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Oct 2020 13:56:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9A29E6146E;\n\tThu, 22 Oct 2020 15:56:11 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C329610B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Oct 2020 15:56:10 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1017453;\n\tThu, 22 Oct 2020 15:56:10 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aoq3fpbg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603374970;\n\tbh=nDYTPfi/m7qecYLzCqIBaQXRGAFsD4RyGR2LgJiX1Hk=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=aoq3fpbg90skWnIj41NOeu5tF44x3aWEX5dz6fKRrNd5DpIidvUflnA+81P0exzTC\n\tqMPICaYFCw5lVbkCDolV3L/wfjrtLEKBpEUfgnbB8ox/LEibM1WIOJsMO45e+5Jvgo\n\t2UcBp37/5yzonDGqa/y9yxeZvvrVnGZHLH7ZsJBE=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Thu, 22 Oct 2020 14:56:02 +0100", "Message-Id": "<20201022135605.614240-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201022135605.614240-1-kieran.bingham@ideasonboard.com>", "References": "<20201022135605.614240-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/5] libcamera: buffer: Utilise\n\tDELETE_COPY_MOVE_AND_ASSIGN", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/buffer.h | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/include/libcamera/buffer.h b/include/libcamera/buffer.h\nindex a26c8927d37a..42a20a387781 100644\n--- a/include/libcamera/buffer.h\n+++ b/include/libcamera/buffer.h\n@@ -10,6 +10,7 @@\n #include <stdint.h>\n #include <vector>\n \n+#include <libcamera/class.h>\n #include <libcamera/file_descriptor.h>\n \n namespace libcamera {\n@@ -43,12 +44,6 @@ public:\n \n \tFrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);\n \n-\tFrameBuffer(const FrameBuffer &) = delete;\n-\tFrameBuffer(FrameBuffer &&) = delete;\n-\n-\tFrameBuffer &operator=(const FrameBuffer &) = delete;\n-\tFrameBuffer &operator=(FrameBuffer &&) = delete;\n-\n \tconst std::vector<Plane> &planes() const { return planes_; }\n \n \tRequest *request() const { return request_; }\n@@ -57,7 +52,10 @@ public:\n \n \tunsigned int cookie() const { return cookie_; }\n \tvoid setCookie(unsigned int cookie) { cookie_ = cookie; }\n+\n private:\n+\tDELETE_COPY_MOVE_AND_ASSIGN(FrameBuffer);\n+\n \tfriend class Request; /* Needed to update request_. */\n \tfriend class V4L2VideoDevice; /* Needed to update metadata_. */\n \n", "prefixes": [ "libcamera-devel", "2/5" ] }