Patch Detail
Show a patch.
GET /api/1.1/patches/10196/?format=api
{ "id": 10196, "url": "https://patchwork.libcamera.org/api/1.1/patches/10196/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10196/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201022081731.36217-3-tomi.valkeinen@iki.fi>", "date": "2020-10-22T08:17:30", "name": "[libcamera-devel,3/4] libcamera: pipeline: simple: return from match() on error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "00603a73eaf98b080030b099ad1b9ce27a2966d7", "submitter": { "id": 70, "url": "https://patchwork.libcamera.org/api/1.1/people/70/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@iki.fi" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10196/mbox/", "series": [ { "id": 1403, "url": "https://patchwork.libcamera.org/api/1.1/series/1403/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1403", "date": "2020-10-22T08:17:28", "name": "[libcamera-devel,1/4] Add .clang-tidy", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1403/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10196/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10196/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35007C3D3C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 22 Oct 2020 08:17:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 02EF961451;\n\tThu, 22 Oct 2020 10:17:55 +0200 (CEST)", "from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CC4760530\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Oct 2020 10:17:51 +0200 (CEST)", "by mail-lj1-x22b.google.com with SMTP id x16so992792ljh.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 22 Oct 2020 01:17:51 -0700 (PDT)", "from deskari.lan (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tl3sm187007lji.36.2020.10.22.01.17.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 22 Oct 2020 01:17:50 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ksB+2PMK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=jqnB/BtIX3D+kr8HI42UutvPxNkoC0nsGGkFaAmI3UA=;\n\tb=ksB+2PMKUkEjBJG2W0qs3LEb+46ybxio2KjnS2AViaBDJPSuEuRYaKYFrzV5QgPaZv\n\tqtaupfLb1IBDvqQYx3RHBdiPpAaaZg30jSwuAc4mD/O/MfxDd7ZJhNdNUkyRBrHiUfdt\n\tEX9EhCMsciiUcQr5IiUL2zcmGmfbdg4r50VbM+evaRXMQT/lpEa0CriDw463Ppf1wpyD\n\tlH+UiTWypgO7mBB6tED1lzEvV2pGtXD9jxje8A/wB0eGhKmZK1Un2NvyqSs6H1Ah0sUA\n\teglbuJK8tZKLDko28VIfxHSehrtjJgOnEhFIp71CGfHCb7rw7+fqCxZPa6cGueBfnQVe\n\todkQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=jqnB/BtIX3D+kr8HI42UutvPxNkoC0nsGGkFaAmI3UA=;\n\tb=a276j/GnnHS2T3M+7DfN8rMB/dbCsGV0ktJtJeBOTzaCJSZdQe6IAUEGhG6tHvNACs\n\tpqKj1HbAaqFj81C5De/3seDratp4WXeoigew4RMEkMuAQ2OvOyjvbSfPzYksCVKPrS/+\n\taYZ2cEiTKHTtUKoC8aaV7l6p/D2ciY2Go09bIiiYzFiqzm0n+oPsxQwp1DGLu5ihYuWS\n\t0pplAuiJLoW2JO8cFL0Qal2H/NYaCPvvxmA8Fl1QIpvY/0CSVlqON2l+pZekYpvNGDvx\n\tG3NthuquK6pyCR8OqTw9wyMiUVXb44Z+5buuXk3G0gfIq+lCXVTGhefmtJqOkNFb3R2d\n\t9zgA==", "X-Gm-Message-State": "AOAM532MmSD3P2AkcuCGOzw/Gdym9lUudcyZExPf8hU9xlGzUFHoFjxK\n\t1U4zM33lUQkyOPKNUk0n9CR8x2nLqWQDfQ==", "X-Google-Smtp-Source": "ABdhPJydL2crB5lJ2RVItKDoTae90TtBB4F4mJWxXI/VxijH9duZhD8bkjuBOj0DqIGANrvFXrip5w==", "X-Received": "by 2002:a2e:9689:: with SMTP id q9mr505355lji.434.1603354670503; \n\tThu, 22 Oct 2020 01:17:50 -0700 (PDT)", "From": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 22 Oct 2020 11:17:30 +0300", "Message-Id": "<20201022081731.36217-3-tomi.valkeinen@iki.fi>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201022081731.36217-1-tomi.valkeinen@iki.fi>", "References": "<20201022081731.36217-1-tomi.valkeinen@iki.fi>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/4] libcamera: pipeline: simple: return\n\tfrom match() on error", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If converter_->open() fails, the code deletes the converter_ but then\nhappily goes on, and at the very next lines will use converter_.\n\nI assume the intention is to return from the function with false.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@iki.fi>\n---\n src/libcamera/pipeline/simple/simple.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 0d48e1b6..df93bc8d 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -774,6 +774,7 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n \t\t\t\t<< \"Failed to open converter, disabling format conversion\";\n \t\t\tdelete converter_;\n \t\t\tconverter_ = nullptr;\n+\t\t\treturn false;\n \t\t}\n \n \t\tconverter_->bufferReady.connect(this, &SimplePipelineHandler::converterDone);\n", "prefixes": [ "libcamera-devel", "3/4" ] }