Patch Detail
Show a patch.
GET /api/1.1/patches/10127/?format=api
{ "id": 10127, "url": "https://patchwork.libcamera.org/api/1.1/patches/10127/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10127/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201020091505.138898-3-hiroh@chromium.org>", "date": "2020-10-20T09:15:00", "name": "[libcamera-devel,v2,3/8] gstreamer: Omit extra semicolons", "commit_ref": "da0dd36149eaebd76251a2866603da3753909ff3", "pull_url": null, "state": "accepted", "archived": false, "hash": "daab1473d90396858b81eaf7f6e5fc4a0f88d8ed", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10127/mbox/", "series": [ { "id": 1390, "url": "https://patchwork.libcamera.org/api/1.1/series/1390/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1390", "date": "2020-10-20T09:14:58", "name": "[libcamera-devel,v2,1/8] test: Omit extra semicolons", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1390/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10127/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10127/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8F78BBDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 09:15:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6059D613C2;\n\tTue, 20 Oct 2020 11:15:19 +0200 (CEST)", "from mail-pf1-x443.google.com (mail-pf1-x443.google.com\n\t[IPv6:2607:f8b0:4864:20::443])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66E8361373\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 11:15:17 +0200 (CEST)", "by mail-pf1-x443.google.com with SMTP id j18so846651pfa.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 02:15:17 -0700 (PDT)", "from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tp8sm1482014pgs.34.2020.10.20.02.15.14\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Oct 2020 02:15:15 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"H6c1swlr\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=eGTB6f569amkDZmVIRTDUmNO7biVX4a196hfyx/h1gI=;\n\tb=H6c1swlrVfs3wPFi8xa/5oSLDNBOX40chzC8TO4A1LD3sssm2sWpJjVWXt4gW9PDqA\n\t00oSiCfV+JaViIPil0RTPT1i6t6ZzfRtvc0ocTFQRhS6dLMFxJqfYNpuio24zojoEOkr\n\tqqvDLruWjDZkQqOHiAqtGEt1niEtP43UN78Ic=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=eGTB6f569amkDZmVIRTDUmNO7biVX4a196hfyx/h1gI=;\n\tb=N4Wgil9v3eoFDRp5c4WGua0NkA8P3S6x68wmb+qhd9rf11gD4pQ7UIak01s+Tqjjbj\n\tj0aOjv3yifOjJTrZwGTbGICWtHePFDzCtnHEHdm7nsAM6GH3yLHviQmAsLryx9Fy+HqS\n\tGb61bPxwjyycRQOkltXpxpt57ZzoioNcKatrsDFxCpW8LFstOCpvhRDVTgW/J20618PC\n\trMxeUsourEJfLsx4TK4dljMKdNxVks4ydldHWtU8fXg/5MEk33adqs3Ag6MUOGQg8ZMK\n\teKX1wWLAFseMD4YONUuCtMNBKez295NkRGwowDhBBJOwfOvswF7TD/iL7LoZ8dlOh8gR\n\tsNkg==", "X-Gm-Message-State": "AOAM530XW9OUB+2S+uTo/v5H8SmnsNV1qBtVNN7dXtaE7rcbCCdOcGh/\n\tx1mjlKW1NH9YFrxhUAMirJaIZmlLJ/gSsg==", "X-Google-Smtp-Source": "ABdhPJyRh/6qbgIb4kN1ifwAFtQFfu2+PsfcCsJQkypAZmiWkyz3nxbtZHqq/3Wa5Fa2vu8f/Njlkg==", "X-Received": "by 2002:aa7:9823:0:b029:158:ee6b:e939 with SMTP id\n\tq3-20020aa798230000b0290158ee6be939mr1795776pfl.37.1603185315819; \n\tTue, 20 Oct 2020 02:15:15 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Oct 2020 18:15:00 +0900", "Message-Id": "<20201020091505.138898-3-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.29.0.rc1.297.gfa9743e501-goog", "In-Reply-To": "<20201020091505.138898-1-hiroh@chromium.org>", "References": "<20201020091505.138898-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 3/8] gstreamer: Omit extra semicolons", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Macros used in gstreamer (e.g. G_DEFINE_TYPE) are functions. The\nend semicolons with the macros are unnecessary.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/gstreamer/gstlibcamera.cpp | 2 +-\n src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n src/gstreamer/gstlibcamerapad.cpp | 2 +-\n src/gstreamer/gstlibcamerapool.cpp | 2 +-\n src/gstreamer/gstlibcameraprovider.cpp | 6 +++---\n src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n 6 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/gstreamer/gstlibcamera.cpp b/src/gstreamer/gstlibcamera.cpp\nindex 81c7bb1..52388b5 100644\n--- a/src/gstreamer/gstlibcamera.cpp\n+++ b/src/gstreamer/gstlibcamera.cpp\n@@ -24,4 +24,4 @@ plugin_init(GstPlugin *plugin)\n \n GST_PLUGIN_DEFINE(GST_VERSION_MAJOR, GST_VERSION_MINOR,\n \t\t libcamera, \"libcamera capture plugin\",\n-\t\t plugin_init, VERSION, \"LGPL\", PACKAGE, \"https://libcamera.org\");\n+\t\t plugin_init, VERSION, \"LGPL\", PACKAGE, \"https://libcamera.org\")\ndiff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\nindex 78ded40..13c6b49 100644\n--- a/src/gstreamer/gstlibcameraallocator.cpp\n+++ b/src/gstreamer/gstlibcameraallocator.cpp\n@@ -101,7 +101,7 @@ struct _GstLibcameraAllocator {\n };\n \n G_DEFINE_TYPE(GstLibcameraAllocator, gst_libcamera_allocator,\n-\t GST_TYPE_DMABUF_ALLOCATOR);\n+\t GST_TYPE_DMABUF_ALLOCATOR)\n \n static gboolean\n gst_libcamera_allocator_release(GstMiniObject *mini_object)\ndiff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex 9f3e2be..c00e81c 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -27,7 +27,7 @@ enum {\n \tPROP_STREAM_ROLE\n };\n \n-G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD);\n+G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD)\n \n static void\n gst_libcamera_pad_set_property(GObject *object, guint prop_id,\ndiff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp\nindex b756ee3..62db184 100644\n--- a/src/gstreamer/gstlibcamerapool.cpp\n+++ b/src/gstreamer/gstlibcamerapool.cpp\n@@ -29,7 +29,7 @@ struct _GstLibcameraPool {\n \tStream *stream;\n };\n \n-G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL);\n+G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL)\n \n static GstFlowReturn\n gst_libcamera_pool_acquire_buffer(GstBufferPool *pool, GstBuffer **buffer,\ndiff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex cd850d8..ee44dc7 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -35,14 +35,14 @@ enum {\n \n #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type()\n G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device,\n-\t\t GST_LIBCAMERA, DEVICE, GstDevice);\n+\t\t GST_LIBCAMERA, DEVICE, GstDevice)\n \n struct _GstLibcameraDevice {\n \tGstDevice parent;\n \tgchar *name;\n };\n \n-G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE);\n+G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE)\n \n static GstElement *\n gst_libcamera_device_create_element(GstDevice *device, const gchar *name)\n@@ -164,7 +164,7 @@ struct _GstLibcameraProvider {\n G_DEFINE_TYPE_WITH_CODE(GstLibcameraProvider, gst_libcamera_provider,\n \t\t\tGST_TYPE_DEVICE_PROVIDER,\n \t\t\tGST_DEBUG_CATEGORY_INIT(provider_debug, \"libcamera-provider\", 0,\n-\t\t\t\t\t\t\"libcamera Device Provider\"));\n+\t\t\t\t\t\t\"libcamera Device Provider\"))\n \n static GList *\n gst_libcamera_provider_probe(GstDeviceProvider *provider)\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 5001083..a099508 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -140,7 +140,7 @@ enum {\n \n G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT,\n \t\t\tGST_DEBUG_CATEGORY_INIT(source_debug, \"libcamerasrc\", 0,\n-\t\t\t\t\t\t\"libcamera Source\"));\n+\t\t\t\t\t\t\"libcamera Source\"))\n \n #define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; image/jpeg\")\n \n", "prefixes": [ "libcamera-devel", "v2", "3/8" ] }