Patch Detail
Show a patch.
GET /api/1.1/patches/10126/?format=api
{ "id": 10126, "url": "https://patchwork.libcamera.org/api/1.1/patches/10126/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10126/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201020091505.138898-2-hiroh@chromium.org>", "date": "2020-10-20T09:14:59", "name": "[libcamera-devel,v2,2/8] v4l2: Omit extra semicolons", "commit_ref": "62192575627ac900ce249a1be735d13902649391", "pull_url": null, "state": "accepted", "archived": false, "hash": "d12a651cdb96014e3ec96914ffdca5b36836c1a1", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10126/mbox/", "series": [ { "id": 1390, "url": "https://patchwork.libcamera.org/api/1.1/series/1390/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1390", "date": "2020-10-20T09:14:58", "name": "[libcamera-devel,v2,1/8] test: Omit extra semicolons", "version": 2, "mbox": "https://patchwork.libcamera.org/series/1390/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10126/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10126/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 37E83BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 09:15:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 029CE610C4;\n\tTue, 20 Oct 2020 11:15:17 +0200 (CEST)", "from mail-pf1-x442.google.com (mail-pf1-x442.google.com\n\t[IPv6:2607:f8b0:4864:20::442])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D2A36052F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 11:15:16 +0200 (CEST)", "by mail-pf1-x442.google.com with SMTP id 10so833307pfp.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 02:15:15 -0700 (PDT)", "from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tp8sm1482014pgs.34.2020.10.20.02.15.12\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Oct 2020 02:15:13 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"kYqLJbhw\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Y8Is3A32fjh+CVX7gMxhWiFjjMSYUt4UBTXqCbxzLw8=;\n\tb=kYqLJbhwTsLK3CM6S1IFk7LA+rqrX1DVqV/TbdFb5zi4rZ3Phj9ANwyAjKY7p3Jess\n\tPFTzXRhc4BasmEAMwZCss/tqS4EguPHterQ7SusUgqaZFojrmxR5uU5ZASttykCzhdth\n\t3UMzK0ITtr4Yq1oR/H7xU0250RbsTYfXfqnTc=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Y8Is3A32fjh+CVX7gMxhWiFjjMSYUt4UBTXqCbxzLw8=;\n\tb=IRV+zmozh7MoGfYSibxWHWE/3fyWD1DIO+1xY+cxVT6FSW/7N5Il+X6y8AVDTVx1ix\n\tSl862f3Oswz3yVrnKKCrlmjWPq9F766e/tOO1CIuWPLsCH24nJt3qxBZ2TPKPop+s/s/\n\tSIwDf5tbm3Ei40UFrM7gF4QuubfF/buOd+FYhAfs9wKTja6b1c3BnNjxD0B9MoDGqqX5\n\twzCesV6nmCEiSKeZAjG+TqJqn+gm/FfYyHSY9jM2T9djssK1kIbOyvPLozeIFbM4LCcw\n\tQtophLpzQm28yBwuiEGNIzYlfSwqDOuL79FjI37LwXa78f7L3fI71+8P7HlsnWNt6OkB\n\tc2mA==", "X-Gm-Message-State": "AOAM5328iSd1K3Q/LFlm+Lhcpy5RGLhDCCqtQONkJuTXB1m2wVRsFO5f\n\twPMHzLpBbm2DK48mYXfW1xpqeaQaFKfbJw==", "X-Google-Smtp-Source": "ABdhPJxyQg0tPqqJWd0VaUIKedRQit4LZNz6xvjZh6YVNZkNde3zN++NV6YM7uVDb55fEw2ZaF8sRA==", "X-Received": "by 2002:a63:5f53:: with SMTP id t80mr1907328pgb.62.1603185314035;\n\tTue, 20 Oct 2020 02:15:14 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Oct 2020 18:14:59 +0900", "Message-Id": "<20201020091505.138898-2-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.29.0.rc1.297.gfa9743e501-goog", "In-Reply-To": "<20201020091505.138898-1-hiroh@chromium.org>", "References": "<20201020091505.138898-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v2 2/8] v4l2: Omit extra semicolons", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "LOG_DECLARE_CATEGORY macro contains the semicolon. The end\nsemicolon with the macro is unnecessary.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/v4l2/v4l2_camera.cpp | 2 +-\n src/v4l2/v4l2_camera_proxy.cpp | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/v4l2/v4l2_camera.cpp b/src/v4l2/v4l2_camera.cpp\nindex 35d3bed..97825c7 100644\n--- a/src/v4l2/v4l2_camera.cpp\n+++ b/src/v4l2/v4l2_camera.cpp\n@@ -14,7 +14,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(V4L2Compat);\n+LOG_DECLARE_CATEGORY(V4L2Compat)\n \n V4L2Camera::V4L2Camera(std::shared_ptr<Camera> camera)\n \t: camera_(camera), isRunning_(false), bufferAllocator_(nullptr),\ndiff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 8ff990f..7803d37 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -32,7 +32,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(V4L2Compat);\n+LOG_DECLARE_CATEGORY(V4L2Compat)\n \n V4L2CameraProxy::V4L2CameraProxy(unsigned int index,\n \t\t\t\t std::shared_ptr<Camera> camera)\n", "prefixes": [ "libcamera-devel", "v2", "2/8" ] }