Patch Detail
Show a patch.
GET /api/1.1/patches/10116/?format=api
{ "id": 10116, "url": "https://patchwork.libcamera.org/api/1.1/patches/10116/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10116/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201020052905.89267-5-hiroh@chromium.org>", "date": "2020-10-20T05:29:01", "name": "[libcamera-devel,4/8] android: Omit extra semicolons", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "54fec2431bd72acc59e165eafa8a8f00d27108c6", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10116/mbox/", "series": [ { "id": 1388, "url": "https://patchwork.libcamera.org/api/1.1/series/1388/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1388", "date": "2020-10-20T05:28:58", "name": "[libcamera-devel,1/8] test: Omit extra semicolons", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1388/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10116/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10116/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD14ABDB13\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 05:29:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 77E306052F;\n\tTue, 20 Oct 2020 07:29:24 +0200 (CEST)", "from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com\n\t[IPv6:2607:f8b0:4864:20::62c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 36EEE60351\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 07:29:23 +0200 (CEST)", "by mail-pl1-x62c.google.com with SMTP id h2so396482pll.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 Oct 2020 22:29:23 -0700 (PDT)", "from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tj4sm779043pfd.101.2020.10.19.22.29.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 19 Oct 2020 22:29:21 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"aoo/RTFP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=DahGBmqF9ZibJSYRWi32xAezOhzN/k4+lLgqqvwqQwc=;\n\tb=aoo/RTFPyrRekVFxwxZruNDnEf6MMox0u3w3bG/jl1X/i+5yknXbko61AzdTtI5sXI\n\tJAEf/HSR3F4ZmtqXV7JYzbDdBCoeU6AmW4thYWg0D8sQo69dpjX/OudfiHx3m674IIdC\n\tfluDcZ/U2uXCIj+ZlJ9TBBa3bA8DAB1K/Wzi4=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=DahGBmqF9ZibJSYRWi32xAezOhzN/k4+lLgqqvwqQwc=;\n\tb=E7hWlCynZsQgeYYX0ebhVt1TEbrIZpqy69nTsFHZfa3svtjTeZs/SC5t9Y5oyryU/J\n\tvPdt1EWvcNJj4WDOPReeQN4EJIYS0ivcbXzWdkWH/o8DYXwC0u2+Ye3iwOjHgJalxpf9\n\tpdcIyoLndMTEBljgrprv585t1Dy7zwzB0iitzadH8+RQ3vhXHj3CfegKZVHYoK2mFVwf\n\tsUtUU6NlQxjiHaQ9pZXue5aCNw8LoEb52V6I5jwl+gfHixEQYdPoCKcJygf2Tua1KOxo\n\tw/2PlciVOSq2hhUgTXb/MzQjtp7tEPljVHVL0lum7ViLbOh/7zvZ111KMFaPe6Oidad+\n\tAblA==", "X-Gm-Message-State": "AOAM533x7Lanz2SLEbrjmDn0ym3sG3vr+aCXdIFBQvdJKf1ryztwYXJ8\n\tpATLVUPySoCDdO55mrgBlhbw6o0D4ux9YQ==", "X-Google-Smtp-Source": "ABdhPJwQSdYSFIJ8xDknYxjx6uNRca+mSmksCdmvOcikyWZzkaWVlcOvFBVA6+wM2FK3rjIVre8QSg==", "X-Received": "by 2002:a17:90a:d345:: with SMTP id\n\ti5mr1294119pjx.150.1603171761646; \n\tMon, 19 Oct 2020 22:29:21 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Oct 2020 14:29:01 +0900", "Message-Id": "<20201020052905.89267-5-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.29.0.rc1.297.gfa9743e501-goog", "In-Reply-To": "<20201020052905.89267-1-hiroh@chromium.org>", "References": "<20201020052905.89267-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 4/8] android: Omit extra semicolons", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The end semicolons with LOG_DECLARE_CATEGORY and\nLOG_DEFINE_CATEGORY are unnecessary.\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/android/camera_device.cpp | 2 +-\n src/android/camera_hal_manager.cpp | 2 +-\n src/android/camera_metadata.cpp | 2 +-\n src/android/camera_stream.cpp | 2 +-\n src/android/camera_worker.cpp | 2 +-\n src/android/jpeg/encoder.h | 2 +-\n src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n 8 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex d706cf4..e9404c2 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -129,7 +129,7 @@ const std::map<int, const Camera3Format> camera3FormatsMap = {\n \n } /* namespace */\n \n-LOG_DECLARE_CATEGORY(HAL);\n+LOG_DECLARE_CATEGORY(HAL)\n \n MappedCamera3Buffer::MappedCamera3Buffer(const buffer_handle_t camera3buffer,\n \t\t\t\t\t int flags)\ndiff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 2a33f9b..189eda2 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -16,7 +16,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(HAL);\n+LOG_DECLARE_CATEGORY(HAL)\n \n /*\n * \\class CameraHalManager\ndiff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\nindex f0da9ea..edea48f 100644\n--- a/src/android/camera_metadata.cpp\n+++ b/src/android/camera_metadata.cpp\n@@ -11,7 +11,7 @@\n \n using namespace libcamera;\n \n-LOG_DEFINE_CATEGORY(CameraMetadata);\n+LOG_DEFINE_CATEGORY(CameraMetadata)\n \n CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity)\n {\ndiff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex 1b8afa8..eae451e 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -15,7 +15,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(HAL);\n+LOG_DECLARE_CATEGORY(HAL)\n \n /*\n * \\class CameraStream\ndiff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp\nindex ff09b75..df43646 100644\n--- a/src/android/camera_worker.cpp\n+++ b/src/android/camera_worker.cpp\n@@ -15,7 +15,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(HAL);\n+LOG_DECLARE_CATEGORY(HAL)\n \n /*\n * \\class CaptureRequest\ndiff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\nindex 4483153..4e85996 100644\n--- a/src/android/jpeg/encoder.h\n+++ b/src/android/jpeg/encoder.h\n@@ -14,7 +14,7 @@\n class Encoder\n {\n public:\n-\tvirtual ~Encoder() {};\n+\tvirtual ~Encoder() {}\n \n \tvirtual int configure(const libcamera::StreamConfiguration &cfg) = 0;\n \tvirtual int encode(const libcamera::FrameBuffer *source,\ndiff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\nindex 8995ba5..f11e004 100644\n--- a/src/android/jpeg/encoder_libjpeg.cpp\n+++ b/src/android/jpeg/encoder_libjpeg.cpp\n@@ -25,7 +25,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(JPEG);\n+LOG_DECLARE_CATEGORY(JPEG)\n \n namespace {\n \ndiff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex 753c28e..9d452b7 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -18,7 +18,7 @@\n \n using namespace libcamera;\n \n-LOG_DEFINE_CATEGORY(JPEG);\n+LOG_DEFINE_CATEGORY(JPEG)\n \n PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device)\n \t: cameraDevice_(device)\n", "prefixes": [ "libcamera-devel", "4/8" ] }