Patch Detail
Show a patch.
GET /api/1.1/patches/10104/?format=api
{ "id": 10104, "url": "https://patchwork.libcamera.org/api/1.1/patches/10104/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10104/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201020000310.3008-5-laurent.pinchart@ideasonboard.com>", "date": "2020-10-20T00:03:09", "name": "[libcamera-devel,4/5] libcamera: Drop semicolon after LOG_{DECLARE, DEFINE}_CATEGORY", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "842cee3c7c7e3c1ea662f2512f246bb961caed55", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": { "id": 14, "url": "https://patchwork.libcamera.org/api/1.1/users/14/?format=api", "username": "pinchartl", "first_name": "Laurent", "last_name": "Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/10104/mbox/", "series": [ { "id": 1385, "url": "https://patchwork.libcamera.org/api/1.1/series/1385/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1385", "date": "2020-10-20T00:03:05", "name": "libcamera: Miscellaneous documentation fixes", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1385/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10104/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10104/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 10FB8BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Oct 2020 00:04:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D42B7610C4;\n\tTue, 20 Oct 2020 02:04:11 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BB44613BF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 02:04:06 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3BC0B52\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Oct 2020 02:04:06 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LKyiNEC5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603152246;\n\tbh=yCuiI6xeSNtaEoH7Adc0EyPxKhZS2xZjK+GYOovlXN0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=LKyiNEC5+hWzcDyssVVLc5oFF8y6gPqU/QoAlDfeUuyIdNO8mqfQlsgjxKCUX6eQE\n\tFFzWqq2vtLqtygphvTtVmAx9bsQpMW1MgoBbRKv1ewjduMr3r9kkVhi6Tl+y8sVjn3\n\tXNuwgqfjgFUjS+VYm/YxuKZPxZdfACuxBEpe9+GE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 20 Oct 2020 03:03:09 +0300", "Message-Id": "<20201020000310.3008-5-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>", "References": "<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 4/5] libcamera: Drop semicolon after\n\tLOG_{DECLARE, DEFINE}_CATEGORY", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "No semicolon is needed after the macro. Drop it in the few locations\nthat have one.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/byte_stream_buffer.cpp | 2 +-\n src/libcamera/camera_sensor.cpp | 2 +-\n src/libcamera/file.cpp | 2 +-\n src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n src/libcamera/pipeline/simple/converter.cpp | 2 +-\n src/libcamera/sysfs.cpp | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\nindex eb9003927266..7fc6f6944471 100644\n--- a/src/libcamera/byte_stream_buffer.cpp\n+++ b/src/libcamera/byte_stream_buffer.cpp\n@@ -19,7 +19,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(Serialization);\n+LOG_DEFINE_CATEGORY(Serialization)\n \n /**\n * \\class ByteStreamBuffer\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 78c7ceec7c44..935de528c496 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -28,7 +28,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(CameraSensor);\n+LOG_DEFINE_CATEGORY(CameraSensor)\n \n /**\n * \\struct CameraSensorInfo\ndiff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\nindex 04b0cb61a1bf..3a3f5bb63ffc 100644\n--- a/src/libcamera/file.cpp\n+++ b/src/libcamera/file.cpp\n@@ -23,7 +23,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(File);\n+LOG_DEFINE_CATEGORY(File)\n \n /**\n * \\class File\ndiff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\nindex 0572acc93d63..62605c0fceee 100644\n--- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n@@ -17,7 +17,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(RPI_S_W);\n+LOG_DEFINE_CATEGORY(RPI_S_W)\n \n namespace RPi {\n \ndiff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\nindex 75fb297ebd58..b4ee021f6210 100644\n--- a/src/libcamera/pipeline/simple/converter.cpp\n+++ b/src/libcamera/pipeline/simple/converter.cpp\n@@ -21,7 +21,7 @@\n \n namespace libcamera {\n \n-LOG_DECLARE_CATEGORY(SimplePipeline);\n+LOG_DECLARE_CATEGORY(SimplePipeline)\n \n SimpleConverter::SimpleConverter(MediaDevice *media)\n \t: m2m_(nullptr)\ndiff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\nindex 6c8e9554188d..3ebe66f8d69b 100644\n--- a/src/libcamera/sysfs.cpp\n+++ b/src/libcamera/sysfs.cpp\n@@ -22,7 +22,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(SysFs);\n+LOG_DEFINE_CATEGORY(SysFs)\n \n namespace sysfs {\n \n", "prefixes": [ "libcamera-devel", "4/5" ] }