Patch Detail
Show a patch.
GET /api/1.1/patches/10080/?format=api
{ "id": 10080, "url": "https://patchwork.libcamera.org/api/1.1/patches/10080/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10080/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201016090014.64703-4-kieran.bingham@ideasonboard.com>", "date": "2020-10-16T09:00:06", "name": "[libcamera-devel,v3,03/11] libcamera: thread: Prevent shadowing of signal name", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "90258bd9b6d3a00121e99239bc30ef0459f474f0", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10080/mbox/", "series": [ { "id": 1379, "url": "https://patchwork.libcamera.org/api/1.1/series/1379/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1379", "date": "2020-10-16T09:00:03", "name": "Shadowed Variables", "version": 3, "mbox": "https://patchwork.libcamera.org/series/1379/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10080/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10080/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5B057BDB1F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 16 Oct 2020 09:00:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0549610B6;\n\tFri, 16 Oct 2020 11:00:23 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D6C04610D0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 16 Oct 2020 11:00:19 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55795D5F;\n\tFri, 16 Oct 2020 11:00:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TeXPscbZ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602838819;\n\tbh=OtrTKmCaTvWBCtkRvw14X1FPLDeE3Sx+DMPQTrhPlqE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=TeXPscbZcjq60mLYUlT+JjZetWXHiEGs7WIVPfKOJ6CNYAdruwV4eKedve/JGQtQh\n\tLcIz2blZvB8TLfe1zsLuslfF8ySRl4QAlYDEItItsq51zS/v0vn6XppvEHRMyXBEGf\n\tCHl3G9zBK1euaP74ydGXv/Q0HuxT2gKoCB8uq+CE=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 16 Oct 2020 10:00:06 +0100", "Message-Id": "<20201016090014.64703-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201016090014.64703-1-kieran.bingham@ideasonboard.com>", "References": "<20201016090014.64703-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v3 03/11] libcamera: thread: Prevent\n\tshadowing of signal name", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The Thread::wait() function creates a boolean flag 'finished' which\nshadows the internal member signal of the same name.\n\nRename the boolean flag to prevent confusion and shadowing of the signal.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/thread.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/thread.cpp b/src/libcamera/thread.cpp\nindex 87006a9c4301..b5d7103ad341 100644\n--- a/src/libcamera/thread.cpp\n+++ b/src/libcamera/thread.cpp\n@@ -374,7 +374,7 @@ void Thread::exit(int code)\n */\n bool Thread::wait(utils::duration duration)\n {\n-\tbool finished = true;\n+\tbool hasFinished = true;\n \n \t{\n \t\tMutexLocker locker(data_->mutex_);\n@@ -382,14 +382,14 @@ bool Thread::wait(utils::duration duration)\n \t\tif (duration == utils::duration::max())\n \t\t\tdata_->cv_.wait(locker, [&]() { return !data_->running_; });\n \t\telse\n-\t\t\tfinished = data_->cv_.wait_for(locker, duration,\n-\t\t\t\t\t\t [&]() { return !data_->running_; });\n+\t\t\thasFinished = data_->cv_.wait_for(locker, duration,\n+\t\t\t\t\t\t\t [&]() { return !data_->running_; });\n \t}\n \n \tif (thread_.joinable())\n \t\tthread_.join();\n \n-\treturn finished;\n+\treturn hasFinished;\n }\n \n /**\n", "prefixes": [ "libcamera-devel", "v3", "03/11" ] }