Patch Detail
Show a patch.
GET /api/1.1/patches/10055/?format=api
{ "id": 10055, "url": "https://patchwork.libcamera.org/api/1.1/patches/10055/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10055/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201013151241.3557005-10-kieran.bingham@ideasonboard.com>", "date": "2020-10-13T15:12:40", "name": "[libcamera-devel,09/10] android: metadata: Prevent variable aliasing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "953fb787642e4370ca87bac66c6c46afe817be81", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10055/mbox/", "series": [ { "id": 1374, "url": "https://patchwork.libcamera.org/api/1.1/series/1374/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1374", "date": "2020-10-13T15:12:31", "name": "Shadowed Variables", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1374/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10055/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10055/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A43EBEEDF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Oct 2020 15:12:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE0446100A;\n\tTue, 13 Oct 2020 17:12:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 87EDC60E86\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Oct 2020 17:12:49 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 21E17192C;\n\tTue, 13 Oct 2020 17:12:49 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uAS/TJiY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602601969;\n\tbh=xsOYFh06ERxj69NBq90KyxIuHU/o74gNLK564ZJBcJ0=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=uAS/TJiYEsbYm8Ku1LbS3VEA/Yl7/KL7IaPgvh+72vRH1vKX27q0WhKHxT0YlzbWu\n\taQxxukx6vKRiELfj8ZAlgm9Pn4+V5GpjnT1yG5fVVZpN2xMYu9s8aECtrDSTnIOBOB\n\tRmNLctsSdROUkZbGT6Vz6bp0qaqwkwTueg95/TXQ=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 13 Oct 2020 16:12:40 +0100", "Message-Id": "<20201013151241.3557005-10-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>", "References": "<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 09/10] android: metadata: Prevent variable\n\taliasing", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The validate_camera_metadata_structure() call uses two instances of a\nvariable named aligned_ptr().\n\nReuse the first instance which is not otherwise re-used for the second\nscoped usage.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n*** This is in android metadata library code ***\n\nThis is only here as a temporary repair. Ideally we shouldn't make changes to this code base.\ndisabling the warning on this library component is likely a better choice.\n\n src/android/metadata/camera_metadata.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/metadata/camera_metadata.c b/src/android/metadata/camera_metadata.c\nindex b86586a7e685..129d1e92ece1 100644\n--- a/src/android/metadata/camera_metadata.c\n+++ b/src/android/metadata/camera_metadata.c\n@@ -433,7 +433,7 @@ int validate_camera_metadata_structure(const camera_metadata_t *metadata,\n };\n \n for (size_t i = 0; i < sizeof(alignments)/sizeof(alignments[0]); ++i) {\n- uintptr_t aligned_ptr = ALIGN_TO((uintptr_t) metadata + alignmentOffset,\n+ aligned_ptr = ALIGN_TO((uintptr_t) metadata + alignmentOffset,\n alignments[i].alignment);\n \n if ((uintptr_t)metadata + alignmentOffset != aligned_ptr) {\n", "prefixes": [ "libcamera-devel", "09/10" ] }