Patch Detail
Show a patch.
GET /api/1.1/patches/10052/?format=api
{ "id": 10052, "url": "https://patchwork.libcamera.org/api/1.1/patches/10052/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10052/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201013151241.3557005-7-kieran.bingham@ideasonboard.com>", "date": "2020-10-13T15:12:37", "name": "[libcamera-devel,06/10] libcamera: v4l2_videodevice: Prevent aliasing of V4L2BufferCache members", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0cacb3a806013e817dcdb4735e51ce83d591fe55", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10052/mbox/", "series": [ { "id": 1374, "url": "https://patchwork.libcamera.org/api/1.1/series/1374/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1374", "date": "2020-10-13T15:12:31", "name": "Shadowed Variables", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1374/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10052/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10052/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2EE7BEEDF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Oct 2020 15:12:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7E78C60E88;\n\tTue, 13 Oct 2020 17:12:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 872E460E80\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Oct 2020 17:12:48 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1F62D18B6;\n\tTue, 13 Oct 2020 17:12:48 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i+GIsCnj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1602601968;\n\tbh=ZZUwCfpXniT+0vCCWQbxSMtwFSjSo2vMgh7C34i63Kg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=i+GIsCnjQ3+2YjFZBOKh20tuVJQXMnee38V+MdH924UJIMvwcwllbCQL2ikDA0ef+\n\tELTvLPgcYasfHgLpRCW00g/a9iH1hTbzwOBA4zK9eBqAx/XCf34O2UnaV065va1ZcY\n\tBWKpxpWFDoELFwB+skHK1yG3dOZXwY5dygOs/G98=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 13 Oct 2020 16:12:37 +0100", "Message-Id": "<20201013151241.3557005-7-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>", "References": "<20201013151241.3557005-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 06/10] libcamera: v4l2_videodevice:\n\tPrevent aliasing of V4L2BufferCache members", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The members free, and lastUsed were not following the libcamera coding\nstyle, and were producing an aliased parameter on the construction.\n\nRename them to be marked as member variables with the _ postfix\naccordingly.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n include/libcamera/internal/v4l2_videodevice.h | 4 ++--\n src/libcamera/v4l2_videodevice.cpp | 14 +++++++-------\n 2 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/include/libcamera/internal/v4l2_videodevice.h b/include/libcamera/internal/v4l2_videodevice.h\nindex 40ed87e17cfa..53f6a2d5515b 100644\n--- a/include/libcamera/internal/v4l2_videodevice.h\n+++ b/include/libcamera/internal/v4l2_videodevice.h\n@@ -127,8 +127,8 @@ private:\n \n \t\tbool operator==(const FrameBuffer &buffer) const;\n \n-\t\tbool free;\n-\t\tuint64_t lastUsed;\n+\t\tbool free_;\n+\t\tuint64_t lastUsed_;\n \n \tprivate:\n \t\tstruct Plane {\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 508522ef42bb..96952b26c634 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -212,7 +212,7 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n \tfor (unsigned int index = 0; index < cache_.size(); index++) {\n \t\tconst Entry &entry = cache_[index];\n \n-\t\tif (!entry.free)\n+\t\tif (!entry.free_)\n \t\t\tcontinue;\n \n \t\t/* Try to find a cache hit by comparing the planes. */\n@@ -222,9 +222,9 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n \t\t\tbreak;\n \t\t}\n \n-\t\tif (entry.lastUsed < oldest) {\n+\t\tif (entry.lastUsed_ < oldest) {\n \t\t\tuse = index;\n-\t\t\toldest = entry.lastUsed;\n+\t\t\toldest = entry.lastUsed_;\n \t\t}\n \t}\n \n@@ -248,16 +248,16 @@ int V4L2BufferCache::get(const FrameBuffer &buffer)\n void V4L2BufferCache::put(unsigned int index)\n {\n \tASSERT(index < cache_.size());\n-\tcache_[index].free = true;\n+\tcache_[index].free_ = true;\n }\n \n V4L2BufferCache::Entry::Entry()\n-\t: free(true), lastUsed(0)\n+\t: free_(true), lastUsed_(0)\n {\n }\n \n-V4L2BufferCache::Entry::Entry(bool free, uint64_t lastUsed, const FrameBuffer &buffer)\n-\t: free(free), lastUsed(lastUsed)\n+V4L2BufferCache::Entry::Entry(bool free, uint64_t age, const FrameBuffer &buffer)\n+\t: free_(free), lastUsed_(age)\n {\n \tfor (const FrameBuffer::Plane &plane : buffer.planes())\n \t\tplanes_.emplace_back(plane);\n", "prefixes": [ "libcamera-devel", "06/10" ] }