Patch Detail
Show a patch.
GET /api/1.1/patches/10010/?format=api
{ "id": 10010, "url": "https://patchwork.libcamera.org/api/1.1/patches/10010/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10010/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201007110743.55561-5-tomi.valkeinen@iki.fi>", "date": "2020-10-07T11:07:43", "name": "[libcamera-devel,4/4] ipa: raspberrypi: fix use of uninitialized fields", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "09df1a037898ea4471a73d5e3054d1d7533883e1", "submitter": { "id": 70, "url": "https://patchwork.libcamera.org/api/1.1/people/70/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@iki.fi" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10010/mbox/", "series": [ { "id": 1362, "url": "https://patchwork.libcamera.org/api/1.1/series/1362/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1362", "date": "2020-10-07T11:07:39", "name": "ipa: raspberrypi: fix uninit variables", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1362/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10010/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10010/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6332BEEE1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Oct 2020 11:08:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 73D1F605AF;\n\tWed, 7 Oct 2020 13:08:10 +0200 (CEST)", "from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com\n\t[IPv6:2a00:1450:4864:20::22f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83E6F60455\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Oct 2020 13:08:08 +0200 (CEST)", "by mail-lj1-x22f.google.com with SMTP id a5so1522292ljj.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 07 Oct 2020 04:08:08 -0700 (PDT)", "from deskari.lan (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tx14sm287445lfc.93.2020.10.07.04.08.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Oct 2020 04:08:07 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"o8fBkDrF\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=nzYDU2E0TJa+hObRpA9YU7WnAsBv5mGDCt8vxp3W3hk=;\n\tb=o8fBkDrFnbk+CCVOetv4TbItez7CRn3f3EfrI/3VDQA2HhWymHRALOfUAPgwAoA5UF\n\tnmICmgPxXzOLxnQzQP73AgM/sHC43+tvfx6gq27h79OXPwL1l3XoNZnHwrUBOExOilPv\n\t4qDibCBs5+BF+p1uVroaB8nwXABbPqewDOfU7lNm+6S0tiCQcUsbzrXvTHoFzuvsJbUY\n\tEC3oq9qAwYOXJ9JEf1rvVAPBdFnPWZb4blAH/11W7O71JaR7WTGKJTRD4JKYKrxcOk4y\n\t+JmVecBGnLSoxbWv/3cQOb6zhY0zyarwoloCS2NJGNZ+boPH5jnu/ItxPr+IYCJqNPog\n\tqqnw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=nzYDU2E0TJa+hObRpA9YU7WnAsBv5mGDCt8vxp3W3hk=;\n\tb=AnPYrx2fqpO5LDNbv63S0BBdKZbj54kjPCc45GTwM2DsQWvwvcVNjlydnbEM0x4BQh\n\t/MhcSWgH5g0WitYGwO29xqkSZ2X8ZnMBtRvtqYKHvafwhYhLDP5TO4+C2CtMXDPjF6zv\n\tF5lwMlszp/C+ApfJ0DsQsdD9CFyUhX9l8yNAf1wL/5RlvFgrgt5HoOQVHBNvQMRQhSXc\n\t+f9/bKhq+PYPW3u2sDrTU3AzHtqbILChqLZCOn+nGJR5FzsxhbWZzTnxEQFr2kez57bW\n\t7++wREeXtAJTd1GeJpiIUS7KiVLrzq4U8RsfRYH3QOJtDrh9bDG1hlIPtrcrAP7MIRRg\n\tmUFw==", "X-Gm-Message-State": "AOAM531jksOA5ImI3dF3KJDDPVXf61HP3bO8mS1RCktShQ9vRZr1/lg4\n\tIKkKkeFhae1bnG0S0lPHIVLB7i3x0enUrg==", "X-Google-Smtp-Source": "ABdhPJx/dKkCA1N42JgirGHiXUYshexlPAs68u9C2RB7uMPdKWybtyiVrIjnhETebhNlD+M4/sM9mg==", "X-Received": "by 2002:a2e:50a:: with SMTP id 10mr925166ljf.55.1602068887834;\n\tWed, 07 Oct 2020 04:08:07 -0700 (PDT)", "From": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "To": "libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>", "Date": "Wed, 7 Oct 2020 14:07:43 +0300", "Message-Id": "<20201007110743.55561-5-tomi.valkeinen@iki.fi>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201007110743.55561-1-tomi.valkeinen@iki.fi>", "References": "<20201007110743.55561-1-tomi.valkeinen@iki.fi>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 4/4] ipa: raspberrypi: fix use of\n\tuninitialized fields", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "These fields are not initialized, but are used. Set them to 0.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@iki.fi>\n---\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp\nindex ba7ae09..23374d5 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n@@ -116,9 +116,9 @@ private:\n \tstd::string exposure_mode_name_;\n \tstd::string constraint_mode_name_;\n \tdouble ev_;\n-\tdouble flicker_period_;\n-\tdouble fixed_shutter_;\n-\tdouble fixed_analogue_gain_;\n+\tdouble flicker_period_ = 0;\n+\tdouble fixed_shutter_ = 0;\n+\tdouble fixed_analogue_gain_ = 0;\n };\n \n } // namespace RPiController\n", "prefixes": [ "libcamera-devel", "4/4" ] }