Patch Detail
Show a patch.
GET /api/1.1/patches/10008/?format=api
{ "id": 10008, "url": "https://patchwork.libcamera.org/api/1.1/patches/10008/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10008/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201007110743.55561-3-tomi.valkeinen@iki.fi>", "date": "2020-10-07T11:07:41", "name": "[libcamera-devel,2/4] ipa: raspberrypi: fix missing initialize of status_", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "216e0d29c8694f2489601d3dcf38611f6d3a2e2f", "submitter": { "id": 70, "url": "https://patchwork.libcamera.org/api/1.1/people/70/?format=api", "name": "Tomi Valkeinen", "email": "tomi.valkeinen@iki.fi" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10008/mbox/", "series": [ { "id": 1362, "url": "https://patchwork.libcamera.org/api/1.1/series/1362/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1362", "date": "2020-10-07T11:07:39", "name": "ipa: raspberrypi: fix uninit variables", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1362/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10008/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10008/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C09BBEEE0\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 Oct 2020 11:08:08 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAF2A605A9;\n\tWed, 7 Oct 2020 13:08:07 +0200 (CEST)", "from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com\n\t[IPv6:2a00:1450:4864:20::22e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD00860455\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 Oct 2020 13:08:06 +0200 (CEST)", "by mail-lj1-x22e.google.com with SMTP id a5so1522192ljj.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 07 Oct 2020 04:08:06 -0700 (PDT)", "from deskari.lan (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tx14sm287445lfc.93.2020.10.07.04.08.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Oct 2020 04:08:05 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Cp9UtNQq\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=2dKW7thoNLoTpb7x6D3yM/3mYoNj7JwgroKaLWUq1Kc=;\n\tb=Cp9UtNQqKwm+bOojsC73cPIyPK9+lTD+qfctP+FYHmdTdWAXshb9JVhAmuHRCa2ssP\n\tQewt0ik7jZq7X3ROYpC6j/ST1RqCaw0ZtkyJsk/+GCCSZjJLJnnIXlV7QgWQnNF+Fy6x\n\tusZYLuU/M/L1zYjOlbbIvTuwOQncPtyKorRiQYFOa/C0mZ1IvkCdoVQZpfVWULzyYvpE\n\t4nD2tp/rUvFJbR/SgSs+GwiMKoYLVUeLjpYVDqak9k8ch84mP3b++v7YbLFpb+h8euwP\n\t4qG63D1pf576bXFHXeOxKuPnOJzYpEmrFdNneWoEEEwG8NxjEAEy/qpwe1xHnzr7Vl13\n\tf87w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=2dKW7thoNLoTpb7x6D3yM/3mYoNj7JwgroKaLWUq1Kc=;\n\tb=qtyyYT9VnYiX+wDYy6k8NW4pjRobvpTsGucwCOjYaDkFeoWXSz615Hjh2J+jUYDRC3\n\tRvOEdRhC6mf3udBbMb63mw2zTcgHh6tVqEQtQdu7N90rFpUEjWhnIVbDvBJTQua29aCd\n\tkApyEWToAfg1FkcpcoRaItt3qRU1iwZaQ9KLy4q1w69D6HHfjvpJ65YIgSs1FszI4C93\n\tnhXQiDU10lurg0Cdelw2xzuck5+dfAICPcwown7UxyCk9SqKQKlMmwIUNrB236PPBs1h\n\tnFmZc4ut94+ktwE8/OZ6Rwmu206ki/ESQd1rk694blmhgWeIQN/hZ/lo7GOHvOuHUUn3\n\tGaAg==", "X-Gm-Message-State": "AOAM530YFJFOB1+Ma1ob08TihwB1TG+lCwT/fxx6oUQNbiBaaN4od9Ad\n\t8iQe/JfJKcUQLqsocDL4sF6TDog00DQCSQ==", "X-Google-Smtp-Source": "ABdhPJyqwGN9gUXSuAsjuT13XfhukuKqbbjuWzyn5PW1o0z3TzKTb2LWHLOf8rtB0uPetAss3YQSdw==", "X-Received": "by 2002:a2e:b6cf:: with SMTP id m15mr782283ljo.74.1602068886106; \n\tWed, 07 Oct 2020 04:08:06 -0700 (PDT)", "From": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "To": "libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck <naush@raspberrypi.com>,\n\tDavid Plowman <david.plowman@raspberrypi.com>", "Date": "Wed, 7 Oct 2020 14:07:41 +0300", "Message-Id": "<20201007110743.55561-3-tomi.valkeinen@iki.fi>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20201007110743.55561-1-tomi.valkeinen@iki.fi>", "References": "<20201007110743.55561-1-tomi.valkeinen@iki.fi>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 2/4] ipa: raspberrypi: fix missing\n\tinitialize of status_", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Tomi Valkeinen <tomi.valkeinen@iki.fi>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Many fields in status_ are not initialized, causing use of uninitialized\nmemory.\n\nDrop the code that clears some of the individual fields, and instead\njust memset the whole thing.\n\nSigned-off-by: Tomi Valkeinen <tomi.valkeinen@iki.fi>\n---\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 +-------\n 1 file changed, 1 insertion(+), 7 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex df4d364..9e75178 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -148,14 +148,8 @@ Agc::Agc(Controller *controller)\n \t exposure_mode_(nullptr), constraint_mode_(nullptr),\n \t frame_count_(0), lock_count_(0)\n {\n+\tmemset(&status_, 0, sizeof(status_));\n \tev_ = status_.ev = 1.0;\n-\tflicker_period_ = status_.flicker_period = 0.0;\n-\tfixed_shutter_ = status_.fixed_shutter = 0;\n-\tfixed_analogue_gain_ = status_.fixed_analogue_gain = 0.0;\n-\t// set to zero initially, so we can tell it's not been calculated\n-\tstatus_.total_exposure_value = 0.0;\n-\tstatus_.target_exposure_value = 0.0;\n-\tstatus_.locked = false;\n \toutput_status_ = status_;\n }\n \n", "prefixes": [ "libcamera-devel", "2/4" ] }