Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/715/?format=api
{ "id": 715, "url": "https://patchwork.libcamera.org/api/1.1/covers/715/?format=api", "web_url": "https://patchwork.libcamera.org/cover/715/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190312121242.2253-1-jacopo@jmondi.org>", "date": "2019-03-12T12:12:28", "name": "[libcamera-devel,v2,00/14] libcamera: ipu3: ImgU support", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/715/mbox/", "series": [ { "id": 205, "url": "https://patchwork.libcamera.org/api/1.1/series/205/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=205", "date": "2019-03-12T12:12:28", "name": "libcamera: ipu3: ImgU support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/205/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/715/comments/", "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 971E5600FC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 12 Mar 2019 13:12:19 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 0DC461C000A;\n\tTue, 12 Mar 2019 12:12:18 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 12 Mar 2019 13:12:28 +0100", "Message-Id": "<20190312121242.2253-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 00/14] libcamera: ipu3: ImgU support", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 12 Mar 2019 12:12:19 -0000" }, "content": "Hello,\n v2 of ImgU support series for Intel IPU3 devices.\n\nRebased on top of recent master, which includes Laurent's rework of request\ncompletion handling, which removes a few hacks compared to v1.\n\nI have included review comments on patchs 3-11 which now look nicer.\nPatches 1 and 2 adds a few updates to v4l2-subdevice to get a string\nrepresentation of a format and shorten the image format enumeration type name.\n\nThe less-nice part are patches 13 and 14.\n\nThe first one limits the default output resolution to 2560x1920, as the\nmaximum resolutions reported by image sensors installed on Soraka are not\nprocessed correctly by the ImgU device. There might be some issue to be\nclarified regarding alignement and scaling constraints. Resolutions up to\n2560x1920 have been verified successfully.\n\n14/14 enable links on the ImgU instance, which is more tricky then expected.\nLinks enable on one instance interfere with capture operations of the other one,\nand thus links should be disabled when the ImgU is not in use. Unfortunately,\nI'm struggling to find what the right place to do so would be, and for now I\nsimply disable all links in the ImgU media graph at streamConfiguration time.\n\nI have confirmed that viewfinder and stat output have to be linked and queued\nwith buffers to have the main output video device produce frames. I have tried\nremoving linking, configuration and buffer queueing of the two (singularly and\ntogether) and what I get is the capture application to freeze uninterruptedly\nwithout any frame being produced on the ImgU main output. If this behaviour is\nintended or not should probably be clarified with IPU3 driver developers.\n\nTested on Soraka, inspecting images at various resolutions (1920x1080,\n2560x1920, 640x480) from both front and back camera.\n\nThanks\n j\n\nJacopo Mondi (14):\n libcamera: formats: Add toString() methods\n libcamera: v4l2_subdevice: Define format enumeration type\n libcamera: ipu3: Get default image sizes from sensor\n libcamera: ipu3: Initialize and configure CIO2\n libcamera: ipu3: Initialize and configure ImgUs\n libcamera: ipu3: Propagate image format\n libcamera: ipu3: Implement camera start/stop\n libcamera: ipu3: Implement buffer allocation\n libcamera: ipu3: Implement buffer release\n libcamera: ipu3: Queue requests to the pipeline\n libcamera: ipu3: Connect CIO2 and ImgU bufferReady signals\n libcamera: ipu3: Use NV12 as default image format\n HACK: Soraka: Limit resolution to 2560x1920\n RFC: libcamera: ipu3: Enable ImgU media links\n\n src/libcamera/include/v4l2_device.h | 2 +\n src/libcamera/include/v4l2_subdevice.h | 7 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 1093 ++++++++++++++++++++----\n src/libcamera/v4l2_device.cpp | 18 +\n src/libcamera/v4l2_subdevice.cpp | 32 +-\n 5 files changed, 978 insertions(+), 174 deletions(-)\n\n--\n2.20.1" }