Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/26440/?format=api
{ "id": 26440, "url": "https://patchwork.libcamera.org/api/1.1/covers/26440/?format=api", "web_url": "https://patchwork.libcamera.org/cover/26440/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "date": "2026-04-07T15:33:45", "name": "[v2,00/42] libcamera: Global configuration file improvements", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/26440/mbox/", "series": [ { "id": 5873, "url": "https://patchwork.libcamera.org/api/1.1/series/5873/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5873", "date": "2026-04-07T15:33:45", "name": "libcamera: Global configuration file improvements", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5873/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/26440/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7D038BDCBD\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 7 Apr 2026 15:34:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 33A8D62D9D;\n\tTue, 7 Apr 2026 17:34:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF4F662846\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:34:28 +0200 (CEST)", "from killaraus.ideasonboard.com\n\t(2001-14ba-703d-e500--2a1.rev.dnainternet.fi\n\t[IPv6:2001:14ba:703d:e500::2a1])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 33DCE6A6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 7 Apr 2026 17:33:01 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JypwdUkz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1775575981;\n\tbh=stGW7oAk6+tPJJPW8R9QxIMI9dA+U4Hm0SKDnBlq3nk=;\n\th=From:To:Subject:Date:From;\n\tb=JypwdUkzXJQO0m7KfpAK2wzobCmKOmZEqMnvrdKvL//tflXUPQBm6/WOBWrCmYUx5\n\tAqHOM01wRr/b5RcQ4EnzlcNZDJSxrJ+TmnUc6JrnV9ndlwYkGPlTVlWdXt1UcbHanh\n\tzw8YDcxfZo5Hge8nzB/gqY/MQWmMFvszyPSvMP6s=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 00/42] libcamera: Global configuration file improvements", "Date": "Tue, 7 Apr 2026 18:33:45 +0300", "Message-ID": "<20260407153427.1825999-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis series started small with a few improvements to the global\nconfiguration file handling, fixing some issues I pointed out during\nreviews. It then grew over time, and while I have ideas for more\nimprovements, adding more patches will only slow down review.\n\nThe series starts with a few drive-by cleanups in patches 01/42 to\n07/42. Those could be merged separately, but some of them would then end\nup conflicting with the rest of the series, so I've included them here.\n\nThe rework of the configuration file starts in patch 08/42 with\nimprovements to the YamlParser and YamlObject classes, until patch 19/42\nthat renames YamlObject to ValueNode to make the class usable outside of\nYAML parsing use cases. Patches 20/42 to 26/42 continues with extensions\nto the ValueNode class with new functions that are used by subsequent\npatches. The next four patches finishes the ValueNode rework with unit\ntests for the new class in 27/42, and simplification of the YamlParser\nunit tests in 28/42 to 30/42.\n\nAfter that, the focus shifs to the global configuration. Patches 31/42\nto 36/42 rework the GlobalConfiguration class, with the most notable\nchange in 31/42 that passes a CameraManager around to access the\nGlobalConfiguration. Patches 37/42 and 38/42 continue with centralizing\nconfiguration override through environment variables. This simplifies\nusage of the GlobalConfiguration class through libcamera, at the cost of\nsplitting information about environment variables from the place where\nthe corresponding configuration setting is used. I believe this is an\nacceptable drawback, as now that we have a configuration file, new\nenvironment variables should be introduced very seldom. An alternative\nthat I may explore at some point is an API that would allow components\nwithin libcamera to declare the options they support, in which case\nenvironment variables would be declared using the same API. This will be\na bigger rework that I don't plan to explore for the time being.\n\nPatch 39/42 is a small documentation improvement, before the last three\npatches that break backward compatibility. They are conceptually\nindependent from each other, 42/42 currently depends on 41/42, but it\ncould be rebased if 41/42 is deemed undesirable.\n\nOn top of this series I would like to extend the CameraManager class to\nsupport overridding options, allowing applications to configure\nlibcamera programmatically. This could take the form of a ValueNode.\nAnother possible improvement would be to restructure the configuration\nfile to provide per-camera configuration in addition to per-pipeline\nhandler options. If anyone is interested in giving this a try, let's\ndiscuss it.\n\n\nLaurent Pinchart (42):\n libcamera: Drop unneeded usage of this pointer\n libcamera: request: Move all private member variables to Private class\n libcamera: Replace plain pointers with std::unique<>\n libcamera: pipeline_handler: Add createIPA() function\n test: ipa: ipa_interface: Use IPAManager::createIPA()\n test: ipa: ipa_interface: Replace FIFO with pipe\n libcamera: camera_manager: Move IPAManager creation to start() time\n libcamera: yaml_parser: Use std::make_unique<>\n libcamera: yaml_parser: Rename Container to ValueContainer\n libcamera: yaml_parser: Rename Getter to Accessor\n libcamera: yaml_parser: Replace getList() with get() specializations\n libcamera: yaml_parser: Add function to set a YamlObject value\n libcamera: yaml_parser: Add functions to add children\n libcamera: yaml_parser: Un-friend YamlParserContext from YamlObject\n libcamera: yaml_parser: Move Size handling to geometry.cpp\n libcamera: yaml_parser: Drop unneeded \\fn Doxygen commands\n libcamera: yaml_parser: Split YamlObject from YamlParser\n libcamera: yaml_object: Miscellaneous documentation improvements\n libcamera: Rename YamlObject to ValueNode\n libcamera: value_node: Add constructor with value\n libcamera: value_node: Rework templates to prepare for mutable views\n libcamera: value_node: Add mutable adapters\n libcamera: value_node: Add mutable children accessors\n libcamera: value_node: Support adding nested children in one operation\n libcamera: value_node: Support looking up descendant node by path\n libcamera: value_node: Add functions to erase child nodes\n test: Add ValueNode unit test\n test: yaml-parser: Simplify test\n test: yaml-parser: Standardize on explicitly qualifying std namespace\n test: yaml-parser: Replace \"object\" with \"node\"\n libcamera: Pass CameraManager around instead of GlobalConfiguration\n libcamera: global_configuration: Reorder functions\n libcamera: global_configuration: Add missing include and comment\n libcamera: global_configuration: Rename yamlConfiguration_\n libcamera: global_configuration: Rename Configuration to Option\n libcamera: global_configuration: Drop Option type\n libcamera: global_configuration: Populate empty configuration\n libcamera: global_configuration: Override options with environment\n variables\n Documentation: Rename runtime configuration title\n libcamera: software_isp: Rename \"measure\" option to \"benchmark\"\n pipeline: simple: Rename supported_devices configuration option to\n devices\n pipeline: simple: Turn devices configuration option into dictionary\n\n .../guides/application-developer.rst | 5 +-\n Documentation/guides/ipa.rst | 8 +-\n Documentation/runtime_configuration.rst | 24 +-\n .../internal/converter/converter_dw100.h | 2 +-\n .../internal/device_enumerator_udev.h | 2 +-\n .../libcamera/internal/global_configuration.h | 22 +-\n include/libcamera/internal/ipa_manager.h | 29 +-\n include/libcamera/internal/ipa_proxy.h | 4 +-\n include/libcamera/internal/ipc_unixsocket.h | 3 +-\n include/libcamera/internal/matrix.h | 10 +-\n include/libcamera/internal/meson.build | 1 +\n include/libcamera/internal/pipeline_handler.h | 11 +-\n include/libcamera/internal/request.h | 12 +-\n .../libcamera/internal/shared_mem_object.h | 4 +-\n .../internal/software_isp/benchmark.h | 6 +-\n .../internal/software_isp/swstats_cpu.h | 6 +-\n include/libcamera/internal/v4l2_device.h | 2 +-\n include/libcamera/internal/v4l2_videodevice.h | 12 +-\n include/libcamera/internal/value_node.h | 276 +++++++\n include/libcamera/internal/vector.h | 10 +-\n include/libcamera/internal/yaml_parser.h | 227 +-----\n include/libcamera/ipa/vimc.mojom | 3 +-\n include/libcamera/request.h | 15 +-\n src/android/camera_hal_config.cpp | 16 +-\n src/apps/qcam/main.cpp | 5 +-\n src/apps/qcam/main_window.cpp | 11 +-\n src/apps/qcam/main_window.h | 2 +-\n src/ipa/ipu3/algorithms/agc.cpp | 4 +-\n src/ipa/ipu3/algorithms/agc.h | 2 +-\n src/ipa/ipu3/ipu3.cpp | 2 +-\n src/ipa/libipa/agc_mean_luminance.cpp | 20 +-\n src/ipa/libipa/agc_mean_luminance.h | 12 +-\n src/ipa/libipa/algorithm.cpp | 2 +-\n src/ipa/libipa/algorithm.h | 4 +-\n src/ipa/libipa/awb.cpp | 6 +-\n src/ipa/libipa/awb.h | 6 +-\n src/ipa/libipa/awb_bayes.cpp | 8 +-\n src/ipa/libipa/awb_bayes.h | 6 +-\n src/ipa/libipa/awb_grey.cpp | 2 +-\n src/ipa/libipa/awb_grey.h | 2 +-\n src/ipa/libipa/interpolator.cpp | 2 +-\n src/ipa/libipa/interpolator.h | 4 +-\n src/ipa/libipa/lsc_polynomial.h | 8 +-\n src/ipa/libipa/lux.cpp | 6 +-\n src/ipa/libipa/lux.h | 4 +-\n src/ipa/libipa/module.cpp | 2 +-\n src/ipa/libipa/module.h | 6 +-\n src/ipa/libipa/pwl.cpp | 2 +-\n src/ipa/mali-c55/algorithms/agc.cpp | 2 +-\n src/ipa/mali-c55/algorithms/agc.h | 2 +-\n src/ipa/mali-c55/algorithms/blc.cpp | 4 +-\n src/ipa/mali-c55/algorithms/blc.h | 2 +-\n src/ipa/mali-c55/algorithms/lsc.cpp | 12 +-\n src/ipa/mali-c55/algorithms/lsc.h | 2 +-\n src/ipa/mali-c55/mali-c55.cpp | 2 +-\n src/ipa/rkisp1/algorithms/agc.cpp | 12 +-\n src/ipa/rkisp1/algorithms/agc.h | 4 +-\n src/ipa/rkisp1/algorithms/awb.cpp | 2 +-\n src/ipa/rkisp1/algorithms/awb.h | 2 +-\n src/ipa/rkisp1/algorithms/blc.cpp | 4 +-\n src/ipa/rkisp1/algorithms/blc.h | 2 +-\n src/ipa/rkisp1/algorithms/ccm.cpp | 4 +-\n src/ipa/rkisp1/algorithms/ccm.h | 4 +-\n src/ipa/rkisp1/algorithms/cproc.cpp | 2 +-\n src/ipa/rkisp1/algorithms/cproc.h | 2 +-\n src/ipa/rkisp1/algorithms/dpcc.cpp | 22 +-\n src/ipa/rkisp1/algorithms/dpcc.h | 2 +-\n src/ipa/rkisp1/algorithms/dpf.cpp | 14 +-\n src/ipa/rkisp1/algorithms/dpf.h | 2 +-\n src/ipa/rkisp1/algorithms/filter.cpp | 2 +-\n src/ipa/rkisp1/algorithms/filter.h | 2 +-\n src/ipa/rkisp1/algorithms/goc.cpp | 4 +-\n src/ipa/rkisp1/algorithms/goc.h | 2 +-\n src/ipa/rkisp1/algorithms/gsl.cpp | 14 +-\n src/ipa/rkisp1/algorithms/gsl.h | 2 +-\n src/ipa/rkisp1/algorithms/lsc.cpp | 24 +-\n src/ipa/rkisp1/algorithms/lsc.h | 2 +-\n src/ipa/rkisp1/algorithms/lux.cpp | 2 +-\n src/ipa/rkisp1/algorithms/lux.h | 2 +-\n src/ipa/rkisp1/algorithms/wdr.cpp | 4 +-\n src/ipa/rkisp1/algorithms/wdr.h | 2 +-\n src/ipa/rkisp1/rkisp1.cpp | 2 +-\n src/ipa/rpi/controller/algorithm.cpp | 2 +-\n src/ipa/rpi/controller/algorithm.h | 4 +-\n src/ipa/rpi/controller/controller.cpp | 4 +-\n src/ipa/rpi/controller/controller.h | 4 +-\n src/ipa/rpi/controller/rpi/af.cpp | 10 +-\n src/ipa/rpi/controller/rpi/af.h | 8 +-\n src/ipa/rpi/controller/rpi/agc.cpp | 2 +-\n src/ipa/rpi/controller/rpi/agc.h | 2 +-\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 28 +-\n src/ipa/rpi/controller/rpi/agc_channel.h | 12 +-\n src/ipa/rpi/controller/rpi/alsc.cpp | 10 +-\n src/ipa/rpi/controller/rpi/alsc.h | 2 +-\n src/ipa/rpi/controller/rpi/awb.cpp | 6 +-\n src/ipa/rpi/controller/rpi/awb.h | 4 +-\n src/ipa/rpi/controller/rpi/awb_bayes.cpp | 12 +-\n src/ipa/rpi/controller/rpi/black_level.cpp | 2 +-\n src/ipa/rpi/controller/rpi/black_level.h | 2 +-\n src/ipa/rpi/controller/rpi/cac.cpp | 4 +-\n src/ipa/rpi/controller/rpi/cac.h | 2 +-\n src/ipa/rpi/controller/rpi/ccm.cpp | 2 +-\n src/ipa/rpi/controller/rpi/ccm.h | 2 +-\n src/ipa/rpi/controller/rpi/contrast.cpp | 2 +-\n src/ipa/rpi/controller/rpi/contrast.h | 2 +-\n src/ipa/rpi/controller/rpi/decompand.cpp | 2 +-\n src/ipa/rpi/controller/rpi/decompand.h | 2 +-\n src/ipa/rpi/controller/rpi/denoise.cpp | 4 +-\n src/ipa/rpi/controller/rpi/denoise.h | 4 +-\n src/ipa/rpi/controller/rpi/dpc.cpp | 2 +-\n src/ipa/rpi/controller/rpi/dpc.h | 2 +-\n src/ipa/rpi/controller/rpi/geq.cpp | 2 +-\n src/ipa/rpi/controller/rpi/geq.h | 2 +-\n src/ipa/rpi/controller/rpi/hdr.cpp | 12 +-\n src/ipa/rpi/controller/rpi/hdr.h | 4 +-\n src/ipa/rpi/controller/rpi/lux.cpp | 2 +-\n src/ipa/rpi/controller/rpi/lux.h | 2 +-\n src/ipa/rpi/controller/rpi/noise.cpp | 2 +-\n src/ipa/rpi/controller/rpi/noise.h | 2 +-\n src/ipa/rpi/controller/rpi/saturation.cpp | 2 +-\n src/ipa/rpi/controller/rpi/saturation.h | 2 +-\n src/ipa/rpi/controller/rpi/sdn.cpp | 2 +-\n src/ipa/rpi/controller/rpi/sdn.h | 2 +-\n src/ipa/rpi/controller/rpi/sharpen.cpp | 2 +-\n src/ipa/rpi/controller/rpi/sharpen.h | 2 +-\n src/ipa/rpi/controller/rpi/tonemap.cpp | 2 +-\n src/ipa/rpi/controller/rpi/tonemap.h | 2 +-\n src/ipa/simple/algorithms/adjust.cpp | 2 +-\n src/ipa/simple/algorithms/adjust.h | 2 +-\n src/ipa/simple/algorithms/blc.cpp | 2 +-\n src/ipa/simple/algorithms/blc.h | 2 +-\n src/ipa/simple/algorithms/ccm.cpp | 2 +-\n src/ipa/simple/algorithms/ccm.h | 2 +-\n src/ipa/simple/soft_simple.cpp | 2 +-\n src/ipa/vimc/vimc.cpp | 33 +-\n src/libcamera/camera_manager.cpp | 8 +-\n src/libcamera/converter/converter_dw100.cpp | 4 +-\n src/libcamera/device_enumerator_udev.cpp | 6 +-\n src/libcamera/geometry.cpp | 29 +\n src/libcamera/global_configuration.cpp | 319 +++++----\n src/libcamera/ipa_manager.cpp | 15 +-\n src/libcamera/ipa_proxy.cpp | 14 +-\n src/libcamera/ipc_unixsocket.cpp | 7 +-\n src/libcamera/matrix.cpp | 2 +-\n src/libcamera/meson.build | 1 +\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +-\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 3 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +-\n .../pipeline/rpi/common/pipeline_base.cpp | 8 +-\n .../pipeline/rpi/common/pipeline_base.h | 4 +-\n src/libcamera/pipeline/rpi/pisp/pisp.cpp | 6 +-\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 6 +-\n src/libcamera/pipeline/simple/simple.cpp | 21 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 5 +-\n src/libcamera/pipeline/virtual/README.md | 2 +-\n .../pipeline/virtual/config_parser.cpp | 20 +-\n .../pipeline/virtual/config_parser.h | 12 +-\n src/libcamera/pipeline/virtual/virtual.cpp | 2 +-\n src/libcamera/pipeline_handler.cpp | 10 +\n src/libcamera/request.cpp | 104 +--\n src/libcamera/shared_mem_object.cpp | 8 +-\n src/libcamera/software_isp/benchmark.cpp | 17 +-\n src/libcamera/software_isp/debayer.cpp | 14 +-\n src/libcamera/software_isp/debayer.h | 4 +-\n src/libcamera/software_isp/debayer_cpu.cpp | 7 +-\n src/libcamera/software_isp/debayer_cpu.h | 4 +-\n src/libcamera/software_isp/debayer_egl.cpp | 7 +-\n src/libcamera/software_isp/debayer_egl.h | 4 +-\n src/libcamera/software_isp/software_isp.cpp | 16 +-\n src/libcamera/software_isp/swstats_cpu.cpp | 8 +-\n src/libcamera/v4l2_device.cpp | 5 +-\n src/libcamera/v4l2_videodevice.cpp | 22 +-\n src/libcamera/value_node.cpp | 675 ++++++++++++++++++\n src/libcamera/vector.cpp | 2 +-\n src/libcamera/yaml_parser.cpp | 482 ++-----------\n src/v4l2/v4l2_camera.cpp | 7 +-\n src/v4l2/v4l2_camera.h | 2 +-\n src/v4l2/v4l2_compat_manager.cpp | 18 +-\n src/v4l2/v4l2_compat_manager.h | 2 +-\n test/ipa/ipa_interface_test.cpp | 57 +-\n test/meson.build | 1 +\n test/value-node.cpp | 565 +++++++++++++++\n test/yaml-parser.cpp | 522 ++------------\n .../module_ipa_proxy.cpp.tmpl | 8 +-\n .../module_ipa_proxy.h.tmpl | 4 +-\n 185 files changed, 2465 insertions(+), 1853 deletions(-)\n create mode 100644 include/libcamera/internal/value_node.h\n create mode 100644 src/libcamera/value_node.cpp\n create mode 100644 test/value-node.cpp\n\n\nbase-commit: 4b6c47bd6675c428c19ea76370f0301c24f23bf1" }