Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/26243/?format=api
{ "id": 26243, "url": "https://patchwork.libcamera.org/api/1.1/covers/26243/?format=api", "web_url": "https://patchwork.libcamera.org/cover/26243/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260303111741.17417-1-johannes.goede@oss.qualcomm.com>", "date": "2026-03-03T11:17:37", "name": "[v4,0/4] software_isp: debayer_cpu: Add multi-threading support", "submitter": { "id": 242, "url": "https://patchwork.libcamera.org/api/1.1/people/242/?format=api", "name": "Hans de Goede", "email": "johannes.goede@oss.qualcomm.com" }, "mbox": "https://patchwork.libcamera.org/cover/26243/mbox/", "series": [ { "id": 5816, "url": "https://patchwork.libcamera.org/api/1.1/series/5816/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5816", "date": "2026-03-03T11:17:37", "name": "software_isp: debayer_cpu: Add multi-threading support", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5816/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/26243/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A45E6C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 3 Mar 2026 11:17:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 851EC62388;\n\tTue, 3 Mar 2026 12:17:50 +0100 (CET)", "from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n\t[205.220.168.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9E5BB62010\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Mar 2026 12:17:48 +0100 (CET)", "from pps.filterd (m0279863.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n\t6239moaJ2773382 for <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Mar 2026 11:17:46 GMT", "from mail-qk1-f197.google.com (mail-qk1-f197.google.com\n\t[209.85.222.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cnsjm16ag-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 03 Mar 2026 11:17:46 +0000 (GMT)", "by mail-qk1-f197.google.com with SMTP id\n\taf79cd13be357-8c71655aa11so5615989685a.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 03 Mar 2026 03:17:46 -0800 (PST)", "from t14s\n\t(2001-1c00-0c32-7800-beb3-9058-f5fe-3f2e.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:beb3:9058:f5fe:3f2e])\n\tby smtp.gmail.com with ESMTPSA id\n\t4fb4d7f45d1cf-66003479178sm2958144a12.9.2026.03.03.03.17.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 03 Mar 2026 03:17:43 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=qualcomm.com header.i=@qualcomm.com\n\theader.b=\"oUDYaxID\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n\theader.b=\"UV4XtFBi\"; dkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:date:from:message-id:mime-version\n\t:subject:to; s=qcppdkim1; bh=CGP20cioB98g8uxV7+sWAplxRuvnr6a1Zrj\n\tybqQix4A=; b=oUDYaxIDApEd02nEzy/8P3pCm7KgdF0H+V6+kcU0ln5Aie340r4\n\tH/ORyraXX+qIgvEUgGGlkTG1M/zx4c3kcuuZOUvYlXku8BLAMmZ0uqPcApzYvup4\n\tCVaj6Rrvi0C17kgUMrH6UIaIOwaCvkHaJ7zEuovjsDVeWo8l3/H8U+2m0iZZZcsn\n\t2Il8v7zeIwHOd2RPxvSZEqWVZUOcx7Dc+X68JcIqWamucL47z8Iwv6Jc7Q6qLrXo\n\tJVTD1nB8eSp0PPL3+/e0fS/gmB1zEOuK/nxIhdjqmaq8O95K+EMhcTAoT4uNlVeQ\n\tNx+IfnpRTCBpilEz9JaABNInuIBDv8oeT8A==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=oss.qualcomm.com; s=google; t=1772536665; x=1773141465;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=CGP20cioB98g8uxV7+sWAplxRuvnr6a1ZrjybqQix4A=;\n\tb=UV4XtFBi8C1nu5MpjOgBIyKJk0+gpo7JBCGN2k5arBXhl83tXyxNV+Sxfd0tZS7m8L\n\tfjKNNeXdULyQDuFTQO8+R4c5gW5hjjyAg+bnwexl3w1j2GnBdfs8oVBGur7JUlZvQYRU\n\t3+SVpWh+EAV7sjfhgLdMw19XOrA2r0Z/Nz894Jm7sj0tG7jtNWsIsz+cFkVPUH9kJAEJ\n\tSL1lauI5M5cuVIHju6ToNgsi/ISGMygoDXHAoHVlSFbJR/3pZ3K7i7vkXCQsr0Ps+C2H\n\tfi00yEay6LCdKAdfr4gcTOICuW6E6Jcp0fy8zBbXaj/0XXSD84EfuK77jSK1MfrY1WsQ\n\tW1+A==" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1772536665; x=1773141465;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=CGP20cioB98g8uxV7+sWAplxRuvnr6a1ZrjybqQix4A=;\n\tb=ZhOoUZAhZ5l2TqgZF/ZC6jdn/prsAc38jwRlOTWUZcD3OQCBM4yIGmXumc0+qsaGKn\n\tejfJPWIEFe4qTSewfK1oNq1Ra1Fx+XZbrTafI7QLjLBEEK3IpRlQ9ijoYiz8+SlC7qLp\n\tnXD0p1VsAKVOW8T22jrxtzsPQRRv1jEP0RhDaTli6OvSnmtfLuAcCKmYEv0kkws/EjfQ\n\ttPdbEc2W85uVPcfht47jLjOXBmpDE+cijp3QfeBCyYCXbFxBCBNx64HaPixcelO3rlEj\n\toldHU5OktIohmCJcmhJMHnFwo2bCxWQtXMpa61ewC+br9uahurxO8I8jkbXE6C6xD5RO\n\tLhgw==", "X-Gm-Message-State": "AOJu0Yw4PuGntkBjTbdDV/Ozn0Ntj+JyS46K1wm0/Cirjal2mmdtiAbX\n\ty+yqmr22kJjzckodMIYYcsY8lz2dX1lUvfNMPZStq2bOP+43Wa9jvd/tn41Bk7PNjqV9eCxaFxW\n\t7HAFbdywdUS9OLgd77HHMNAvVftMCff+Ncka08GX5upWNPGyiMHr8qShAr/9b3QzubwISKN3jSu\n\tWaCdLNEzlJ", "X-Gm-Gg": "ATEYQzwc+4uqcCauovJNL/aOuJlw2KA28WfOEs2kZ6RkjvLIkGvwjJlehwOc0oWL1i3\n\teFzmu6zdEgVFfIAIAyMYYWZ0tkdgQRfj4hPX+MV596YryA4Z/whbOhebX7/yWwrrk03AyTMDSKo\n\tgY9q0vsSNZxBMxA2ELdWqBqSh0nuUmbR/FS+V1QFQBp6orIztBddX9PSuGany1uOQXOee63fVYx\n\tlryONBnxZsvz9NqRJjfpC2lSoZmn9S8MrCbL2qKzUwjg6mqWfX7QxIsTttRSNxKUZN3vordzNat\n\t6vWHQPtV41kGAGzLgfCi7SR3qNTsBYP2rNPIzEElcSVQCnDQbz+DchOnZphU+N6CM2iKeNRuycg\n\tjerda0b7hbs09kQ+7OUlSplxoJpCoJEZWPgU6KjynqDGsk5ADcEHEosnfKJLnfZDK/xLTJsmkkI\n\tDn3GFvvrW5lHmzesqbpzkoxanLRM8d3hRRsw==", "X-Received": [ "by 2002:a05:620a:4509:b0:8c6:e11c:5ebc with SMTP id\n\taf79cd13be357-8cbc8ddd208mr2067003685a.18.1772536664862; \n\tTue, 03 Mar 2026 03:17:44 -0800 (PST)", "by 2002:a05:620a:4509:b0:8c6:e11c:5ebc with SMTP id\n\taf79cd13be357-8cbc8ddd208mr2067001185a.18.1772536664425; \n\tTue, 03 Mar 2026 03:17:44 -0800 (PST)" ], "From": "Hans de Goede <johannes.goede@oss.qualcomm.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tHans de Goede <johannes.goede@oss.qualcomm.com>", "Subject": "[PATCH v4 0/4] software_isp: debayer_cpu: Add multi-threading\n\tsupport", "Date": "Tue, 3 Mar 2026 12:17:37 +0100", "Message-ID": "<20260303111741.17417-1-johannes.goede@oss.qualcomm.com>", "X-Mailer": "git-send-email 2.52.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Proofpoint-GUID": "3hy0xG-yTAXH3M5F00GodNYr13VX2IQ3", "X-Authority-Analysis": "v=2.4 cv=GIUF0+NK c=1 sm=1 tr=0 ts=69a6c35a cx=c_pps\n\ta=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=Yq5XynenixoA:10\n\ta=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n\ta=yOCtJkima9RkubShWh1s:22 a=W2Wr-CLUWLQvppzWVxsA:9\n\ta=IoWCM6iH3mJn3m4BftBB:22", "X-Proofpoint-ORIG-GUID": "3hy0xG-yTAXH3M5F00GodNYr13VX2IQ3", "X-Proofpoint-Spam-Details-Enc": "AW1haW4tMjYwMzAzMDA4NiBTYWx0ZWRfX97WmokReEhW3\n\ttNnyTt+BZ1TPpRymlj6/SXsByqdOdW+XylP4E9+YmuJcXk4t2BNlESst34xH253mLCTthCaBG57\n\tlp1zhcw4x3grY3WYgwmhMgK4ZVgKhQZ/wm7us8pren4UUYY5jS5bmv7r1HLzMzvOxUmTkQBu8CY\n\tz1clpKnEOmB3/6cHrxm9/Eyd8pFVjmbwsaMYmXLnce7OLLyGDfPHUQo+8KjnFNVPjblL9vpKryz\n\tYnRndNzczRkGds5M7SfOk9mse4sRvEf636nvGUstI6YPdMz7k/ffvWhNXDA6g0nAGGARnRQ8Yoe\n\tAO70kS+g9hhxSeUSFKdxfSK+XXoQ2bHZfgiyZu/01WoxGnEPyiTibbr9ZdCQMlsB8rh751G8sLS\n\tHWNg9qy6uJv77aJuDYJ9XLSiVGdLpMlJDuD1dKF2lSGVdz0vn/e6PfdZnpr8eC7aLO9w5LTpIbd\n\tVHLz7SrQyM2VCd4WW1g==", "X-Proofpoint-Virus-Version": "vendor=baseguard\n\tengine=ICAP:2.0.293, Aquarius:18.0.1121, Hydra:6.1.51,\n\tFMLib:17.12.100.49\n\tdefinitions=2026-03-02_05,2026-03-03_01,2025-10-01_01", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n\tbulkscore=0 impostorscore=0 priorityscore=1501 clxscore=1015\n\tmalwarescore=0\n\tsuspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0\n\tadultscore=0\n\tclassifier=typeunknown authscore=0 authtc= authcc= route=outbound\n\tadjust=0\n\treason=mlx scancount=1 engine=8.22.0-2602130000\n\tdefinitions=main-2603030086", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi All,\n\nThe QCM2290 SoC used on the Arduino Uno-Q seems to have a weak GPU, so weak\nthat it is barely faster then a single CPU core (CPU without CCM).\n\nThis has made me code-up the long envisioned multi-threading support\nfor the CPU softISP.\n\nChanges in v4:\n- Use const in for (const auto &s : stats_) {} in SwStatsCpu::finishFrame()\n- Move kMaxLineBuffers constant to DebayerCpuThread class\n- Document \"software_isp\", \"threads\" option in runtime_configuration.rst\n- Add an use constants for min/max/default number of threads\n\nChanges in v3:\n- Use std::unique_ptr for the DebayerCpuThread pointers\n- Document new DebayerCpuThread class\n- Make DebayerCpuThread inherit from both Thread and Object\n- Use for (auto &thread : threads_)\n- Use for (auto &s : stats_) {}\n- Move input format logging from DebayerCpu::configure() to\n SoftwareIsp::configure()\n\nChanges in v2:\n- Quite a bit of refactoring based on v1 feedback, dropped patch 3/5 and 4/5\n from v2 since these now no longer make sense\n- Move the allocation of the vector of SwIspStats objects to inside\n the SwStatsCpu class, controlled by a configure() arguments instead\n of making the caller allocate the objects\n- Replace the DebayerCpuThreadData struct from v1 with a DebayerCpuThread\n class, derived from Object to allow calling invokeMethod for thread re-use\n in followup patches\n- As part of this also move a bunch of methods which primarily deal with\n per thread data: setupInputMemcpy(), shiftLinePointers(), memcpyNextLine(),\n process*() to the new DebayerCpuThread class\n- Re-use threads instead of starting new threads every frame\n- Add a new patch adding some extra DebayerCpu input format logging\n\nBenchmark results for the Uno-Q + IMX219 running at 3280x2464 -> 3272x2464\nwithout CCM:\n\n1 thread : 147ms / frame, ~6.5 fps\n2 threads: 80ms / frame, ~12.5 fps\n3 threads: 65ms / frame, ~15 fps\nGPU: 130ms / frame, ~7,5 fps\nGPU 0-copy: 110ms / frame, ~9.5 fps (requires pipeline + camss hacks)\nGPU lite: 85ms / frame, ~12 fps (CCM, contrast and gamma disabled)\n\nRegards,\n\nHans\n\n\nHans de Goede (4):\n software_isp: swstats_cpu: Prepare for multi-threading support\n software_isp: debayer_cpu: Add DebayerCpuThread class\n software_isp: debayer_cpu: Add multi-threading support\n software_isp: Log input config from configure()\n\n Documentation/runtime_configuration.rst | 1 +\n .../internal/software_isp/swstats_cpu.h | 25 +-\n src/libcamera/software_isp/debayer_cpu.cpp | 286 ++++++++++++++----\n src/libcamera/software_isp/debayer_cpu.h | 33 +-\n src/libcamera/software_isp/software_isp.cpp | 12 +-\n src/libcamera/software_isp/swstats_cpu.cpp | 54 ++--\n 6 files changed, 302 insertions(+), 109 deletions(-)" }