Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/25993/?format=api
{ "id": 25993, "url": "https://patchwork.libcamera.org/api/1.1/covers/25993/?format=api", "web_url": "https://patchwork.libcamera.org/cover/25993/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260128114402.31570-1-mzamazal@redhat.com>", "date": "2026-01-28T11:43:47", "name": "[v5,00/15] Simple pipeline IPA cleanup", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/1.1/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "mbox": "https://patchwork.libcamera.org/cover/25993/mbox/", "series": [ { "id": 5748, "url": "https://patchwork.libcamera.org/api/1.1/series/5748/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5748", "date": "2026-01-28T11:43:47", "name": "Simple pipeline IPA cleanup", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5748/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/25993/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04F69C3200\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 Jan 2026 11:44:15 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F1F661FCC;\n\tWed, 28 Jan 2026 12:44:14 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CA70C61FC4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 Jan 2026 12:44:11 +0100 (CET)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-449-6jsylYi8M4WEci5BOhqIZA-1;\n\tWed, 28 Jan 2026 06:44:08 -0500", "from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 0989F1800447; Wed, 28 Jan 2026 11:44:07 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.34.236])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 636FC19560B2; Wed, 28 Jan 2026 11:44:05 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Sm1ba+6x\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1769600650;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=hYfjrR3GUMvPdrmvBjD2Krk+vjJYGi6oLKOr3hZWmTY=;\n\tb=Sm1ba+6xASZIuvC27TNcX/l2Nl8mmaFW68wvINOrKqo3YprQ+jdzaB2w8zV4LD683l8E99\n\tN7X6cbTRBEL77NW/gGABUgurmpkr7/rsOFFWX3/B9VMoYLhKqx9tI2Ju7EKnegiJj+bjgZ\n\tsXZ1ZykHp7BTVg7HKrYwuOkEKXizsHY=", "X-MC-Unique": "6jsylYi8M4WEci5BOhqIZA-1", "X-Mimecast-MFC-AGG-ID": "6jsylYi8M4WEci5BOhqIZA_1769600647", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v5 00/15] Simple pipeline IPA cleanup", "Date": "Wed, 28 Jan 2026 12:43:47 +0100", "Message-ID": "<20260128114402.31570-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.12", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "SP_2DU3348q05J-lLTP9GsmVHyzVHWmWQzrkAUzb1pI_1769600647", "X-Mimecast-Originator": "redhat.com", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The simple pipeline image algorithms inappropriately mix various stuff\ntogether. For example, contrast and saturation processing is mixed with\nCCM and LUT processing, algorithms cannot be disabled without making\nsoftware ISP malfunctioning and some \"algorithms\", like lookup table\nconstruction, are not algorithms at all.\n\nThis patch series introduces new algorithm Adjust for contrast,\nsaturation and gamma adjustments, moves lookup table construction to\ndebayering, separates CCM from the combined matrix (which includes white\nbalance and saturation adjustments), and cleans up some other things.\n\nChanges in v5:\n- Rebased to resolve a minor conflict.\n- CI: \n\nChanges in v4:\n- Remaining redundant <optional> include removed from adjust.h.\n- Gamma value is reported in metadata.\n- Contrast value is always reported in metadata.\n- context.activeState.knobs.gamma is no longer std::optional.\n- gpuIspEnabled removed from everywhere.\n- Matrix comparison simplified as suggested by Barnabás.\n- Multiple params_->combinedMatrix assignments replaced by a single one.\n- Unused context.activeState.ccm removed.\n- currentCcm_ wrapped by std::optional and ccmAssigned_ removed.\n- kDefault* constants made constexpr.\n- kDefaultContrast and kDefaultSaturation moved to adjust.cpp.\n- Minor corrections in commit messages.\n\nChanges in v3:\n- Rebased on the merged GPU ISP and adjusted for the changes there.\n- A patch reverting enabling Ccm algorithm by GPU ISP added.\n\nChanges in v2:\n- Commit message of \"Generalise tracking matrix changes\" improved a bit.\n- correctionMatrix renamed to combinedMatrix.\n- combinedMatrix initialisations fixed and Matrix::identity utilised.\n- gamma made adjustable.\n- Types of contrast, saturation, gamma set to float (from double in some\n places).\n- Symbolic constants are used for contrast, saturation, gamma defaults.\n- The gain matrix is applied directly in awb.cpp now.\n- Lut \"algorithm\" removed; lookup tables construction moved to\n debayering.\n\nMilan Zamazal (15):\n libcamera: ipa: simple: Remove an unused include from awb.cpp\n libcamera: ipa: simple: Unwrap IPAFrameContext::ccm\n libcamera: ipa: simple: Generalize tracking matrix changes\n libcamera: ipa: simple: Rename \"ccm\" identifiers not specific to CCM\n libcamera: ipa: simple: Introduce a general correction matrix\n libcamera: ipa: simple: Initialise the general correction matrix\n libcamera: ipa: simple: Separate saturation from CCM\n libcamera: ipa: simple: Move contrast settings to adjust.cpp\n libcamera: ipa: simple: Make gamma adjustable\n libcamera: ipa: simple: Apply gain matrix in awb\n libcamera: ipa: simple: Use float type for adjustment controls\n libcamera: ipa: simple: Use symbolic constants for adjust defaults\n libcamera: ipa: simple: Set contrast metadata unconditionally\n libcamera: ipa: simple: Remove Lut algorithm\n libcamera: ipa: simple: Disable Ccm algorithm by default again\n\n .../internal/software_isp/debayer_params.h | 45 +----\n include/libcamera/ipa/soft.mojom | 3 +-\n src/ipa/simple/algorithms/adjust.cpp | 134 ++++++++++++++\n src/ipa/simple/algorithms/{lut.h => adjust.h} | 28 +--\n src/ipa/simple/algorithms/awb.cpp | 12 +-\n src/ipa/simple/algorithms/ccm.cpp | 80 ++------\n src/ipa/simple/algorithms/ccm.h | 12 +-\n src/ipa/simple/algorithms/lut.cpp | 174 ------------------\n src/ipa/simple/algorithms/meson.build | 2 +-\n src/ipa/simple/data/uncalibrated.yaml | 14 +-\n src/ipa/simple/ipa_context.h | 27 +--\n src/ipa/simple/soft_simple.cpp | 13 +-\n src/libcamera/software_isp/debayer.cpp | 172 +----------------\n src/libcamera/software_isp/debayer.h | 8 -\n src/libcamera/software_isp/debayer_cpu.cpp | 136 ++++++++++++--\n src/libcamera/software_isp/debayer_cpu.h | 26 ++-\n src/libcamera/software_isp/debayer_egl.cpp | 27 ++-\n src/libcamera/software_isp/software_isp.cpp | 29 +--\n 18 files changed, 369 insertions(+), 573 deletions(-)\n create mode 100644 src/ipa/simple/algorithms/adjust.cpp\n rename src/ipa/simple/algorithms/{lut.h => adjust.h} (57%)\n delete mode 100644 src/ipa/simple/algorithms/lut.cpp" }