Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/25872/?format=api
{ "id": 25872, "url": "https://patchwork.libcamera.org/api/1.1/covers/25872/?format=api", "web_url": "https://patchwork.libcamera.org/cover/25872/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20260120-sklug-lsc-resampling-v2-dev-v5-0-ef5cec7b299f@ideasonboard.com>", "date": "2026-01-20T12:26:05", "name": "[v5,00/15] Add resampling support for polynomial LSC data", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/25872/mbox/", "series": [ { "id": 5722, "url": "https://patchwork.libcamera.org/api/1.1/series/5722/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5722", "date": "2026-01-20T12:26:05", "name": "Add resampling support for polynomial LSC data", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5722/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/25872/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B600EBDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Jan 2026 12:26:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 695CB61FC5;\n\tTue, 20 Jan 2026 13:26:13 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F7CD61A35\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Jan 2026 13:26:11 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:b09a:fcc3:e9a4:a9a8])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id A451A177D; \n\tTue, 20 Jan 2026 13:25:39 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WuuJ4lRt\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1768911939;\n\tbh=pRZh3bBXHXsOAobMAMUObad6Y1pIvvIZRMKnc0U1qTo=;\n\th=From:Subject:Date:To:Cc:From;\n\tb=WuuJ4lRttmjPEGrjtvJGOA4RV9k6AWNMJWEinptXKvr5lm5qfT0GY4rdsSY3WZjpv\n\txX3xsdUbe/zyd4Qt7JVEINaOjUXntSCbe3qjCbYAMUMMVV9ZFDxQADgBlG1rgUGw8Y\n\ts7FdqL9p+BBWrbi8KOpsBv+poiI+ngqg0X/DiFvE=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v5 00/15] Add resampling support for polynomial LSC data", "Date": "Tue, 20 Jan 2026 13:26:05 +0100", "Message-Id": "<20260120-sklug-lsc-resampling-v2-dev-v5-0-ef5cec7b299f@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "X-B4-Tracking": "v=1; b=H4sIAF10b2kC/33OwQ6CMAyA4VcxOzuzjTHAk+9hPMBaYBEY2XTRE\n\tN7dQWLCQTk1fw9fOxGPzqAn58NEHAbjjR1ipMcD0W05NEgNxCaCCcU4y6i/d8+Gdl5Th77sx84\n\tMDQ2CAgYKWZZKVvFMAZIojA5r81r16y12a/zDuvd6LIhl+3XzXTcORlHlArWsirxILgaw9Haob\n\tOngpG1PFj4kG5LLfTKJZM40CFlLAMX/kHJDCrZPykgKyXl8EhUo+EHO8/wB6zzI9nMBAAA=", "X-Change-ID": "20260107-sklug-lsc-resampling-v2-dev-d77540b176de", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P?=\n\t=?utf-8?b?xZFjemU=?= <barnabas.pocze@ideasonboard.com>,\n\tRui Wang <rui.wang@ideasonboard.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, Jacopo Mondi <jacopo@jmondi.org>", "X-Mailer": "b4 0.14.2", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In [1] support for polynomial lens shading tables was implement up to\nthe same feature level of grid based lens shading tables. However\nresampling the LSC table for a given analog crop rectangle was never\nimplemented.\n\nThis series partially fixes that by implementing resampling for\npolynomial LSC data. Resampling for tabular LSC data is left open for\nimplementation if need arises.\n\nPatches 1-7 apply some code cleanup that got mentioned on the last\nseries after it was merged.\n\nPatches 8-10 apply further cleanup and are new in v2 of the series.\n\nPatches 11-13 implement the actual resampling.\n\nPatches 14-15 implement a LensShadingCorrectionEnable control that is\nnecessary to assess the effect of LSC in practice. Patch 14 resurrects\nan old patch from Jacopo [2]. These last two patches could be stripped\noff the series if needed.\n\nBest regards,\nStefan\n\n[1] https://patchwork.libcamera.org/project/libcamera/list/?series=4609&archive=both&state=*\n[2] https://patchwork.libcamera.org/project/libcamera/list/?series=3795&archive=both&state=*\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\nChanges in v5:\n- Split patch 14 into two again to have a separate patch for the\n control id changes.\n- Link to v4: https://patchwork.libcamera.org/project/libcamera/list/?series=5720\n\nChanges in v4:\n- Dropped removal of controls::draft::LensShadingMapMode and squashed\n patches 14 and 15\n- Minor fixes from review (see local changelogs)\n- Link to v3: https://patchwork.libcamera.org/project/libcamera/list/?series=5707\n\nChanges in v3:\n- Added LensShadingCorrectionEnable to metadata\n- Improved colour temperature quantization code\n- Tiny fixes (see local changelogs)\n- Link to v2: https://patchwork.libcamera.org/project/libcamera/list/?series=5697\n\nChanges in v2:\n- Collected tags\n- Applied small fixes from review\n- Additional cleanup by patches 8-10 to improve the prepare() function\n- A bit more rework on the resampling patches due to preceding changes\n\n---\nStefan Klug (15):\n ipa: rkisp1: lsc: Drop unused member variable\n ipa: rkisp1: lsc: Drop unused function declaration\n ipa: rkisp1: lsc: Replace assert with ASSERT\n ipa: rkisp1: lsc: Rename res to positions\n ipa: rkisp1: lsc: Rename res to ret\n ipa: rkisp1: lsc: Rename res to samples\n ipa: rksip1: lsc: Move function definitions out of class\n ipa: rkisp1: lsc: Move local types into anonymous namespace\n ipa: rkisp1: lsc: Handle quantization locally\n ipa: libipa: interpolator: Drop key quantization\n ipa: rkisp1: lsc: Pass sampling positions into samplePolynomial\n ipa: rkisp1: lsc: Pass crop rectangle as parameter\n ipa: rkisp1: lsc: Resample polynomial lens shading tables at configure time\n libcamera: control_ids: Introduce LensShadingCorrectionEnable\n ipa: rkisp1: Implement LensShadingCorrectionEnable control\n\n src/ipa/libipa/interpolator.cpp | 25 +-\n src/ipa/libipa/interpolator.h | 14 +-\n src/ipa/rkisp1/algorithms/dpf.cpp | 2 +-\n src/ipa/rkisp1/algorithms/lsc.cpp | 505 +++++++++++++++++++++++-------------\n src/ipa/rkisp1/algorithms/lsc.h | 24 +-\n src/ipa/rkisp1/ipa_context.h | 13 +-\n src/libcamera/control_ids_core.yaml | 9 +\n test/ipa/libipa/interpolator.cpp | 7 -\n 8 files changed, 360 insertions(+), 239 deletions(-)\n---\nbase-commit: c63f2c72cd7b278584dcc70b8294063e89b01ca1\nchange-id: 20260107-sklug-lsc-resampling-v2-dev-d77540b176de\n\nBest regards," }