Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/24933/?format=api
{ "id": 24933, "url": "https://patchwork.libcamera.org/api/1.1/covers/24933/?format=api", "web_url": "https://patchwork.libcamera.org/cover/24933/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251031203854.19021-1-kieran.bingham@ideasonboard.com>", "date": "2025-10-31T20:38:52", "name": "[v3,0/2] libcamera: base: utils: Prevent hex signed extension", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/24933/mbox/", "series": [ { "id": 5549, "url": "https://patchwork.libcamera.org/api/1.1/series/5549/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5549", "date": "2025-10-31T20:38:52", "name": "libcamera: base: utils: Prevent hex signed extension", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5549/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/24933/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5D569BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 31 Oct 2025 20:39:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6F96660A80;\n\tFri, 31 Oct 2025 21:39:00 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 187F960947\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 31 Oct 2025 21:38:58 +0100 (CET)", "from charm.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DEE91558;\n\tFri, 31 Oct 2025 21:37:06 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UN7TC3Uj\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1761943027;\n\tbh=VSyK8C4vNlixhgRkAwFnUO9s20tcN7u9SlFg5w7slYw=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=UN7TC3UjQx0mho94/7xDBjow0AYINjHaGTPQ6hbH8QbUHz4+qD7dcVsfh+EMgUrEy\n\tYkn+xETTq5XQ2iHrYkXrmLr1zOWGfBvY8htxe/LrUi1VGvdF2Y5CFdpPUpyVyG8iyG\n\tH1LMIOOIuPHq2NR56tGalH3q/evIBSLUQh2DaXkE=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v3 0/2] libcamera: base: utils: Prevent hex signed extension", "Date": "Fri, 31 Oct 2025 20:38:52 +0000", "Message-ID": "<20251031203854.19021-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.51.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When converting signed values to hex strings using the utils::hex\nhelpers, signed negative values get sign extended to the larger 64 bit\ntype.\n\nThis causes values such as 0x80 to be printed as 0xffffffffffffff80\ninstead.\n\nFix this by first adding a test to catch and identify the issue, and\nsecondly by reconfiguring the hex adaptor to use a single templated type\nwhich always casts to an unsigned version of the incoming type.\n\nKieran Bingham (2):\n test: utils: Validate hex sign extension\n libcamera: base: utils: Simplify hex adaptor\n\n include/libcamera/base/utils.h | 68 +++++++---------------------------\n src/libcamera/base/utils.cpp | 3 +-\n test/utils.cpp | 17 +++++++++\n 3 files changed, 33 insertions(+), 55 deletions(-)" }