Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/249/?format=api
{ "id": 249, "url": "https://patchwork.libcamera.org/api/1.1/covers/249/?format=api", "web_url": "https://patchwork.libcamera.org/cover/249/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190116135949.2097-1-jacopo@jmondi.org>", "date": "2019-01-16T13:59:44", "name": "[libcamera-devel,v2,0/5] libcamera: pipeline: Add Intel IPU3 pipeline handler", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/249/mbox/", "series": [ { "id": 85, "url": "https://patchwork.libcamera.org/api/1.1/series/85/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=85", "date": "2019-01-16T13:59:44", "name": "libcamera: pipeline: Add Intel IPU3 pipeline handler", "version": 2, "mbox": "https://patchwork.libcamera.org/series/85/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/249/comments/", "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AECFD60B2D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jan 2019 14:59:48 +0100 (CET)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 2ADDDC000A;\n\tWed, 16 Jan 2019 13:59:47 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 16 Jan 2019 14:59:44 +0100", "Message-Id": "<20190116135949.2097-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 0/5] libcamera: pipeline: Add Intel\n\tIPU3 pipeline handler", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 16 Jan 2019 13:59:48 -0000" }, "content": "Hello second iteration for the IPU3 pipeline manager.\n\nDropped from the series the awkward patch than made Camera's destructors public\nand used them in VIMC and IPU3 pipeline handler. Cameras are just \"put\" at\npipeline handler destruction time. This will possibly be reworked when the\nlifetime of Camera devices will be re-worked.\n\nI have here added a patch to actually set (and get) a MediaEntity devnode path,\nand a little patch to make the pipeline handlers name a bit more expressive than\njust the class names.\n\nOn the real meat of the series: the IPU3 pipeline handler. I included\nsuggestions from Niklas and Laurent on re-ordering the media device acquisition,\nand made a bit more clear what is going on when operating on maps as suggested\nby Kieran. Also, I made sure camera names are now unique in the system.\n\nOverall, I have expanded comments as bit, as I agree with Niklas this class\nshould serve as example for future pipeline handlers, so it is worth having a\nfew comments more than necessary there.\n\nI have kept in patch [1/5] modifications to the list-cameras test, even if I\nhave there included comments received on v1. I assume more comments will arrive\non this.\n\nTested on Soraka, where cameras gets enumerated as:\n\nroot@libcamera:/home/cam/libcamera_deploy# ./test/list-cameras\n[3:07:00.815060285] DBG pipeline_handler.cpp:119 Registered pipeline handler \"VIMC virtual driver pipeline handler\"\n[3:07:00.815296070] DBG pipeline_handler.cpp:119 Registered pipeline handler \"Intel IPU3 pipeline handler\"\n[3:07:00.816056718] DBG device_enumerator.cpp:214 New media device \"ipu3-imgu\" created from /dev/media1\n[3:07:00.816625144] DBG device_enumerator.cpp:214 New media device \"ipu3-cio2\" created from /dev/media0\n[3:07:00.817116059] DBG device_enumerator.cpp:255 Successful match for media device \"ipu3-cio2\"\n[3:07:00.817132343] DBG device_enumerator.cpp:255 Successful match for media device \"ipu3-imgu\"\n[3:07:00.817157509] DBG media_device.cpp:672 ov13858 2-0010[0] -> ipu3-csi2 0[0]: 0\n[3:07:00.817165563] DBG media_device.cpp:672 ov5670 4-0036[0] -> ipu3-csi2 1[0]: 0\n[3:07:00.817198891] DBG media_device.cpp:672 ov13858 2-0010[0] -> ipu3-csi2 0[0]: 1\n[3:07:00.817232593] INFO ipu3.cpp:249 Registered Camera[0] \"ov13858 0\" connected to CSI-2 receiver 0\n[3:07:00.817247081] DBG media_device.cpp:672 ov5670 4-0036[0] -> ipu3-csi2 1[0]: 1\n[3:07:00.817258419] INFO ipu3.cpp:249 Registered Camera[1] \"ov5670 1\" connected to CSI-2 receiver 1\n[3:07:00.817269201] DBG ipu3.cpp:147 \"Intel IPU3\" pipeline handler initialized with 2 cameras registered\n[3:07:00.817279348] DBG pipeline_handler.cpp:150 Pipeline handler \"Intel IPU3 pipeline handler\" matched\nFound camera 'ov13858 0\nFound camera 'ov5670 1\n\nThanks\n j\n\nJacopo Mondi (5):\n test: list-cameras: Make test output more verbose\n libcamera: media_object: Add functions to entities\n libcamera: media_object: Set devnode in MediaEntity\n libcamera: pipeline: Allows more expressive names\n libcamera: pipeline: Add Intel IPU3 pipeline\n\n src/libcamera/include/media_object.h | 3 +\n src/libcamera/include/pipeline_handler.h | 4 +-\n src/libcamera/media_object.cpp | 33 ++-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 263 +++++++++++++++++++++++\n src/libcamera/pipeline/ipu3/meson.build | 3 +\n src/libcamera/pipeline/meson.build | 2 +\n src/libcamera/pipeline/vimc.cpp | 2 +-\n test/list-cameras.cpp | 41 +++-\n 8 files changed, 335 insertions(+), 16 deletions(-)\n create mode 100644 src/libcamera/pipeline/ipu3/ipu3.cpp\n create mode 100644 src/libcamera/pipeline/ipu3/meson.build\n\n--\n2.20.1" }