Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/24637/?format=api
{ "id": 24637, "url": "https://patchwork.libcamera.org/api/1.1/covers/24637/?format=api", "web_url": "https://patchwork.libcamera.org/cover/24637/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20251014133404.3194952-1-paul.elder@ideasonboard.com>", "date": "2025-10-14T13:34:00", "name": "[v5,0/2] Fix ControlSerializer deserializing array controls", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/1.1/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/24637/mbox/", "series": [ { "id": 5501, "url": "https://patchwork.libcamera.org/api/1.1/series/5501/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5501", "date": "2025-10-14T13:34:00", "name": "Fix ControlSerializer deserializing array controls", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5501/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/24637/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A180BE080\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 14 Oct 2025 13:34:25 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 18362605F3;\n\tTue, 14 Oct 2025 15:34:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB3C5605DF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 14 Oct 2025 15:34:21 +0200 (CEST)", "from neptunite.hamster-moth.ts.net (unknown\n\t[IPv6:2404:7a81:160:2100:946a:ef2f:f966:b71d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 654F3C73;\n\tTue, 14 Oct 2025 15:32:42 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NewtUOzR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1760448763;\n\tbh=K25L60p0QQ7hT8BV1gzsBLhxr/67lCJbxelI0IH7Gi8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=NewtUOzR0NsIErwrIGOAuxO3slnSZbU8EYWM5XEmCDQn1vNEa4acdPLr+QAORnlHk\n\tFQ7GsNwogpGOyNDgQkA2q9FemkZzd8ktRSUzPoNUNhuqIGTIJtp6hpSvQDayITTzN0\n\t8VUKi7sF6SQfH4QPM9aKjqUSVcUbhqldj0JTZwzc=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH v5 0/2] Fix ControlSerializer deserializing array controls", "Date": "Tue, 14 Oct 2025 22:34:00 +0900", "Message-ID": "<20251014133404.3194952-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This series fixes bug 285 [0] where running IPAs in isolation with array\ncontrols would cause the control deserialization to fail, since the\ndeserializer didn't properly deserialize array controls.\n\nThis is fixed by making the deserializer properly deserialize array\ncontrols, by adding all ControlValue metadata to the serialized form of\nControlInfoMap.\n\nv5 contains minor cleanups.\n\nv4 notably cleans up unused fields in metatata structs, so it touches\nControlList as well.\n\nIn v3 we reuse struct ipa_control_value_entry to store the relevant\ninformation instead, and add them to the serialized form of\nControlInfoMap.\n\nIn v2 the arrayness and size are stored in the serialized form of\nControlValue instead of using the information registered in the\nControlId. This allows us to support variable-length arrays (which v1\ndidn't), and allows us to support both non-array and array types min/max\nControlValues in the ControlInfo, depending on which type of min/max\nvalue makes more sense for the specific control.\n\n[0] https://bugs.libcamera.org/show_bug.cgi?id=285\n\nPaul Elder (2):\n libcamera: control_serializer: Add array info to serialized\n ControlValue\n ipa: ipu3, mali-c55, rkisp1, rpi: Fix reporting non-scalar controls\n\n .../libcamera/internal/control_serializer.h | 8 +-\n include/libcamera/ipa/ipa_controls.h | 11 +-\n src/ipa/ipu3/ipu3.cpp | 4 +-\n src/ipa/mali-c55/mali-c55.cpp | 4 +-\n src/ipa/rkisp1/algorithms/awb.cpp | 4 +-\n src/ipa/rkisp1/rkisp1.cpp | 3 +-\n src/ipa/rpi/common/ipa_base.cpp | 9 +-\n src/libcamera/control_serializer.cpp | 119 ++++++++++++------\n src/libcamera/ipa_controls.cpp | 20 ++-\n 9 files changed, 125 insertions(+), 57 deletions(-)" }