Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/24150/?format=api
{ "id": 24150, "url": "https://patchwork.libcamera.org/api/1.1/covers/24150/?format=api", "web_url": "https://patchwork.libcamera.org/cover/24150/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250818082909.2001635-1-stefan.klug@ideasonboard.com>", "date": "2025-08-18T08:28:38", "name": "[RFC,0/4] libipa: agc_mean_luminance: Use composition instead of", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/24150/mbox/", "series": [ { "id": 5390, "url": "https://patchwork.libcamera.org/api/1.1/series/5390/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5390", "date": "2025-08-18T08:28:38", "name": "libipa: agc_mean_luminance: Use composition instead of", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5390/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/24150/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C179FBEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 18 Aug 2025 08:29:56 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E31C96925B;\n\tMon, 18 Aug 2025 10:29:55 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D07066924E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Aug 2025 10:29:54 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:766d:a405:f64e:fe3a])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id ACF602394; \n\tMon, 18 Aug 2025 10:28:57 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d0PWWH8g\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1755505737;\n\tbh=0uzO4c/3lpkI+6jgb8wAr+AImKF6nNcCyi8KSdYPVow=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=d0PWWH8gsaXi1nZsqMKDT/NT57Y+Z+HqJlZl6U/OIP+R2bJT+Ckzyco4RE/H13Bnu\n\tjbTwSqkSxPPK++3m5xw98e44fLhLm5pG5f85hKFXC2G+12rFcmxTKaEFs9IP4ut5Iv\n\tTgSIdSEkrVXw66tgHCAm8UKW2FQ49IlZGCvGQ6oM=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[RFC PATCH 0/4] libipa: agc_mean_luminance: Use composition instead\n\tof", "Date": "Mon, 18 Aug 2025 10:28:38 +0200", "Message-ID": "<20250818082909.2001635-1-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi all,\n\nI found myself regularly getting confused by the control flow in the\nrkisp1 AGC algorithm. I then realized that it is due to Agc being\nderived from AgcMeanLuminance even though there is very little automatic\nfunctionality coming from AgcMeanLuminance. So I gave it a try to\nremove the need to derive from AgcMeanLuminance and this is the result.\n\nI believe it makes things easier to understand. But maybe that is just me.\nWhat do you think?\n\nBest regards,\nStefan\n\nStefan Klug (4):\n libipa: agc_mean_luminance: pass estimateLuminance() as parameter\n ipa: rkisp1: agc: Do not derive from AgcMeanLuminance\n ipa: ipu3: agc: Do not derive from AgcMeanLuminance\n ipa: mali-c55: agc: Do not derive from AgcMeanLuminance\n\n src/ipa/ipu3/algorithms/agc.cpp | 22 ++++++-----\n src/ipa/ipu3/algorithms/agc.h | 6 ++-\n src/ipa/libipa/agc_mean_luminance.cpp | 57 ++++++++++++++-------------\n src/ipa/libipa/agc_mean_luminance.h | 9 +++--\n src/ipa/mali-c55/algorithms/agc.cpp | 22 ++++++-----\n src/ipa/mali-c55/algorithms/agc.h | 5 ++-\n src/ipa/rkisp1/algorithms/agc.cpp | 43 +++++++++++---------\n src/ipa/rkisp1/algorithms/agc.h | 8 ++--\n 8 files changed, 94 insertions(+), 78 deletions(-)" }