Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/2260/?format=api
{ "id": 2260, "url": "https://patchwork.libcamera.org/api/1.1/covers/2260/?format=api", "web_url": "https://patchwork.libcamera.org/cover/2260/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191028022525.796995-1-niklas.soderlund@ragnatech.se>", "date": "2019-10-28T02:25:13", "name": "[libcamera-devel,RFC,00/12] libcamera: Rework buffer API", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/1.1/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "mbox": "https://patchwork.libcamera.org/cover/2260/mbox/", "series": [ { "id": 561, "url": "https://patchwork.libcamera.org/api/1.1/series/561/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=561", "date": "2019-10-28T02:25:13", "name": "libcamera: Rework buffer API", "version": 1, "mbox": "https://patchwork.libcamera.org/series/561/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/2260/comments/", "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 683956017C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2019 03:25:46 +0100 (CET)", "from localhost.localdomain (unknown [93.2.121.143])\n\tby bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 3bb6f269-f92a-11e9-903a-005056917f90;\n\tMon, 28 Oct 2019 03:25:43 +0100 (CET)" ], "X-Halon-ID": "3bb6f269-f92a-11e9-903a-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 28 Oct 2019 03:25:13 +0100", "Message-Id": "<20191028022525.796995-1-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.23.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC 00/12] libcamera: Rework buffer API", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 28 Oct 2019 02:25:46 -0000" }, "content": "Hi,\n\nThis is the RFC for the new buffer API, it is posted without \ndocumentation just to measure if they are going in the right direction. \n\nI'm hoping for review of the code that touches cam, qcam and pipeline \nhandlers to judge if the new API is easy and neat to use for developers. \nI'm sure the inner plumbing can be reviewed in a potential v1 where \nproper documentation will be available.\n\nI'm sorry for the large patches at the end, but as the rework touches \npretty much every part of the code base it's hard to break it down. If \nanyone spot any obvious way to break it down even further please let me \nknow and I will work on it for v1.\n\nThis series depends on the buffer cleanup series [1].\n\n1. [PATCH 00/10] libcamera: Fixes found while working on new buffer API \n\nNiklas Söderlund (12):\n test: camera: buffer_import: Remove test\n libcamera: pipelines: Explicitly allocate streams\n libcamera: pipeline: Add helper to find request from buffer\n libcamera: pipelines: Switch to helper to resolve request from buffer\n libcamera: buffer: Remove request tracking\n libcamera: stream: Add prototypes for new interface\n libcamera: buffer: Add dedicated container for buffer information\n libcamera: buffer: Add a buffer allocator\n libcamera: v4l2_videodevice: Add a buffer cache class\n libcamera: buffer: Store buffer information in separate container\n libcamera: buffer: Switch to new buffer API\n libcamera: buffer: Clean up after buffer API switch\n\n include/ipa/ipa_interface.h | 2 +-\n include/libcamera/buffer.h | 90 ++--\n include/libcamera/request.h | 8 +-\n include/libcamera/stream.h | 21 +-\n src/cam/buffer_writer.cpp | 12 +-\n src/cam/buffer_writer.h | 4 +-\n src/cam/capture.cpp | 53 ++-\n src/cam/capture.h | 3 +-\n src/ipa/rkisp1/rkisp1.cpp | 14 +-\n src/libcamera/buffer.cpp | 325 ++++---------\n src/libcamera/camera.cpp | 47 +-\n src/libcamera/include/pipeline_handler.h | 5 +-\n src/libcamera/include/v4l2_videodevice.h | 56 ++-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 269 ++++-------\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 131 +++---\n src/libcamera/pipeline/uvcvideo.cpp | 35 +-\n src/libcamera/pipeline/vimc.cpp | 36 +-\n src/libcamera/pipeline_handler.cpp | 15 +-\n src/libcamera/request.cpp | 22 +-\n src/libcamera/stream.cpp | 241 ----------\n src/libcamera/v4l2_videodevice.cpp | 367 ++++++++-------\n src/qcam/main_window.cpp | 61 ++-\n src/qcam/main_window.h | 5 +-\n test/camera/buffer_import.cpp | 432 ------------------\n test/camera/capture.cpp | 33 +-\n test/camera/meson.build | 1 -\n test/camera/statemachine.cpp | 12 +-\n test/v4l2_videodevice/buffer_sharing.cpp | 36 +-\n test/v4l2_videodevice/capture_async.cpp | 16 +-\n test/v4l2_videodevice/request_buffers.cpp | 11 +-\n test/v4l2_videodevice/stream_on_off.cpp | 6 +-\n test/v4l2_videodevice/v4l2_m2mdevice.cpp | 44 +-\n test/v4l2_videodevice/v4l2_videodevice_test.h | 2 +-\n 33 files changed, 749 insertions(+), 1666 deletions(-)\n delete mode 100644 test/camera/buffer_import.cpp" }