Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/22217/?format=api
{ "id": 22217, "url": "https://patchwork.libcamera.org/api/1.1/covers/22217/?format=api", "web_url": "https://patchwork.libcamera.org/cover/22217/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241206145242.827886-1-stefan.klug@ideasonboard.com>", "date": "2024-12-06T14:52:20", "name": "[v5,0/8] rkisp1: Add manual colour temperature control", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/1.1/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/22217/mbox/", "series": [ { "id": 4857, "url": "https://patchwork.libcamera.org/api/1.1/series/4857/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4857", "date": "2024-12-06T14:52:20", "name": "rkisp1: Add manual colour temperature control", "version": 5, "mbox": "https://patchwork.libcamera.org/series/4857/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/22217/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8B9F1BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Dec 2024 14:52:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 751B46615F;\n\tFri, 6 Dec 2024 15:52:49 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 543A7618B3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Dec 2024 15:52:47 +0100 (CET)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:3543:aebe:e043:ef86])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B135D641;\n\tFri, 6 Dec 2024 15:52:17 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uz2hJKWe\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1733496737;\n\tbh=ZQHemcqLzti+Vi0E9srTsr2d/i66vgcJzUrRYb1FPQA=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=uz2hJKWe2CmRySwSy2yZW+Mh9ZxQHtkvhg9UqnHV2ulZHH/7TVjdfgc2PvRjWGOdx\n\toyMLTgtLvYgqJ/HYd3oqNol5SsOA5tCfG56S6eJ0nqlnxc695OSCQl5/5haI+V47e9\n\tkQ9EZ/0fYt/GcHZs86KA4FmdzuuKOxLGmU/1TUys=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v5 0/8] rkisp1: Add manual colour temperature control", "Date": "Fri, 6 Dec 2024 15:52:20 +0100", "Message-ID": "<20241206145242.827886-1-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This series adds the ability to manually set the colour temperature\ncontrol. It is a partial resurrection of the \"libcamera: controls:\nUpdate the ColourTemperature control to be writable\" series by David\nPlowman [1], but with a implementation for the rkisp1 instead of the\nrpi.\n\nPatch 1 updates the control id documentation. Patches 2-3 implement the\ncontrol for the rkisp1. Patches 4-7 update the tuning scripts\naccordingly.\n\nThere were some discussion points in v4 that were not completely\nresolved. These circled around a more exotic use case: what happens if\nColourGains get set when AwbEnable is off. Rpi then uses the colour\ngains to estimate the colour temperature and adjust the ccm accordingly.\nThe rkisp1 implementation doesn't do that at the moment. But\nimprovements of that are in the works. So I'd suggest to merge this\nseries in, even with a slightly pipeline defined behavior. We can easily\nimprove from that point onward.\n\n\nChanges v4 -> v5:\n- Rebased on current master\n- Small fixes from review\n- Replaced Interpolator<Matrix> with Interpolator<Vector> as we now have\n a genric Vector class.\n\nChanges v1 -> v4:\n- Incremented series version to v4, because technically it is a superset of [1]\n- Fixed compile issue on patch 2\n- Fixed typos and wording in patch 1\n- Collected tags\n\nBest regards,\nStefan\n\n[1] https://patchwork.libcamera.org/project/libcamera/list/?series=4083 \n\n\nStefan Klug (8):\n libcamera: controls: Update the ColourTemperature control to be\n writable\n ipa: rkisp1: awb: Load white balance gains from tuning file\n ipa: rkisp1: awb: Implement ColourTemperature control\n libtuning: Use logging framework in ctt_awb.awb()\n libtuning: Remove the Cam object from ctt_awb.awb()\n libtuning: Fix access to color member in ctt_awb.awb()\n libtuning: Add initial AWB module\n utils: tuning: rkisp1: Replace static AWB with new AWB module\n\n src/ipa/rkisp1/algorithms/awb.cpp | 51 +++++++++++++++--\n src/ipa/rkisp1/algorithms/awb.h | 7 +++\n src/libcamera/control_ids_core.yaml | 29 +++++++++-\n utils/tuning/libtuning/ctt_awb.py | 55 ++++++++++---------\n .../tuning/libtuning/modules/awb/__init__.py | 6 ++\n utils/tuning/libtuning/modules/awb/awb.py | 36 ++++++++++++\n utils/tuning/libtuning/modules/awb/rkisp1.py | 27 +++++++++\n utils/tuning/rkisp1.py | 4 +-\n 8 files changed, 179 insertions(+), 36 deletions(-)\n create mode 100644 utils/tuning/libtuning/modules/awb/__init__.py\n create mode 100644 utils/tuning/libtuning/modules/awb/awb.py\n create mode 100644 utils/tuning/libtuning/modules/awb/rkisp1.py" }