Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/21790/?format=api
{ "id": 21790, "url": "https://patchwork.libcamera.org/api/1.1/covers/21790/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21790/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241031160741.253855-1-dan.scally@ideasonboard.com>", "date": "2024-10-31T16:07:35", "name": "[0/6] Centralise common functions in IPA modules", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/1.1/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/21790/mbox/", "series": [ { "id": 4762, "url": "https://patchwork.libcamera.org/api/1.1/series/4762/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4762", "date": "2024-10-31T16:07:35", "name": "Centralise common functions in IPA modules", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4762/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21790/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4BA7C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 31 Oct 2024 16:08:19 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A9C36653A1;\n\tThu, 31 Oct 2024 17:08:18 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CE5A60360\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 31 Oct 2024 17:08:12 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 284B29EC;\n\tThu, 31 Oct 2024 17:08:08 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZkI/fdq+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730390888;\n\tbh=eLkpBRAcnCj/Tp6Guv11DVuTx7I5lh4hjHle0fXQWnE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ZkI/fdq+zglwmiTXD4Sl51UJYS0J16xtY02sSlhMUTpQ+cnNCfCbn18mmFOlcfWn0\n\t4PcAiIsNQ17963mufHLNAQqkspY+TBrHCr2Y4kOflE75P3T01F3v4SveUQM/BggFPA\n\tr359wRfYgicL0JxeaduTRW96FfmXw2sxAE7HfPyE=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "mike.rudenko@gmail.com,\n\tDaniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH 0/6] Centralise common functions in IPA modules", "Date": "Thu, 31 Oct 2024 16:07:35 +0000", "Message-Id": "<20241031160741.253855-1-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello all\n\nThis series attempts to centralise some common things that are cropping up in\nmultiple different IPAs. A helpers file is added for functions to be defined in\nthat can be used in each IPA module so that a single common implementation is\nused across the board. Additionally the common hardcoding of default sensor\ndelay values in pipeline handlers is switched to using values from the sensor's\nCameraSensorProperties class - the values there are those from the Rpi handler\nif available, or the defaults otherwise.\n\nThanks\nDan\n\nDaniel Scally (6):\n ipa: libipa: Add miscellaneous helpers\n ipa: ipu3: Use centralised libipa helpers\n ipa: rkisp1: Use centralised libipa helpers\n ipa: rpi: Use centralised libipa helpers\n libcamera: camera_sensor_properties: Add sensor control delays\n libcamera: pipelines: Draw control delays from CameraSensor properties\n\n .../internal/camera_sensor_properties.h | 13 ++\n src/ipa/ipu3/algorithms/agc.cpp | 7 +-\n src/ipa/ipu3/algorithms/awb.cpp | 34 +---\n src/ipa/ipu3/algorithms/awb.h | 1 -\n src/ipa/libipa/helpers.cpp | 103 +++++++++++\n src/ipa/libipa/helpers.h | 23 +++\n src/ipa/libipa/meson.build | 2 +\n src/ipa/rkisp1/algorithms/awb.cpp | 20 +--\n src/ipa/rkisp1/algorithms/awb.h | 2 -\n src/ipa/rpi/controller/rpi/agc_channel.cpp | 10 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 11 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 12 +-\n src/libcamera/pipeline/simple/simple.cpp | 7 +-\n src/libcamera/property_ids_core.yaml | 25 +++\n src/libcamera/sensor/camera_sensor.cpp | 8 +\n .../sensor/camera_sensor_properties.cpp | 167 ++++++++++++++++++\n 16 files changed, 371 insertions(+), 74 deletions(-)\n create mode 100644 src/ipa/libipa/helpers.cpp\n create mode 100644 src/ipa/libipa/helpers.h" }