Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/21776/?format=api
{ "id": 21776, "url": "https://patchwork.libcamera.org/api/1.1/covers/21776/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21776/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241030164853.87586-1-jacopo.mondi@ideasonboard.com>", "date": "2024-10-30T16:48:50", "name": "[v2,0/2] libipa: Initialize FrameContext with ActiveState", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/21776/mbox/", "series": [ { "id": 4757, "url": "https://patchwork.libcamera.org/api/1.1/series/4757/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4757", "date": "2024-10-30T16:48:50", "name": "libipa: Initialize FrameContext with ActiveState", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4757/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21776/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9DB5C3292\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 30 Oct 2024 16:49:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 061BD653AD;\n\tWed, 30 Oct 2024 17:49:04 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2526665392\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 30 Oct 2024 17:49:02 +0100 (CET)", "from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7A34DB7E;\n\tWed, 30 Oct 2024 17:48:58 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eZBiRI0X\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1730306938;\n\tbh=YcoBJM3QB5Da5ljyMMAC3O9hqmrh3W/tI010wW42amM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=eZBiRI0X5bd5N6+RtmlyUvlzUuBKII/pwbO6/weQPZ55Nr9Nt1SOPLJMExqn4o9FA\n\t0IIFNIjvvWTtOxE9XU9bQqdiNMuEGmU5keIwGus4Rq6e6DRXzfGVv3PruNteLdGqjk\n\taM3a2nP8sLDeUdLltv63DCx4hpcivg/ePjrLh3Co=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>,\n\tStefan Klug <stefan.klug@ideasonboard.com>,\n\tDan Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH v2 0/2] libipa: Initialize FrameContext with ActiveState", "Date": "Wed, 30 Oct 2024 17:48:50 +0100", "Message-ID": "<20241030164853.87586-1-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This version solves the same issue that v1 did, but takes in the suggestion\nfrom Dan and Stefan to not initialize the FrameContext in the IPAFrameContext\nbut rather pass it through algorithms to let them initialize it.\n\nThis of course, only occours in case of Request underrun, where the\nFrameContext is get() before it is alloc()-ated and passed through\nalgorithm's queueRequest() that initialize it with user provided Controls.\n\nI think there's potential to rework the FCQueue to coalesce alloc() and get()\nbut that's for later.\n\nJacopo Mondi (2):\n libipa: FCQueue: Make sure FrameContext#0 is initialized\n ipa: rkisp1: Have algos initialize FrameContext\n\n src/ipa/libipa/fc_queue.cpp | 6 ++++++\n src/ipa/libipa/fc_queue.h | 26 +++++++++++++++++++++++++-\n src/ipa/rkisp1/algorithms/agc.cpp | 8 ++++++++\n src/ipa/rkisp1/algorithms/agc.h | 4 ++++\n src/ipa/rkisp1/algorithms/algorithm.h | 5 +++++\n src/ipa/rkisp1/rkisp1.cpp | 9 +++++++++\n 6 files changed, 57 insertions(+), 1 deletion(-)\n\n--\n2.47.0" }