Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/21762/?format=api
{ "id": 21762, "url": "https://patchwork.libcamera.org/api/1.1/covers/21762/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21762/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241028173659.247353-1-mike.rudenko@gmail.com>", "date": "2024-10-28T17:36:56", "name": "[RFC,0/3] Pass sensor delays from rkisp1 IPA to the pipeline handler", "submitter": { "id": 146, "url": "https://patchwork.libcamera.org/api/1.1/people/146/?format=api", "name": "Mikhail Rudenko", "email": "mike.rudenko@gmail.com" }, "mbox": "https://patchwork.libcamera.org/cover/21762/mbox/", "series": [ { "id": 4750, "url": "https://patchwork.libcamera.org/api/1.1/series/4750/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4750", "date": "2024-10-28T17:36:56", "name": "Pass sensor delays from rkisp1 IPA to the pipeline handler", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4750/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21762/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A348C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Oct 2024 17:37:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D001965397;\n\tMon, 28 Oct 2024 18:37:11 +0100 (CET)", "from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7ADA560367\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2024 18:37:09 +0100 (CET)", "by mail-lj1-x22b.google.com with SMTP id\n\t38308e7fff4ca-2fb51e00c05so66527691fa.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Oct 2024 10:37:09 -0700 (PDT)", "from localhost.localdomain ([45.12.135.46])\n\tby smtp.gmail.com with ESMTPSA id\n\t38308e7fff4ca-2fcb453e3afsm12115511fa.57.2024.10.28.10.37.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 28 Oct 2024 10:37:06 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"XHVDggQu\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1730137028; x=1730741828;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=93z42zaSU+dq+5VHHDSN/9/IGXucBRv7VWpzUJTaxgE=;\n\tb=XHVDggQu4WN9FFxVem0d2qsB6EPhFnYYlTIKoyEB0i1xhoMgNk9qaz3LTyCh4+BF8H\n\tYQiohvxtGPkleptDqqdk4XIRYcNxfEh07EsbP44GCVNsbStDbPViEFKuDv6H2NZ2iXbP\n\tRlso3+T4sLZpo4zDR0Qs7qMp2WBKnIwlhfYsEvPrYgpa4WxAQTZg7JLNORNF5vIH1pGt\n\tpZ8IRtGjw07nPydH8RbwTWBrxMZ/PpdLZhEyH9sEM+gSDyOvWhdOvTfrHdKZFfGD0aoV\n\t1e92TqBYETgpnqrcAupaX4R1aaQqYuu4hfc1J81Et5aEQxc3vD6ZbWEcjIGw/JgiPqg2\n\tORbQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1730137028; x=1730741828;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=93z42zaSU+dq+5VHHDSN/9/IGXucBRv7VWpzUJTaxgE=;\n\tb=wcmwoRukYlV+B9M0ZMvPzxzzUWorrekaShIZihsWaIBusxd2AwCp5iCCAH9ea6LYUa\n\tHz4g30HKAOe2tl+1zUvevyHtwaIDoSWqKTm0b54mq/r7kWKeOEYoeUrRYZEJ5xuwrTzF\n\tGpiHKwH5h569PShS0f/y+y66Gg0PD0rv0A1AMEr2O57BuC1CvDQN7mzym8v2U1NMGg8G\n\twAsA/z+BH6bO6+IaGLO9HRiFLvKvsU0ZC+a/krIEcCgfZI+RVKu7LLaTamCx1fcHO1LN\n\tChjJW44l9QaU+lyw48+Edi8zVzz3ARgjOpv+bWeHeJkqmc+urClcG2Y0YwC6Mi6/wwFX\n\tzxOQ==", "X-Gm-Message-State": "AOJu0Ywrbvy0vR+L0I5RN45K9Snu6SpfFf2xfUAmBxkt5Ajj/Y94at0a\n\t9WQO5+pqKQQ+88LQvS5j9AfwrG8q/sbwEvKcFc5+duS4GEO36DWXu2pbhUF9igI=", "X-Google-Smtp-Source": "AGHT+IF6WRkaTpsU2Uv4R+vOGcoQFsl1vgktACT6KsrnEVpAHMRzUV4z0caULWaeei9V6l1ROfqkMg==", "X-Received": "by 2002:a2e:9b81:0:b0:2f3:f1ee:2256 with SMTP id\n\t38308e7fff4ca-2fcbe0a359bmr53165421fa.44.1730137027570; \n\tMon, 28 Oct 2024 10:37:07 -0700 (PDT)", "From": "Mikhail Rudenko <mike.rudenko@gmail.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tMikhail Rudenko <mike.rudenko@gmail.com>", "Subject": "[PATCH RFC 0/3] Pass sensor delays from rkisp1 IPA to the pipeline\n\thandler", "Date": "Mon, 28 Oct 2024 20:36:56 +0300", "Message-ID": "<20241028173659.247353-1-mike.rudenko@gmail.com>", "X-Mailer": "git-send-email 2.46.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi,\n\nAt present, rkisp1 uses hardcoded sensor control delays. In the case\nwhen they do not match real sensor delays, the AGC algorithm operates\nin a suboptimal mode, leading to gain/exposure oscillations on capture\nstart and slower convergence.\n\nThis series does 3 things to fix this situation. First, it adds an IPC\nstructure for sensor control delays. Second, it adds sensorDelays()\nmethod to the CameraSensorHelper and overrides it where\nsensor-specific delays are known. And finally, it replaces hardcoded\ndelays in rkisp1 pipeline handler with those obtained from the\nCameraSensorHelper via IPA.\n\nI'm not completely sure this is the best solution from the\narchitecture viewpoint, thus \"RFC\". Any feedback is welcome!\n\nMikhail Rudenko (3):\n ipa: core: add IPASensorDelays structure\n libcamera: libipa: camera_sensor: Add sensorDelays method\n ipa: rkisp1: Pass sensor delays from IPA to pipeline handler\n\n include/libcamera/ipa/core.mojom | 35 ++++++++++++++\n include/libcamera/ipa/rkisp1.mojom | 3 +-\n src/ipa/libipa/camera_sensor_helper.cpp | 59 ++++++++++++++++++++++++\n src/ipa/libipa/camera_sensor_helper.h | 5 ++\n src/ipa/rkisp1/rkisp1.cpp | 8 +++-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 27 +++++------\n 6 files changed, 118 insertions(+), 19 deletions(-)\n\n--\n2.46.0" }