Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/21617/?format=api
{ "id": 21617, "url": "https://patchwork.libcamera.org/api/1.1/covers/21617/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21617/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20241014140038.1133270-1-chenghaoyang@chromium.org>", "date": "2024-10-14T13:18:55", "name": "[0/2] Add GyroSensor", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "mbox": "https://patchwork.libcamera.org/cover/21617/mbox/", "series": [ { "id": 4696, "url": "https://patchwork.libcamera.org/api/1.1/series/4696/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4696", "date": "2024-10-14T13:18:55", "name": "Add GyroSensor", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4696/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21617/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6B69EC326C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 14 Oct 2024 14:00:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5C0763525;\n\tMon, 14 Oct 2024 16:00:47 +0200 (CEST)", "from mail-pg1-x536.google.com (mail-pg1-x536.google.com\n\t[IPv6:2607:f8b0:4864:20::536])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A73AC63525\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Oct 2024 16:00:45 +0200 (CEST)", "by mail-pg1-x536.google.com with SMTP id\n\t41be03b00d2f7-7d4fa972cbeso3158042a12.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 14 Oct 2024 07:00:45 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(199.211.81.34.bc.googleusercontent.com. [34.81.211.199])\n\tby smtp.gmail.com with ESMTPSA id\n\t98e67ed59e1d1-2e2bb093837sm10459215a91.4.2024.10.14.07.00.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 14 Oct 2024 07:00:43 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"dBsMjpeM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1728914443; x=1729519243;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=YpPAupMCwb67uv2mohiOcEk9PrNgzgo61Jpr8r/uvII=;\n\tb=dBsMjpeMWlQ+oEnxIZSaoDKHf6vhOnJozb7nX2dQXH/LBaDJPQBrdqBy3YDuuTnWJV\n\tNzdTetUSz6laL7CU7SiQtMlKr6elBGMw432GIyrwVB4b4DdtJNto6Zppvc0oEP7LgeYv\n\tXNkhQ9U7/vyKxlrC6ddbzIS/q69MFPEupVb1Q=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1728914443; x=1729519243;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=YpPAupMCwb67uv2mohiOcEk9PrNgzgo61Jpr8r/uvII=;\n\tb=YEKSmT5/CbokKq6w+J/OcS+okG4ADjCPhIY40L3eZNhJazGeykRldN5/ZuxgtuED8a\n\tn9RhUtZ3nybdyjB0c9z8AaddOmQZGLLOGNWdbkMJ+5duQT/hgeTMQ7yPCqsZAbKh9kcV\n\t3q0W/L/gh8DnTeDeawzjej9XaQxOYln0KmtjOF1eUAj+WnS1LjxEGoJ32BKmVXBFsNDh\n\tgpjA69eugoCDd6LqDUT2rudQOtY+Xjo4yY+R6S7hCixWEiagy9PEXgkuNINB2oSw668z\n\t2DsJ8wi5/4TwBQ5uxE1AQSSKx8KEqdVo07NCTpSaKlKTbVC6kA+xkPBDj69MYkq7EjL1\n\tsdFQ==", "X-Gm-Message-State": "AOJu0YxVatoH9QxtrCYbmXJrHS7A55b/0wfYQT0af17P0pPBBt7Db7WX\n\tZsYJLdF7zAgg5tYkwGzZiB7d6VbKyHgFBKkMQf0hoj2stVyKFWbBZZksF3j53KCrZPJQEPY6M9I\n\t=", "X-Google-Smtp-Source": "AGHT+IHUUJh/GCjvVajs00tbydBpCId/Z77nx2weTbDq7i66N7zk3f3Zt3DBWvaq6y6CJ+AawXb8fA==", "X-Received": "by 2002:a05:6a21:9688:b0:1cf:5643:459a with SMTP id\n\tadf61e73a8af0-1d8bcfc0d18mr16692230637.43.1728914443567; \n\tMon, 14 Oct 2024 07:00:43 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Subject": "[PATCH 0/2] Add GyroSensor", "Date": "Mon, 14 Oct 2024 13:18:55 +0000", "Message-ID": "<20241014140038.1133270-1-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.47.0.rc1.288.g06298d1525-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi folks,\n\nThis series of patches adds GyroSensor as a core library class, and a\nCrOS implementation that provides gyroscope sensor data via\nCameraMojoChannelManagerToken and SensorHalClient APIs.\n\nI believe it's controversial. The reason that the gyro sensor sample\nmight not be one of the control ids is that applications will pre-queue\ncapture requests, and they might delay some capture requests due to lack\nof buffers or other issues in the upper layers. Counting on capture\nrequests to deliver real-time gyroscope sensor samples isn't a good\nidea.\n\nThis passes gitlab pipeline:\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1289676\n\nPlease let me know your concerns and other possible approaches. Thanks!\n\nBR,\nHarvey\n\n\nHarvey Yang (2):\n libcamera: android: include token only in cros_mojo_token.h\n libcamera: Add GyroSensor as a base class\n\n include/libcamera/internal/gyro_sensor.h | 65 ++++++++\n src/android/cros_mojo_token.h | 2 +-\n src/libcamera/cros_gyro_sensor.cpp | 179 +++++++++++++++++++++++\n src/libcamera/gyro_sensor.cpp | 82 +++++++++++\n src/libcamera/meson.build | 8 +\n 5 files changed, 335 insertions(+), 1 deletion(-)\n create mode 100644 include/libcamera/internal/gyro_sensor.h\n create mode 100644 src/libcamera/cros_gyro_sensor.cpp\n create mode 100644 src/libcamera/gyro_sensor.cpp" }