Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/21414/?format=api
{ "id": 21414, "url": "https://patchwork.libcamera.org/api/1.1/covers/21414/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21414/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240930063342.3014837-1-chenghaoyang@google.com>", "date": "2024-09-30T06:29:41", "name": "[v14,0/7] Add VirtualPipelineHandler", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "mbox": "https://patchwork.libcamera.org/cover/21414/mbox/", "series": [ { "id": 4637, "url": "https://patchwork.libcamera.org/api/1.1/series/4637/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4637", "date": "2024-09-30T06:29:41", "name": "Add VirtualPipelineHandler", "version": 14, "mbox": "https://patchwork.libcamera.org/series/4637/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21414/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BF11C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 Sep 2024 06:33:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9255E63515;\n\tMon, 30 Sep 2024 08:33:51 +0200 (CEST)", "from mail-pf1-x429.google.com (mail-pf1-x429.google.com\n\t[IPv6:2607:f8b0:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B958C62C92\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Sep 2024 08:33:49 +0200 (CEST)", "by mail-pf1-x429.google.com with SMTP id\n\td2e1a72fcca58-71c63a43146so1529772b3a.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 29 Sep 2024 23:33:49 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(208.158.221.35.bc.googleusercontent.com. [35.221.158.208])\n\tby smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-71b265166e2sm5487671b3a.131.2024.09.29.23.33.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 29 Sep 2024 23:33:47 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"VigbRXi/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1727678027; x=1728282827;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=BRFciN5MTGCPfB2m9Ji2X4HzUrjkq5yv8a3rb4YGPmE=;\n\tb=VigbRXi/uDvCW8XAzEW2sxtvzBmGQ5dk3FVUIvXlTUfj9mwV0sYUplBfQZdyIUXC3g\n\t1kaS3npWwHHags1gY2aP7PjYBcG+d3y/AcFQAjMnR7PK/4x8O1frL1Kt9S4mniAZ3U14\n\tPmm4t6OWRGXxFNI5OjD9EeisBNqxG3zl38wKo=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727678027; x=1728282827;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=BRFciN5MTGCPfB2m9Ji2X4HzUrjkq5yv8a3rb4YGPmE=;\n\tb=IF2JhW/sBoUSfMZfB6XPSVHj8uDfKCe00zm+Z4o7Gt7DZci7ecuywJIN3I+ogMsxIw\n\tqsfiMTU8+s/kVCk7ZXJoCSjgLiPPZbaFbxNQv/8z4xhNAY/vPuSBoiRnqG4gezdgPkVe\n\tHQrrVjcS08OJfzMtKE8ddN6m6CiM7v51r8HAKUXUrqIxlte/+WG5CpnyqGdu0mnkCDag\n\tGNt/6IFrd4iphtoAQtthGt06VSvKKZUkTsFEBZOJQLFX9eWVivmKi+Q8aXRb+S588MZ9\n\tKqCKkFNaLKAnhaHN2eXgkwBP85r7dUVHhFpFK/CFoAuXCWDiTp5Wik8IYiUVrDrcc3DK\n\tK1Dg==", "X-Gm-Message-State": "AOJu0YzemWiGs9iYAvyEr9wP6IUE76ePXzsBK9B0HJnc916/Gwb+pqB9\n\tBINELSns2U0F8ORUGw7jPFzEmqCoHm5Brar3EiBFuQTbl5Qq+eSCBCBZ/FE/iTjOoGFTIvGKoGM\n\t=", "X-Google-Smtp-Source": "AGHT+IHN9G4pQO8b3Sl+KGm9MU+ar7MSjBO89HoSvqfGNYWHcQJRlfdpQ4YR5XbSsZ6o6gtpsDwXkQ==", "X-Received": "by 2002:a05:6a21:3416:b0:1d5:119d:6299 with SMTP id\n\tadf61e73a8af0-1d5119d636emr7107319637.28.1727678027544; \n\tSun, 29 Sep 2024 23:33:47 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>", "Subject": "[PATCH v14 0/7] Add VirtualPipelineHandler", "Date": "Mon, 30 Sep 2024 06:29:41 +0000", "Message-ID": "<20240930063342.3014837-1-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.46.1.824.gd892dcdcdd-goog", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi all,\n\nThis series adds virtual pipeline handler, which doesn't depend on any\nhardware, like camera sensor or ISP. Currently the configuration\nsupports test patterns and images.\n\nIt passed the gitlab pipeline:\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1280687\n\nI've also checked that it works on qcam.\n\nI failed to pass multi_stream_test when trying to enable multiple\nstreams though. Please give me some hints what it tests and what I\nmissed:\n```\n[295:43:43.910237144] [1441841] INFO IPAManager ipa_manager.cpp:137 libcamera is not installed. Adding '/usr/local/google/home/chenghaoyang/Workspace/libca\nmera/build/src/ipa' to the IPA search path\n[295:43:43.914030564] [1441841] INFO Camera camera_manager.cpp:325 libcamera v0.3.1+79-8ca4f033-dirty (2024-08-29T19:18:51UTC)\n[295:43:43.915493754] [1441844] ERROR DmaBufAllocator dma_buf_allocator.cpp:120 Could not open any dma-buf provider\n[295:43:43.919118835] [1441841] INFO IPAManager ipa_manager.cpp:137 libcamera is not installed. Adding '/usr/local/google/home/chenghaoyang/Workspace/libca\nmera/build/src/ipa' to the IPA search path\n[295:43:43.922245825] [1441841] INFO Camera camera_manager.cpp:325 libcamera v0.3.1+79-8ca4f033-dirty (2024-08-29T19:18:51UTC)\n[295:43:43.922820175] [1441846] ERROR DmaBufAllocator dma_buf_allocator.cpp:120 Could not open any dma-buf provider\nUnable to set the pipeline to the playing state.\n```\n\nGitlab pipeline failure:\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1260412\n\nUpdates in v14:\n- Refactored ImageFrames to keep a list of filepaths directly.\n\nUpdates in v13:\n- Returned an errno in `FrameGenerete::generateFrame()`\n\nUpdates in v12:\n- Added ImageFrameGenerator first, then add Parser.\n- Removed ScaleMode argument, as only Fill is supported now.\n- Fixed bug of Stream's configuration usage in configure().\n\nUpdates in v11:\n- Allowed a single value in the config file's frame_rates field.\n\nUpdates in v10:\nApply fixes according to Jacopo's and Barnabás' comments.\n- Split test_pattern and path fields in the yaml format.\n- Let FrameGenerators control frameCount_.\n- Fixed match() returning values.\n\nUpdates in v9: Allocate contiguous memory for planes in the same\nFrameBuffer.\n\nBR,\nHarvey\n\nHarvey Yang (6):\n libcamera: add DmaBufAllocator::exportBuffers()\n libcamera: Remove PipelineHandler Fatal check of non-empty\n MediaDevices\n libcamera: virtual: Add VirtualPipelineHandler\n libcamera: virtual: Add ImageFrameGenerator\n libcamera: virtual: Read config and register cameras based on the\n config\n libcamera: software_isp: Refactor SoftwareIsp to use\n DmaBufAllocator::exportBuffers\n\nKonami Shu (1):\n libcamera: pipeline: Add test pattern for VirtualPipelineHandler\n\n .../libcamera/internal/dma_buf_allocator.h | 13 +\n meson.build | 1 +\n meson_options.txt | 3 +-\n src/android/meson.build | 19 -\n src/libcamera/dma_buf_allocator.cpp | 57 +++\n src/libcamera/pipeline/virtual/README.md | 48 +++\n .../pipeline/virtual/data/virtual.yaml | 36 ++\n .../pipeline/virtual/frame_generator.h | 29 ++\n .../virtual/image_frame_generator.cpp | 169 ++++++++\n .../pipeline/virtual/image_frame_generator.h | 50 +++\n src/libcamera/pipeline/virtual/meson.build | 13 +\n src/libcamera/pipeline/virtual/parser.cpp | 260 ++++++++++++\n src/libcamera/pipeline/virtual/parser.h | 39 ++\n .../virtual/test_pattern_generator.cpp | 137 +++++++\n .../pipeline/virtual/test_pattern_generator.h | 53 +++\n src/libcamera/pipeline/virtual/virtual.cpp | 382 ++++++++++++++++++\n src/libcamera/pipeline/virtual/virtual.h | 61 +++\n src/libcamera/pipeline_handler.cpp | 11 +-\n src/libcamera/software_isp/software_isp.cpp | 20 +-\n src/meson.build | 19 +\n 20 files changed, 1378 insertions(+), 42 deletions(-)\n create mode 100644 src/libcamera/pipeline/virtual/README.md\n create mode 100644 src/libcamera/pipeline/virtual/data/virtual.yaml\n create mode 100644 src/libcamera/pipeline/virtual/frame_generator.h\n create mode 100644 src/libcamera/pipeline/virtual/image_frame_generator.cpp\n create mode 100644 src/libcamera/pipeline/virtual/image_frame_generator.h\n create mode 100644 src/libcamera/pipeline/virtual/meson.build\n create mode 100644 src/libcamera/pipeline/virtual/parser.cpp\n create mode 100644 src/libcamera/pipeline/virtual/parser.h\n create mode 100644 src/libcamera/pipeline/virtual/test_pattern_generator.cpp\n create mode 100644 src/libcamera/pipeline/virtual/test_pattern_generator.h\n create mode 100644 src/libcamera/pipeline/virtual/virtual.cpp\n create mode 100644 src/libcamera/pipeline/virtual/virtual.h" }