Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/21342/?format=api
{ "id": 21342, "url": "https://patchwork.libcamera.org/api/1.1/covers/21342/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21342/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240924110353.2025397-1-chenghaoyang@google.com>", "date": "2024-09-24T11:02:43", "name": "[v7,0/3] Add Face Detection Controls", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "mbox": "https://patchwork.libcamera.org/cover/21342/mbox/", "series": [ { "id": 4618, "url": "https://patchwork.libcamera.org/api/1.1/series/4618/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4618", "date": "2024-09-24T11:02:43", "name": "Add Face Detection Controls", "version": 7, "mbox": "https://patchwork.libcamera.org/series/4618/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21342/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 13575C0F1B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 24 Sep 2024 11:04:04 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01FE963510;\n\tTue, 24 Sep 2024 13:04:02 +0200 (CEST)", "from mail-pf1-x434.google.com (mail-pf1-x434.google.com\n\t[IPv6:2607:f8b0:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 785E863500\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Sep 2024 13:04:00 +0200 (CEST)", "by mail-pf1-x434.google.com with SMTP id\n\td2e1a72fcca58-71971d20a95so3682189b3a.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 24 Sep 2024 04:04:00 -0700 (PDT)", "from chenghaoyang-low.c.googlers.com.com\n\t(208.158.221.35.bc.googleusercontent.com. [35.221.158.208])\n\tby smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-71afc9833c3sm993326b3a.182.2024.09.24.04.03.57\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 24 Sep 2024 04:03:58 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"Zk3AFWxV\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=chromium.org; s=google; t=1727175838; x=1727780638;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=pilcf9aNKRLy8d6JiUspRF8gMb/GojilYehEApJVc00=;\n\tb=Zk3AFWxVk9Q7qG1rvFe/fupgSIqpCS40PPtEwklceMdIWMDB6tJMbFcS2bnj2QHUAz\n\tLe9pwXWxipz6KrjIJrzRlRkM5QIQLUYqYaYh84Xyj/uLZAkAEEi5yKwBaZHDBvT2vvMw\n\t7mt3EEy6vk2ahfYL/sfFaObg3T8jlQoeE/KxA=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1727175838; x=1727780638;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=pilcf9aNKRLy8d6JiUspRF8gMb/GojilYehEApJVc00=;\n\tb=pkwI1EA+52H4ATtFgG4xpQeQgH8gyl+Ve+HNG24pei8t8OFuLI3TVNYaaEOUBcTCx2\n\tgUazAJhRYtbIpmX4ofMJQOMudz7WPvb7jEwAlpn4km1dLtm3EknM/lYC0ngO199YUJC2\n\tRX4jFnyltqRTDk59m29TYmeF+/Q+njM5y/HKs1YXUF4nhIctL8wqOLjB1K3sCPOFYZed\n\tzkFzeh8Tu1EIhZE/6sPTDGpqk8RnqQrUMefSYItezA70dgADTpBTw03KAP8LDSf3COF5\n\t6fQjv/V9AnglENxMH1B0V4TQaXcRpomxQT/LuKymF8TUxc/n2v32PXnFwH5stAfP1HRx\n\t/Kmw==", "X-Gm-Message-State": "AOJu0YzDJvY+0Yb8HfPdUgbqJl9x3DalA1mMBOgQv+DT0+657tSsKi6M\n\tatv7oBmVLbrs3Uq5SRZRu5F2esSM9kTrLzUz0zA0PewUpk3oWGQTDo2Bvjs31BiEv9tMWWd1Wm4\n\t=", "X-Google-Smtp-Source": "AGHT+IF3daJfK2F6NbeZaka38R4Atmm2xfV7hdsKuG+lYiwCNl7QV0O3pZW+R0A/VzwKNjBNp8dIZA==", "X-Received": "by 2002:a05:6a21:9208:b0:1cf:5c1d:83dd with SMTP id\n\tadf61e73a8af0-1d30a92688dmr21442956637.2.1727175838629; \n\tTue, 24 Sep 2024 04:03:58 -0700 (PDT)", "From": "Harvey Yang <chenghaoyang@chromium.org>", "X-Google-Original-From": "Harvey Yang <chenghaoyang@google.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Harvey Yang <chenghaoyang@google.com>", "Subject": "[PATCH v7 0/3] Add Face Detection Controls", "Date": "Tue, 24 Sep 2024 11:02:43 +0000", "Message-ID": "<20240924110353.2025397-1-chenghaoyang@google.com>", "X-Mailer": "git-send-email 2.46.0.792.g87dc391469-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi folks,\n\nThis series of patches adds face detection controls in the control ids,\nthe corresponding usages, and a c'tor of libcamera::Rectangle to\nconstruct it easiler with face detection results.\n\nIt passed gitlab pipeline checks:\nhttps://gitlab.freedesktop.org/chenghaoyang/libcamera/-/pipelines/1276999\n\nThis is one of the series cherry-picked from cros mtkisp7 branch.\n\nThe corresponding CLs in cros are:\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741266\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/4741267\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669229\nhttps://chromium-review.googlesource.com/c/chromiumos/third_party/libcamera/+/5669232\n\nThe usages in pipeline handler mtkisp7 will be added later.\n\nThe checkstyle's suggestion on the second patch is ignored, as it\nchanges the style of previous code.\n\nv7: Fixed comments.\n\nv6:\n- Added control_ids_android as the new control id list.\n - Moved the new control ids there, instead of in draft.\n\nv5:\n- Rewrote Rectangle's c'tor that allows any two diagonal points.\n - Added unit tests.\n\nv4:\n- Added support of FaceDetectModeFull and FaceDetectFaceIds.\n- Fixed descriptions of control sizes.\n\nv3: Applied fixes according to Jacopo's comments.\n- Moved the new face detection controls from core to draft.\n- Amended new controls' descriptions.\n\nv2:\n- Squashed the fourth CL into the last patch, as it's a fix.\n- Fixed CLs based on checkstyle's suggestions.\n\nHarvey Yang (1):\n libcamera: android: Add face detection control support\n\nYudhistira Erlandinata (2):\n libcamera: Add rectangle two-point constructor\n libcamera: Add face detection controls\n\n include/libcamera/controls.h | 6 ++\n include/libcamera/geometry.h | 7 ++\n include/libcamera/meson.build | 3 +-\n src/android/camera_capabilities.cpp | 45 ++++++++++--\n src/android/camera_device.cpp | 73 ++++++++++++++++++-\n src/libcamera/control_ids_android.yaml | 98 ++++++++++++++++++++++++++\n src/libcamera/control_ranges.yaml | 4 +-\n src/libcamera/controls.cpp | 6 ++\n src/libcamera/geometry.cpp | 7 ++\n test/geometry.cpp | 14 ++++\n 10 files changed, 255 insertions(+), 8 deletions(-)\n create mode 100644 src/libcamera/control_ids_android.yaml" }