Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/21032/?format=api
{ "id": 21032, "url": "https://patchwork.libcamera.org/api/1.1/covers/21032/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21032/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240827014044.24673-1-laurent.pinchart@ideasonboard.com>", "date": "2024-08-27T01:40:34", "name": "[v4,0/9] rkisp1: Support BLS on i.MX8MP", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/21032/mbox/", "series": [ { "id": 4544, "url": "https://patchwork.libcamera.org/api/1.1/series/4544/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4544", "date": "2024-08-27T01:40:34", "name": "rkisp1: Support BLS on i.MX8MP", "version": 4, "mbox": "https://patchwork.libcamera.org/series/4544/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21032/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAA0AC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 27 Aug 2024 01:40:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7388E63422;\n\tTue, 27 Aug 2024 03:40:50 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1AD8B61E4F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Aug 2024 03:40:48 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 32F27B0B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 Aug 2024 03:39:41 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ghHWuiXs\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724722781;\n\tbh=nEOs8yZYnK9reCESbBeyFakY6pJZXUBdM3KCg6ToPes=;\n\th=From:To:Subject:Date:From;\n\tb=ghHWuiXs28ZtUg0Zr+VbPXIvhnTI5fZoS2D1m5T3KVj9twMOaODrzoomFfAFkl3od\n\t/L9Lj+qO4lWyliEIq3Iz33y8L0Kq9Skn2WRh2s+vp+m6hfF9ANiBbvrqQdzxB52Ksu\n\tnnsJkUl69HMfSpXIcTYyrlRl7DyWQX/lmr26HxCc=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v4 0/9] rkisp1: Support BLS on i.MX8MP", "Date": "Tue, 27 Aug 2024 04:40:34 +0300", "Message-ID": "<20240827014044.24673-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis patch series adds support for black level subtraction to the\nrkisp1 on i.MX8MP. While the rkisp1 IPA already supports black level\nsubtraction, the i.MX8MP lacks the BLS block in the ISP and instead\nimplements black level substraction in a new block named companding.\nSupport for this block has been submitted for the kernel driver in [1]\nand [2], which have been merged in the stage tree master branch.\n\nThe first part of this series adds support in the rkisp1 pipeline\nhandler and IPA module for the new ISP extensible parameters format\nintroduced in [1]. The first patch starts by updating the kernel headers\nto the new API. The next two patches then prepare the rkisp1 IPA module\ninterface to pass the parameters buffer format from the pipeline handler\nto the IPA module (2/9), and the size of the filled buffer from the IPA\nmodule to the pipeline handler (3/9). With that in place, patch 4/9 adds\nclasses that abstract the ISP parameters buffer in order to support the\nlegacy fixed format and the new extensible format transparently for the\nIPA module's algorithms, and patch 5/9 makes use of those classes\nthrough the IPA module. Patch 6/9 finishes the first part by switching\nto the extensible format by default when available.\n\nThe second part of the series then implements support for BLS on the\ni.MX8MP. Patch 7/9 updates the rkisp1 parameters helper classes with\nsupport for the companding block. Patch 8/9 adds a flag to the IPA\ncontext to signal support for the companding block, and patch 9/9 makes\nuse of it in the black level correction algorithm to select between the\nBLS and companding blocks depending on the platform.\n\nCompared to previous versions, the main changes are the update to the\nAPI that has been merged upstream, and tested support for backward\ncompatibility with older kernels. Please see individual change logs for\ndetails.\n\n[1] https://lore.kernel.org/r/20240703161048.247124-1-jacopo.mondi@ideasonboard.com\n[2] https://lore.kernel.org/r/20240704154932.6686-1-laurent.pinchart@ideasonboard.com\n\nJacopo Mondi (3):\n include: linux: Update headers for rkisp1 extensible parameters\n ipa: rkisp1: Pass parameters buffer size to pipeline handler\n pipeline: rkisp1: Use the extensible parameters format\n\nLaurent Pinchart (4):\n ipa: rkisp1: Pass parameters buffer format to IPA module\n ipa: rkisp1: Add ISP parameters abstraction class\n ipa: rkisp1: Use the new ISP parameters abstraction\n ipa: rkisp1: params: Add companding blocks\n\nPaul Elder (2):\n ipa: rkisp1: Add compand feature flag to ipa context\n ipa: rkisp1: blc: Add support for BLS in compand\n\n include/libcamera/ipa/rkisp1.mojom | 3 +-\n include/linux/README | 2 +-\n include/linux/dma-heap.h | 2 +-\n include/linux/drm_fourcc.h | 18 +\n include/linux/rkisp1-config.h | 578 +++++++++++++++++++++++\n include/linux/v4l2-controls.h | 2 +\n include/linux/videodev2.h | 5 +-\n src/ipa/rkisp1/algorithms/agc.cpp | 48 +-\n src/ipa/rkisp1/algorithms/agc.h | 2 +-\n src/ipa/rkisp1/algorithms/awb.cpp | 62 +--\n src/ipa/rkisp1/algorithms/awb.h | 2 +-\n src/ipa/rkisp1/algorithms/blc.cpp | 60 ++-\n src/ipa/rkisp1/algorithms/blc.h | 8 +-\n src/ipa/rkisp1/algorithms/ccm.cpp | 15 +-\n src/ipa/rkisp1/algorithms/ccm.h | 4 +-\n src/ipa/rkisp1/algorithms/cproc.cpp | 14 +-\n src/ipa/rkisp1/algorithms/cproc.h | 2 +-\n src/ipa/rkisp1/algorithms/dpcc.cpp | 10 +-\n src/ipa/rkisp1/algorithms/dpcc.h | 2 +-\n src/ipa/rkisp1/algorithms/dpf.cpp | 27 +-\n src/ipa/rkisp1/algorithms/dpf.h | 2 +-\n src/ipa/rkisp1/algorithms/filter.cpp | 52 +-\n src/ipa/rkisp1/algorithms/filter.h | 2 +-\n src/ipa/rkisp1/algorithms/goc.cpp | 17 +-\n src/ipa/rkisp1/algorithms/goc.h | 2 +-\n src/ipa/rkisp1/algorithms/gsl.cpp | 20 +-\n src/ipa/rkisp1/algorithms/gsl.h | 2 +-\n src/ipa/rkisp1/algorithms/lsc.cpp | 29 +-\n src/ipa/rkisp1/algorithms/lsc.h | 4 +-\n src/ipa/rkisp1/ipa_context.cpp | 5 +\n src/ipa/rkisp1/ipa_context.h | 2 +\n src/ipa/rkisp1/meson.build | 1 +\n src/ipa/rkisp1/module.h | 3 +-\n src/ipa/rkisp1/params.cpp | 222 +++++++++\n src/ipa/rkisp1/params.h | 163 +++++++\n src/ipa/rkisp1/rkisp1.cpp | 29 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 +-\n 37 files changed, 1221 insertions(+), 210 deletions(-)\n create mode 100644 src/ipa/rkisp1/params.cpp\n create mode 100644 src/ipa/rkisp1/params.h\n\n\nbase-commit: 874b63d5cb3f772d361ce891721e7580b09dd378" }