Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/21019/?format=api
{ "id": 21019, "url": "https://patchwork.libcamera.org/api/1.1/covers/21019/?format=api", "web_url": "https://patchwork.libcamera.org/cover/21019/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240826161709.524293-1-jacopo.mondi@ideasonboard.com>", "date": "2024-08-26T16:16:59", "name": "[v3,0/9] rkisp1: Support BLS on i.MX8MP", "submitter": { "id": 143, "url": "https://patchwork.libcamera.org/api/1.1/people/143/?format=api", "name": "Jacopo Mondi", "email": "jacopo.mondi@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/21019/mbox/", "series": [ { "id": 4541, "url": "https://patchwork.libcamera.org/api/1.1/series/4541/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4541", "date": "2024-08-26T16:16:59", "name": "rkisp1: Support BLS on i.MX8MP", "version": 3, "mbox": "https://patchwork.libcamera.org/series/4541/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/21019/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1516C324C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 Aug 2024 16:17:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BC6363418;\n\tMon, 26 Aug 2024 18:17:19 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3502B6190C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Aug 2024 18:17:17 +0200 (CEST)", "from ideasonboard.com (mob-5-90-142-90.net.vodafone.it\n\t[5.90.142.90])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66247480;\n\tMon, 26 Aug 2024 18:16:10 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"O9MkC2TP\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1724688970;\n\tbh=5EIcVfxjemSjyIRvw829KQOk43kD5eIhPf5nfBw0524=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=O9MkC2TPrN6eK42O/mxl9V0gJToPBoOsKQJcd207URGMBavm9Dm7G4N+Jc2nxzk/8\n\t4Iitab9Q/Al+W5Drjqii82NsLIjzT+puBgLqeWK6nfsZFAAlLx7YWUugqbdqiRX8tW\n\tAuKhHBDuvkMs4rJDC9gBgoqgIhe9Zq2RT2mCvOp4=", "From": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v3 0/9] rkisp1: Support BLS on i.MX8MP", "Date": "Mon, 26 Aug 2024 18:16:59 +0200", "Message-ID": "<20240826161709.524293-1-jacopo.mondi@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The series was sent by Laurent as\n[PATCH v2 00/11] rkisp1: Support BLS on i.MX8MP\nbut it's actually more than BLS.\n\nNow that support for extensible parameters has been merged in linux-media\nstaging tree, we can update libcamera to make use of them when available.\n\nBelow, the original cover letter from Laurent\n\n-------------------------------------------------------------------------------\nThis patch series adds support for black level subtraction to the\nrkisp1 on i.MX8MP. While the rkisp1 IPA already supports black level\nsubtraction, the i.MX8MP lacks the BLS block in the ISP and instead\nimplements black level substraction in a new block named companding.\nSupport for this block has been submitted for the kernel driver in [1]\nand [2], which this series depends on.\n\nThe first part of this series adds support in the rkisp1 pipeline\nhandler and IPA module for the new ISP extensible parameters format\nintroduced in [1]. The first two patches start by adding the driver API\nextensions to the rkisp1-config.h header (01/11) and the new V4L2 pixel\nformat (02/11). The next two patches then prepare the rkisp1 IPA module\ninterface to pass the parameters buffer format from the pipeline handler\nto the IPA module (03/11), and the size of the filled buffer from the\nIPA module to the pipeline handler (04/11). With that in place, patch\n05/11 adds classes that abstract the ISP parameters buffer in order to\nsupport the legacy fixed format and the new extensible format\ntransparently for the IPA module's algorithms, and patch 06/11 makes use\nof those classes through the IPA module. Patch 07/11 finishes the first\npart by switching to the extensible format by default when available.\n\nThe second part of the series then implements support for BLS on the\ni.MX8MP. Patch 08/11 updates the rkisp1-config.h header to the kernel\nAPI from [2] with support for the companding block, and patch 09/11\nupdates the rkisp1 parameters helper classes with support for the block.\nPatch 10/11 adds a flag to the IPA context to signal support for the\ncompanding block, and patch 11/11 makes use of it in the black level\ncorrection algorithm to select between the BLS and companding blocks\ndepending on the platform.\n\n[1] https://lore.kernel.org/r/20240703161048.247124-1-jacopo.mondi@ideasonboard.com\n[2] https://lore.kernel.org/r/20240704154932.6686-1-laurent.pinchart@ideasonboard.com\n-------------------------------------------------------------------------------\n\n\nJacopo Mondi (4):\n include: rkisp1: Update header for extensible parameters\n include: videodev2: Add V4L2_META_FMT_RK_ISP1_EXT_PARAMS\n ipa: rkisp1: Pass parameters buffer size to pipeline handler\n pipeline: rkisp1: Use the extensible parameters format\n\nLaurent Pinchart (3):\n ipa: rkisp1: Pass parameters buffer format to IPA module\n ipa: rkisp1: Add ISP parameters abstraction class\n ipa: rkisp1: Use the new ISP parameters abstraction\n\nPaul Elder (2):\n ipa: rkisp1: Add compand feature flag to ipa context\n ipa: rkisp1: blc: Add support for BLS in compand\n\n include/libcamera/ipa/rkisp1.mojom | 3 +-\n include/linux/rkisp1-config.h | 578 +++++++++++++++++++++++\n include/linux/videodev2.h | 1 +\n src/ipa/rkisp1/algorithms/agc.cpp | 48 +-\n src/ipa/rkisp1/algorithms/agc.h | 2 +-\n src/ipa/rkisp1/algorithms/awb.cpp | 60 +--\n src/ipa/rkisp1/algorithms/awb.h | 2 +-\n src/ipa/rkisp1/algorithms/blc.cpp | 36 +-\n src/ipa/rkisp1/algorithms/blc.h | 3 +-\n src/ipa/rkisp1/algorithms/ccm.cpp | 15 +-\n src/ipa/rkisp1/algorithms/ccm.h | 4 +-\n src/ipa/rkisp1/algorithms/cproc.cpp | 14 +-\n src/ipa/rkisp1/algorithms/cproc.h | 2 +-\n src/ipa/rkisp1/algorithms/dpcc.cpp | 10 +-\n src/ipa/rkisp1/algorithms/dpcc.h | 2 +-\n src/ipa/rkisp1/algorithms/dpf.cpp | 27 +-\n src/ipa/rkisp1/algorithms/dpf.h | 2 +-\n src/ipa/rkisp1/algorithms/filter.cpp | 56 ++-\n src/ipa/rkisp1/algorithms/filter.h | 2 +-\n src/ipa/rkisp1/algorithms/goc.cpp | 17 +-\n src/ipa/rkisp1/algorithms/goc.h | 2 +-\n src/ipa/rkisp1/algorithms/gsl.cpp | 20 +-\n src/ipa/rkisp1/algorithms/gsl.h | 2 +-\n src/ipa/rkisp1/algorithms/lsc.cpp | 29 +-\n src/ipa/rkisp1/algorithms/lsc.h | 4 +-\n src/ipa/rkisp1/ipa_context.h | 1 +\n src/ipa/rkisp1/meson.build | 1 +\n src/ipa/rkisp1/module.h | 3 +-\n src/ipa/rkisp1/params.cpp | 222 +++++++++\n src/ipa/rkisp1/params.h | 163 +++++++\n src/ipa/rkisp1/rkisp1.cpp | 28 +-\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 10 +-\n 32 files changed, 1169 insertions(+), 200 deletions(-)\n create mode 100644 src/ipa/rkisp1/params.cpp\n create mode 100644 src/ipa/rkisp1/params.h\n\n--\n2.45.2" }