Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/20720/?format=api
{ "id": 20720, "url": "https://patchwork.libcamera.org/api/1.1/covers/20720/?format=api", "web_url": "https://patchwork.libcamera.org/cover/20720/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240730232708.17399-1-laurent.pinchart@ideasonboard.com>", "date": "2024-07-30T23:27:05", "name": "[0/3] libcamera: Address soft ISP file seal TODO item", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/20720/mbox/", "series": [ { "id": 4468, "url": "https://patchwork.libcamera.org/api/1.1/series/4468/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4468", "date": "2024-07-30T23:27:05", "name": "libcamera: Address soft ISP file seal TODO item", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4468/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/20720/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 354CEC323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Jul 2024 23:27:32 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0647E63375;\n\tWed, 31 Jul 2024 01:27:31 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E34B61984\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 31 Jul 2024 01:27:29 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9AAF6EF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 31 Jul 2024 01:26:41 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"f/or+m6O\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1722382001;\n\tbh=guVUmKlP9waYteMyxpHsCWc5/Eo6+HaXPM2ix5p+OMw=;\n\th=From:To:Subject:Date:From;\n\tb=f/or+m6OGRrIUR6E8O00g0yLn0bhHFPDKdC6w3I70hXQPydB1sZhk0in42VAAHKkw\n\twwLhFuS0L4yFPgwxrTfXBl2F6yHpyZ8rP/hWfHXqEt2fdx9FXgYIqSrgoN5Sdt/nKQ\n\tUxhhlXqSfBy5Ust6XXSRc7rwnI2JIae8dH5+Raw0=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH 0/3] libcamera: Address soft ISP file seal TODO item", "Date": "Wed, 31 Jul 2024 02:27:05 +0300", "Message-ID": "<20240730232708.17399-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis small series addresses one TODO item of the soft ISP, namely shrink\nand grow sealing of the memfd underlying SharedMem objects.\n\nPatch 1/3 starts by sharing the memfd handling code between the\nDmaBufAllocator and SharedMem classes by moving it to a new MemFd helper\nclass. Patch 2/3 then addresses the TODO item, and patch 3/3 drops it\nfrom the TODO file.\n\nIn case the value of sealing the memfd is dubious, given that shrinking\nit would be shooting ourselves in the foot, we could drop patch 2/3. I\nthink patch 1/3 is still useful as it reduces the amount of code\nduplication. Patch 3/3 should then get an updated commit message to\nexplain why the TODO item is dropped without being addressed.\n\nLaurent Pinchart (3):\n libcamera: base: Add MemFd helper class\n libcamera: shared_mem_object: Prevent memfd from shrinking or growing\n libcamera: software_isp: Remove file seal TODO item\n\n include/libcamera/base/memfd.h | 34 +++++++++\n include/libcamera/base/meson.build | 1 +\n src/libcamera/base/memfd.cpp | 112 ++++++++++++++++++++++++++++\n src/libcamera/base/meson.build | 1 +\n src/libcamera/dma_buf_allocator.cpp | 46 +-----------\n src/libcamera/shared_mem_object.cpp | 22 ++----\n src/libcamera/software_isp/TODO | 19 -----\n 7 files changed, 158 insertions(+), 77 deletions(-)\n create mode 100644 include/libcamera/base/memfd.h\n create mode 100644 src/libcamera/base/memfd.cpp\n\n\nbase-commit: 7f33dfc100b2da0f158494534138a2d8b4f95100\nprerequisite-patch-id: a6b8d233e4722c8092fc8a9bf64221ab23dc465f" }