Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/20367/?format=api
{ "id": 20367, "url": "https://patchwork.libcamera.org/api/1.1/covers/20367/?format=api", "web_url": "https://patchwork.libcamera.org/cover/20367/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>", "date": "2024-06-24T19:29:31", "name": "[00/10] libcamera: Enable -Wmissing-declarations", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/20367/mbox/", "series": [ { "id": 4413, "url": "https://patchwork.libcamera.org/api/1.1/series/4413/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4413", "date": "2024-06-24T19:29:31", "name": "libcamera: Enable -Wmissing-declarations", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4413/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/20367/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2C15BD87C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Jun 2024 19:30:06 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B004654AA;\n\tMon, 24 Jun 2024 21:30:05 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F117654A1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Jun 2024 21:30:04 +0200 (CEST)", "from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBEAE1650;\n\tMon, 24 Jun 2024 21:29:41 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H6fNwFPH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1719257382;\n\tbh=0E7vTCHfBVrAl4B+sCq9xjPgULhG1JWLx0s0Is+dw7g=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=H6fNwFPHpnN1aaM4IUYlL+Vv44C7II6Jw5hs2B5APYJIT2dqPy/wunIygqVP9qMJE\n\t9pFM3+iumGCH98fEmG+/Yu21jLlrL7ZkiPpdAvfJHmmwUzJ843vWV6nQSLTOfguToP\n\tTXWYQis2CYVQW3c021R9xL0QLTDwK485ASce/wAE=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <pobrn@protonmail.com>", "Subject": "[PATCH 00/10] libcamera: Enable -Wmissing-declarations", "Date": "Mon, 24 Jun 2024 22:29:31 +0300", "Message-ID": "<20240624192941.22943-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.44.2", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis patch series enables -Wmissing-declarations to catch mismatches\nbetween function declarations and definitions, which recently introduced\na bug in libcamera. Patch 01/10 to 09/10 first fix a (surprisingly\nlarge) number of offenders that trigger the warning, and patch 10/10 the\nenables it.\n\nLaurent Pinchart (10):\n libcamera: base: log: Declare log categories when defining them\n ipa: ipa_interface: Declare ipaCreate() in libcamera namespace\n ipa: rpi: Define local functions in anonymous namespace\n py: libcamera: Move function declarations to common header\n v4l2: v4l2_compat: Include missing headers\n v4l2: v4l2_compat: Selectively disable -Wmissing-declarations\n apps: Define local functions in anonymous namespace\n test: ipc: unixsocket: Define local function in anonymous namespace\n test: gstreamer: Include missing sanitizer/asan_interface.h header\n meson: Enable warnings to flag missing declarations\n\n include/libcamera/base/log.h | 1 +\n include/libcamera/ipa/ipa_interface.h | 4 +-\n meson.build | 1 +\n src/apps/cam/main.cpp | 4 ++\n src/apps/common/dng_writer.cpp | 6 ++-\n src/apps/qcam/main.cpp | 4 ++\n src/ipa/rpi/controller/rpi/ccm.cpp | 6 ++-\n src/ipa/rpi/controller/rpi/contrast.cpp | 4 ++\n src/py/libcamera/py_color_space.cpp | 2 +\n src/py/libcamera/py_controls_generated.cpp.in | 2 +\n src/py/libcamera/py_enums.cpp | 2 +\n src/py/libcamera/py_formats_generated.cpp.in | 2 +\n src/py/libcamera/py_geometry.cpp | 2 +\n src/py/libcamera/py_main.cpp | 8 ----\n src/py/libcamera/py_main.h | 10 +++++\n .../libcamera/py_properties_generated.cpp.in | 2 +\n src/py/libcamera/py_transform.cpp | 2 +\n src/v4l2/v4l2_compat.cpp | 45 ++++++++++++-------\n test/gstreamer/gstreamer_test.cpp | 6 +++\n test/gstreamer/meson.build | 7 +++\n test/ipc/unixsocket.cpp | 4 ++\n 21 files changed, 95 insertions(+), 29 deletions(-)\n\n\nbase-commit: 2119bdac6a011034cc33584e3303e47db4932313" }