Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/19511/?format=api
{ "id": 19511, "url": "https://patchwork.libcamera.org/api/1.1/covers/19511/?format=api", "web_url": "https://patchwork.libcamera.org/cover/19511/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240220164317.998477-1-dan.scally@ideasonboard.com>", "date": "2024-02-20T16:43:10", "name": "[v2,0/7] Remove RkISP1FrameInfo and IPU3Frames classes", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/1.1/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/19511/mbox/", "series": [ { "id": 4172, "url": "https://patchwork.libcamera.org/api/1.1/series/4172/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4172", "date": "2024-02-20T16:43:10", "name": "Remove RkISP1FrameInfo and IPU3Frames classes", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4172/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/19511/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A199DC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Feb 2024 16:43:26 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8887562817;\n\tTue, 20 Feb 2024 17:43:25 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9EBFE61CA3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Feb 2024 17:43:23 +0100 (CET)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1800D13AC;\n\tTue, 20 Feb 2024 17:43:16 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mXF+L5eU\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1708447396;\n\tbh=4+0Tp2M5vej4BRki+Nu3M6MBR32SMG1j5eW3VnnX0q0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=mXF+L5eUfdwd0TjwlncrI/l5QFX8R+Jd9zTamsh3kSubC2ve11LZFRd79MMdsBrjV\n\tGqkIgWKj7ecF3voKI3HH+fHkdUM3WFZ4v/5RrVRr0s6GtB2m9R/M4U/5eaoST08fTQ\n\tuGvilROYhrZQJpboLZF/Pyz9oe03L5hgZEwLuELQ=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2 0/7] Remove RkISP1FrameInfo and IPU3Frames classes", "Date": "Tue, 20 Feb 2024 16:43:10 +0000", "Message-Id": "<20240220164317.998477-1-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello all\n\nThis series represents further work on removing the RkISP1FrameInfo and\nIPU3Frames classes. These exist to track the \"state\" of a Request so that the\npipeline handlers can decide whether or not it can be completed already, but it\nseems like we should be able to remove it and just re-factor the functionality\nout into the rest of the pipeline handler whilst relying on a new concept of\n\"internal\" buffers in Request::Private to track completion status of a Request.\n\nQuick reviews would be deeply appreciated so we can unblock other work that\nrelies on this. I'm particularly interested in whether the concept of internal\nbuffers for Requests is acceptable, or if the consensus is that tracking of\nwhether a pipeline is ready to complete a request should live there instead.\n\nThanks\nDan\n\nDaniel Scally (7):\n libcamera: request: Introduce internal buffers\n libcamera: camera: Turn queuedRequests_ to a map\n libcamera: rkisp1: Track request->sequence() instead of frame_\n libcamera: rkisp1: Switch tryCompleteRequest() to use Request *\n libcamera: rkisp1: Remove RkISP1FrameInfo\n libcamera: rkisp1: Remove tryCompleteRequest function\n libcamera: ipu3: Remove IPU3Frames\n\n include/libcamera/internal/camera.h | 4 +-\n include/libcamera/internal/request.h | 12 +\n src/libcamera/camera.cpp | 4 +-\n src/libcamera/pipeline/ipu3/cio2.cpp | 3 +-\n src/libcamera/pipeline/ipu3/cio2.h | 2 +-\n src/libcamera/pipeline/ipu3/frames.cpp | 143 -----------\n src/libcamera/pipeline/ipu3/frames.h | 67 -----\n src/libcamera/pipeline/ipu3/ipu3.cpp | 203 +++++++++------\n src/libcamera/pipeline/ipu3/meson.build | 1 -\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 313 ++++++-----------------\n src/libcamera/pipeline_handler.cpp | 21 +-\n src/libcamera/request.cpp | 93 ++++++-\n 12 files changed, 322 insertions(+), 544 deletions(-)\n delete mode 100644 src/libcamera/pipeline/ipu3/frames.cpp\n delete mode 100644 src/libcamera/pipeline/ipu3/frames.h" }