Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/19390/?format=api
{ "id": 19390, "url": "https://patchwork.libcamera.org/api/1.1/covers/19390/?format=api", "web_url": "https://patchwork.libcamera.org/cover/19390/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240113142218.28063-1-hdegoede@redhat.com>", "date": "2024-01-13T14:22:00", "name": "[libcamera-devel,v2,00/18] ", "submitter": { "id": 102, "url": "https://patchwork.libcamera.org/api/1.1/people/102/?format=api", "name": "Hans de Goede", "email": "hdegoede@redhat.com" }, "mbox": "https://patchwork.libcamera.org/cover/19390/mbox/", "series": [ { "id": 4142, "url": "https://patchwork.libcamera.org/api/1.1/series/4142/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4142", "date": "2024-01-13T14:22:00", "name": "[libcamera-devel,v2,01/18] libcamera: pipeline: simple: fix size adjustment in validate()", "version": 2, "mbox": "https://patchwork.libcamera.org/series/4142/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/19390/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39313BEFBE\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 13 Jan 2024 14:22:33 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 50792628B7;\n\tSat, 13 Jan 2024 15:22:32 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80FAF61D57\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 13 Jan 2024 15:22:30 +0100 (CET)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n\t[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-316-TLdWefYcPxK1_vLd-OhN8w-1; Sat, 13 Jan 2024 09:22:26 -0500", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4728682DFE0;\n\tSat, 13 Jan 2024 14:22:26 +0000 (UTC)", "from localhost.localdomain (unknown [10.39.192.58])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id EBA193C25;\n\tSat, 13 Jan 2024 14:22:23 +0000 (UTC)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1705155752;\n\tbh=hnxx/ZHy5MCYYGp4CJ6lQ0YQA1GII3UbyO0p8dCLXvk=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=ZUSYoFCF0AG43PGRajSo4xeJXf6Wh2c4mDDe1OFtMw41UXLDqIBaN0iVn6IH+vItk\n\tgqHOdltWVEJ2pkBBZ8k0R9dBKP94XH2Gga/Mxr7+J/DoleS5of6eMLD9R6aJdStNcA\n\tVWSp0maPjpaotkVW8ifD+7fyqyV1JMbaF59sUimGliE9l6fSHPmeczF6BSic8lDeWy\n\tBgd+zP0m9i800GtMP+8k5rTLaKlRLDUy90aBTJWzIz0kH2VAwAVkw0vt0ugrt0v8Ji\n\tXJ4AXu4wyU65d5nHkVj1qEw5JQx+W+nbUHpCmR/BsSWibSc/r4gB4b5xpKppBZqrc3\n\tAA4F9J27iBZnA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1705155748;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=y40wOkSLf8IHLnTw3RThVaROajESMeA8cJBjuK6pUjg=;\n\tb=aQjasETDnPKVKh+QajikkCX9Yqd1utZmEXYSm9B+UIv/Xq6GM9TSiEV1ZohreZsU7VuipZ\n\tBi4NDkXUsLzUEwgdtv8Xcn7kt0674tWLbFQdJQRStsJRGgKyGA5Kaa1zoCy4Idq5j6cPwD\n\trh3ZXl5euK8Cf+L4E1N4P4Pg4kVzj4M=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"aQjasETD\"; \n\tdkim-atps=neutral", "X-MC-Unique": "TLdWefYcPxK1_vLd-OhN8w-1", "To": "libcamera-devel@lists.libcamera.org,\n\tAndrey Konovalov <andrey.konovalov.ynk@gmail.com>", "Date": "Sat, 13 Jan 2024 15:22:00 +0100", "Message-ID": "<20240113142218.28063-1-hdegoede@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.11.54.1", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "Subject": "[libcamera-devel] [PATCH v2 00/18]", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Hans de Goede via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Hans de Goede <hdegoede@redhat.com>", "Cc": "Maxime Ripard <mripard@redhat.com>, g.martti@gmail.com,\n\tt.langendam@gmail.com, srinivas.kandagatla@linaro.org,\n\tPavel Machek <pavel@ucw.cz>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>, admin@dennisbonke.com", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hi All,\n\nHere is v2 of the patch-set to add Software ISP support\nto libcamera / to the simple pipeline-handler.\n\nChanges in v2 vs v1:\n- Integrated Dennis, Martti and Toon's auto-exposure algorithm\n based on the paper which they found which gives us a nice\n relatively simple AEC + AGC algorithm\n TODO: Add link to paper to source + commit-message\n- Integrated Dennis' doxygen comments for all new classes, no more warnings!\n- Move AWB gain calculations to the IPA (Andrey)\n- Added 8 bpp and 10 bpp unpacked raw bayer input support (Hans)\n- Use dma-buf for the output FrameBuffer-s (Andrey)\n- Memcpy data from input FrameBuffers to a heap buffer on a line by line\n basis to speedup debayering from uncached mem (Hans)\n- This addresses all \"open issues\" from the v1 posting\n\nChanges in v1 vs RFC-v2:\n- Add and use SwStats[Cpu] and Debayer[Cpu] classes\n- Rename linaro soft-IPA and soft-ISP implementations to simple following\n the simple pipeline hander\n- Integrate Pavel's swstats and debayer improvements\n\nThis has been tested on:\n- Qualcomm RB5 board with a mezzanine board equipped with RPi camera v2 (Andrey)\n- Lenovo x13s, sc8280xp (Bryan)\n- Pinephone (Pavel)\n- Debix Model A (Milan)\n- Lenovo Thinkpad Yoga X1 yoga gen7/8, Alder Lake/Raptor Lake IPU6EP +\n ov2740 10bpp packed + unpacked (Dennis / Hans)\n- Dell Latitude 9420, Tiger Lake IPU6 + ov01a1s (RGBI) sensor\n (Martti, requires IGIG_GBGR_IGIG_GRGB patches on top)\n\ngit branch for this v2 patch set:\nhttps://gitlab.freedesktop.org/camera/libcamera-softisp/-/commits/SoftwareISP-v05\n\ngit branch for v1 of the patch set:\nhttps://gitlab.freedesktop.org/camera/libcamera-softisp/-/commits/SoftwareISP-v04\n\nOld RFC-v2 cover-letter with small updates:\n\nHere is an implementation of Software ISP and Software IPA\nwhich provide debayering and implementation of image processing\nalgorithms for systems without a hardware ISP, or in cases when\nthere are no public drivers for the hardware ISP present in the\nsystem.\n\nThe implementation of the Software ISP is a reference one.\nA naive AWB alorithm is implemented as part of a function which\ndoes debayering and statistics calculations - the algorithm part\nis to be moved to the IPA in the next version of the patch set.\nAnd for debayering itself there is already a more efficient\nimplementation by Hans de Goede. This patch set is currently using\nthe earlier debayering implementation as it is less lines of code\nand is OK for the initial discussion.\nOnly RAW10P format from the sensor is currently supported, but\nother debayering functions can be easily added (which of them to\ncall is decided based on the input format).\n\nThe Software IPA has only auto exposure and AGC. For the AGC\nthe analogue gain control of the camera sensor is used (if\navailable). The algorithm is very much simplified, and is\nmostly included as a reference code.\n\nThe 6th patch renames some variables in the simple pipeline\nhandler for the Software ISP to use the same buffer handling\ncode as the Converter currently does. This lets one to\navoid adding extra code to the pipeline handler, but also\nmakes the Software ISP and the Converter mutually exclusive.\n\nThe Software ISP / IPA are intended to be used with the simple\npipeline handler. The pipeline handler doesn't interact with\nthe Software IPA directly - the Software IPA is hidden behind\nthe Software ISP interface. To use the Software ISP the build\nmust be configured with\n -Dpipelines=simple/simple -Dipas=simple/simple\nand the Converter must not be used (the latter is hardcoded\nin the simple pipeline handler).\nIf the build is configured with just\n -Dpipelines=simple\nthe Software ISP / IPA are not used, and the simple pipeline\nhandler works in the same way as without this patchset.\n\n\"simple\" in the\n -Dpipelines=simple/simple -Dipas=simple/simple\nis the name of the Software ISP / IPA implementation.\n -Dpipelines=simple/<something else> -Dipas=simple/<something else>\nshould work too if another implementation were added. What\nimplementation to use is the build time choice, only one\nimplementation is included into the build.\n\nThis patch set uses SharedMemObject class used by the RPi pipeline\nhandler - the second patch in the series moves the header file\nto a common directory.\n\nThis patch set has been tested on Qualcomm RB5 board with\na mezzanine board equipped with RPi camera v2 (not the\nstandard RB5 camera mezzanine).\n\ngit branch for the RFC-v2 patch set:\nhttps://gitlab.freedesktop.org/camera/libcamera-softisp/-/commits/SoftwareISP-v03\n\nRFC-v1 of the patch set:\nhttps://patchwork.libcamera.org/cover/19262/\n\nChanges in RFC v2 vs RFC v1:\n- patches are restructured and reordered\n- the Software IPA is hidden behind the Software ISP interface. The\n pipeline handler doesn't interact with the Software IPA directly\n- instantiation of the Software ISP / IPA is configurable (at build\n time)\n- comment explaining the implementation limitations is added to\n SwIspLinaro::IspWorker::debayerRaw10P()\n\nRegards,\n\nHans\n\n\n\nAndrey Konovalov (10):\n libcamera: pipeline: simple: fix size adjustment in validate()\n libcamera: internal: Move dma_heaps.[h,cpp] to common directories\n libcamera: dma_heaps: extend DmaHeap class to support system heap\n libcamera: internal: Move SharedMemObject class to a common directory\n libcamera: introduce SoftwareIsp class\n libcamera: ipa: add Soft IPA common files\n libcamera: ipa: Soft IPA: add a Simple Soft IPA implementation\n libcamera: software_isp: add Simple SoftwareIsp implementation\n libcamera: pipeline: simple: rename converterBuffers_ and related vars\n libcamera: pipeline: simple: enable use of Soft ISP and Soft IPA\n\nDennis Bonke (1):\n libcamera: internal: Document the SharedMemObject class\n\nHans de Goede (7):\n libcamera: software_isp: Add SwStats base class\n libcamera: software_isp: Add SwStatsCpu class\n libcamera: software_isp: Add Debayer base class\n libcamera: software_isp: Add DebayerCpu class\n libcamera: swstats_cpu: Add support for 8 and 10 bpp unpacked bayer\n input\n libcamera: debayer_cpu: Add support for 8 and 10 bpp unpacked bayer\n input\n libcamera: debayer_cpu: Add BGR888 output support\n\n Documentation/Doxyfile.in | 1 +\n .../libcamera/internal}/dma_heaps.h | 14 +-\n include/libcamera/internal/meson.build | 4 +\n .../libcamera/internal}/shared_mem_object.h | 57 +-\n include/libcamera/internal/software_isp.h | 231 ++++++\n .../libcamera/internal/software_isp/debayer.h | 132 ++++\n .../internal/software_isp/debayer_cpu.h | 141 ++++\n .../internal/software_isp/debayer_params.h | 43 ++\n .../internal/software_isp/meson.build | 11 +\n .../internal/software_isp/swisp_simple.h | 163 +++++\n .../internal/software_isp/swisp_stats.h | 34 +\n .../libcamera/internal/software_isp/swstats.h | 215 ++++++\n .../internal/software_isp/swstats_cpu.h | 51 ++\n include/libcamera/ipa/meson.build | 1 +\n include/libcamera/ipa/soft.mojom | 29 +\n meson_options.txt | 3 +-\n src/ipa/simple/common/meson.build | 17 +\n src/ipa/simple/common/soft_base.cpp | 73 ++\n src/ipa/simple/common/soft_base.h | 50 ++\n src/ipa/simple/meson.build | 12 +\n src/ipa/simple/simple/data/meson.build | 9 +\n src/ipa/simple/simple/data/soft.conf | 3 +\n src/ipa/simple/simple/meson.build | 26 +\n src/ipa/simple/simple/soft_simple.cpp | 273 ++++++++\n .../{pipeline/rpi/vc4 => }/dma_heaps.cpp | 55 +-\n src/libcamera/meson.build | 3 +\n src/libcamera/pipeline/rpi/vc4/meson.build | 1 -\n src/libcamera/pipeline/rpi/vc4/vc4.cpp | 5 +-\n src/libcamera/pipeline/simple/simple.cpp | 177 +++--\n src/libcamera/software_isp.cpp | 62 ++\n src/libcamera/software_isp/debayer.cpp | 22 +\n src/libcamera/software_isp/debayer_cpu.cpp | 661 ++++++++++++++++++\n src/libcamera/software_isp/meson.build | 27 +\n src/libcamera/software_isp/swisp_simple.cpp | 238 +++++++\n src/libcamera/software_isp/swstats.cpp | 22 +\n src/libcamera/software_isp/swstats_cpu.cpp | 261 +++++++\n 36 files changed, 3035 insertions(+), 92 deletions(-)\n rename {src/libcamera/pipeline/rpi/vc4 => include/libcamera/internal}/dma_heaps.h (65%)\n rename {src/libcamera/pipeline/rpi/common => include/libcamera/internal}/shared_mem_object.h (62%)\n create mode 100644 include/libcamera/internal/software_isp.h\n create mode 100644 include/libcamera/internal/software_isp/debayer.h\n create mode 100644 include/libcamera/internal/software_isp/debayer_cpu.h\n create mode 100644 include/libcamera/internal/software_isp/debayer_params.h\n create mode 100644 include/libcamera/internal/software_isp/meson.build\n create mode 100644 include/libcamera/internal/software_isp/swisp_simple.h\n create mode 100644 include/libcamera/internal/software_isp/swisp_stats.h\n create mode 100644 include/libcamera/internal/software_isp/swstats.h\n create mode 100644 include/libcamera/internal/software_isp/swstats_cpu.h\n create mode 100644 include/libcamera/ipa/soft.mojom\n create mode 100644 src/ipa/simple/common/meson.build\n create mode 100644 src/ipa/simple/common/soft_base.cpp\n create mode 100644 src/ipa/simple/common/soft_base.h\n create mode 100644 src/ipa/simple/meson.build\n create mode 100644 src/ipa/simple/simple/data/meson.build\n create mode 100644 src/ipa/simple/simple/data/soft.conf\n create mode 100644 src/ipa/simple/simple/meson.build\n create mode 100644 src/ipa/simple/simple/soft_simple.cpp\n rename src/libcamera/{pipeline/rpi/vc4 => }/dma_heaps.cpp (54%)\n create mode 100644 src/libcamera/software_isp.cpp\n create mode 100644 src/libcamera/software_isp/debayer.cpp\n create mode 100644 src/libcamera/software_isp/debayer_cpu.cpp\n create mode 100644 src/libcamera/software_isp/meson.build\n create mode 100644 src/libcamera/software_isp/swisp_simple.cpp\n create mode 100644 src/libcamera/software_isp/swstats.cpp\n create mode 100644 src/libcamera/software_isp/swstats_cpu.cpp" }