Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/1910/?format=api
{ "id": 1910, "url": "https://patchwork.libcamera.org/api/1.1/covers/1910/?format=api", "web_url": "https://patchwork.libcamera.org/cover/1910/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190904120847.11934-1-jacopo@jmondi.org>", "date": "2019-09-04T12:08:43", "name": "[libcamera-devel,v2,0/4] android: Rework metadata tags", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/1910/mbox/", "series": [ { "id": 478, "url": "https://patchwork.libcamera.org/api/1.1/series/478/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=478", "date": "2019-09-04T12:08:43", "name": "android: Rework metadata tags", "version": 2, "mbox": "https://patchwork.libcamera.org/series/478/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/1910/comments/", "headers": { "Return-Path": "<jacopo@jmondi.org>", "Received": [ "from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09BC960BB2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 4 Sep 2019 14:07:21 +0200 (CEST)", "from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 907A220005;\n\tWed, 4 Sep 2019 12:07:19 +0000 (UTC)" ], "X-Originating-IP": "2.224.242.101", "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo@jmondi.org>, kamesan@google.com, jcliang@google.com,\n\tshik@google.com, wtlee@google.com", "Date": "Wed, 4 Sep 2019 14:08:43 +0200", "Message-Id": "<20190904120847.11934-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.23.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 0/4] android: Rework metadata tags", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Wed, 04 Sep 2019 12:07:21 -0000" }, "content": "Hello,\n\nQuoting here the v2 cover letter for some background:\n------------------------------------------------------------------------------\n following a first simple patch\n\"[PATCH] android: camera_device: Add pipeline max depth static metadata\"\n\na discussion with Ren-Pei and Ricky made clear the current metadata support was\nbuggy, and since the ANDROID_REQUEST_AVAILABLE_CAPABILITIES tag was not\nreported, cros_camera_test failed to identify which static tags we were missing.\n\nAdding that tag opened a small pandora box, as the test reported -a lot- of tag\nwhere missing, and some of there were wrongly reported as part of the capture\nrequest template.\n\nThis series tries to address this, by reporting all tags marked as \"BC\" and so\nrequired by LIMITED hardware level devices, cleaning up and improving the\ngenerated request template, and using more opportune sized for each metadata\ntag.\n\ncros_camera_test seems now more happy, both in regard to static metadata and the\ngenerated request template:\n\n# cros_camera_test --gtest_filter=Camera3ModuleFixture.*\n[==========] 9 tests from 1 test case ran. (2 ms total)\n[ PASSED ] 9 tests.\n\n# cros_camera_test --gtest_filter=Camera3DeviceTest*\n[==========] 22 tests from 4 test cases ran. (1044 ms total)\n[ PASSED ] 18 tests.\n[ FAILED ] 4 tests, listed below:\n[ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorBeforeOpen/0, where GetParam() = 0\n[ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorBeforeOpen/1, where GetParam() = 1\n[ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorAfterOpen/0, where GetParam() = 0\n[ FAILED ] Camera3DeviceTest/Camera3AlgoSandboxIPCErrorTest.IPCErrorAfterOpen/1, where GetParam() = 1\n(I guess it's fine if we fail the IPC related tests)\n\nAs all of this has been triggered by a system crash with R78 I would ask Laurent\nto test the series with his environment. I tested with R77 and things seems\nfine.\n------------------------------------------------------------------------------\n\nIn this v3 there are just a few small reworks to the series:\n- use 2 as pipeline depth\n- remove two static tags from the template request\n- verify the metadata pack sizes is big enough*\n\n* Laurent suggested to use valgrind, but the android metadata library actually\n keeps track of the available and used space. Adding a new tag when space is\n exhausted fails, no need to manually check for out-of-bounds write.\n\nRe-sorted patches 3 and 4 compared to v2.\n\nNow tested with R78 by Laurent and confirmed the crash is fixed\n\nThanks\n j\n\nJacopo Mondi (4):\n android: camera_device: Add missing static metadata\n android: camera_device: Use correct sizes for static metadata\n android: camera_device: Rework template generation\n android: camera_device: Report available keys\n\n src/android/camera_device.cpp | 510 +++++++++++++++++++++++++---------\n 1 file changed, 377 insertions(+), 133 deletions(-)\n\n--\n2.23.0" }