Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/18543/?format=api
{ "id": 18543, "url": "https://patchwork.libcamera.org/api/1.1/covers/18543/?format=api", "web_url": "https://patchwork.libcamera.org/cover/18543/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20230423203931.108022-1-umang.jain@ideasonboard.com>", "date": "2023-04-23T20:39:28", "name": "[libcamera-devel,0/3] apps: cam: kms: Introduce requests tracking queue", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/18543/mbox/", "series": [ { "id": 3845, "url": "https://patchwork.libcamera.org/api/1.1/series/3845/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3845", "date": "2023-04-23T20:39:28", "name": "apps: cam: kms: Introduce requests tracking queue", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3845/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/18543/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2904BE173\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 23 Apr 2023 20:39:44 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F5A9627DB;\n\tSun, 23 Apr 2023 22:39:44 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86134627CD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 23 Apr 2023 22:39:39 +0200 (CEST)", "from umang.jainideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:df01:2ad:735a:b54c:741d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0AEE48B8;\n\tSun, 23 Apr 2023 22:39:28 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1682282384;\n\tbh=6qGEjyz0TMxHxRiAWnrlq4axvtAaEGygnNT46V5u+L0=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=Vilc6iGnFxIvVlxupMNu1NWFeCA7I4f2HeIuRkLtqy1qPlZ3HCTgWqGhpyujBjDyW\n\t434mOU/UdFuozp93eZuRLXtQQFMbMDslo3Eab74d59U3P3nnoqLpW8hUeyZKYvOKsw\n\tElH9h21MHiYk22D7gRyLaWKkLtu67Y3J9naWT0iNkLiEVdgOIWQWR729duq441sd2v\n\tUT8Pa2dPhbFg8tBv+PywNAQqVYH8EzMWyC60qzXe1rqrnFcJWyMs7PgFtSh8SNr343\n\tAx+Bytgw9a+XuOr7JmEViOQxN8AteY4fFRDKD6uWNZgYYAMsT5i5muYCt6pCX3SE95\n\tBJ0ZLyQW0t3kg==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1682282369;\n\tbh=6qGEjyz0TMxHxRiAWnrlq4axvtAaEGygnNT46V5u+L0=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=p2pNMTttcuGwRAl6y7A+ji+oz66rqZtQAf/bo3lk5whkpd0XrprhjlPOr83OarMfv\n\tsiO3KO0GUN3bVALOY69B0M9tCueSSkKZje8Qc3Xv5iQnEPmE0pKCC7rzwvkpagHUNx\n\tgX0CaRqarsWhA9DkS5I9byPnSu2PJdmgLMLZdpyA=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"p2pNMTtt\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 24 Apr 2023 02:09:28 +0530", "Message-Id": "<20230423203931.108022-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.39.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 0/3] apps: cam: kms: Introduce requests\n\ttracking queue", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This series got formed while I was trying to stress test the KMSSink\nwith start() -> stop() -> configure() -> start() -> stop() ...\ncycles (without re-allocating).\n\nMainly, I faced a use-after-free segmentation fault happening on stop().\nIt was due the fact a DRM request completes asynchronous but current\nKMSSink::stop() will free that DRM request(stored in queued_ member) on\nstop() - which isn't right. A queue is introduced to store requests but\nmark pending requests as 'expired' on stop() (3/3)\n\nPatch (1/3) and Patch (2/3) are drive by fixes.\n\nUmang Jain (3):\n apps: cam: kms_sink: Do not process requests after stop()\n apps: cam: kms_sink: Drop unique_ptr<> from DRM::AtomicRequest\n apps: cam: kms_sink: Introduce a requests tracking queue\n\n src/apps/cam/kms_sink.cpp | 90 +++++++++++++++++++++------------------\n src/apps/cam/kms_sink.h | 11 +++--\n 2 files changed, 56 insertions(+), 45 deletions(-)" }