Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/16894/?format=api
{ "id": 16894, "url": "https://patchwork.libcamera.org/api/1.1/covers/16894/?format=api", "web_url": "https://patchwork.libcamera.org/cover/16894/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220802100955.1546-1-laurent.pinchart@ideasonboard.com>", "date": "2022-08-02T10:09:51", "name": "[libcamera-devel,RFC,0/4] Add tuning data file support to the IPU3 IPA module", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/16894/mbox/", "series": [ { "id": 3356, "url": "https://patchwork.libcamera.org/api/1.1/series/3356/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3356", "date": "2022-08-02T10:09:51", "name": "Add tuning data file support to the IPU3 IPA module", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3356/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/16894/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9A54CC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 2 Aug 2022 10:10:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E7DB563312;\n\tTue, 2 Aug 2022 12:10:01 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AC9F603E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Aug 2022 12:10:01 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 750BA25B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 2 Aug 2022 12:10:00 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659435002;\n\tbh=rm9D9IB2WmD2UobW8ZzSDYdICcikILbOg72nIlWhnJE=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=lkpnWw6/eyMvJKEhdZol06e4AKE4B60bFRNlzu5u6k0rk+8i/TVa+QiYdVB9zEiET\n\tPlsnrdJqdx5gCSLnoanniAOLyRduwgHJGG3KiQe6BH0VkWtVXGKiNyIh8bBI5vL6CO\n\tdEe5t9aSCPcpZ8W3dDTTuGwADrB1v3Xzt5f5mvLX3HDXypBWXsR9uIdLUZ6TdehFCT\n\tc8E+bthm77b1h1g5CLPb0RBHmT6tU5uT80APbA1s6CeQLalZuU0qEUwfasAW0I8J0Z\n\tK5/Jy+nloDcPdIJgUE/DHrrXsFdwHSj8My/MrPw8tNtYnPNZbaEB55LJYsjlfgjMLU\n\tkRxmUDmo0bcRQ==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659435000;\n\tbh=rm9D9IB2WmD2UobW8ZzSDYdICcikILbOg72nIlWhnJE=;\n\th=From:To:Subject:Date:From;\n\tb=tivqHeEf2wA6Sew0yLgEJ0dHwxmu6czX0E83Tlf7RLF9Or98ZMdZH3TStH3QfA+j8\n\tMvHDroM8W6UMOt5+zMkMajHiy5iu71FPfxG8IkiRuxphNc2HIlbS423dtzrSp4ZEuu\n\t+6ANW5NLgeqZpzvsqcUfgEpO+tPzpL+2G1nYk/UU=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tivqHeEf\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 2 Aug 2022 13:09:51 +0300", "Message-Id": "<20220802100955.1546-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 0/4] Add tuning data file support to\n\tthe IPU3 IPA module", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Hello,\n\nThis patch series adds support for tuning data files to the IPU3 IPA\nmodule. It mimicks the RkISP1 implementation that was merged recently,\nand brings dynamic instantiation of algorithms from the tuning file.\n\nThe series leaves a few questions unanswered, in particular how to\nhandle the IPU3 IPA module based on the closed-source Intel 3A binaries.\nI don't think this is a blocker, the pipeline handler will pass a tuning\nfile name to the IPA module, which that particular module will ignore. I\nhaven't really thought about how to handle the fact that different IPA\nmodules may require different tuning files, maybe this should be handled\nin the broader context of how to select one IPA module among multiple\noptions.\n\nAnother question is if there is room for more code sharing, both on the\npipeline handler side and the IPA module side, as the IPU3 code is very\nsimilar to the RkISP1 code. I think this should be addressed in a second\nstep, once we'll see how both implementations will evolve.\n\nThe patches haven't been tested yet, hence the RFC. I'd like feedback on\nthe direction this is taking, and if someone wants to give the series a\ngo on an IPU3 device, that will also be appreciated.\n\nLaurent Pinchart (4):\n pipeline: ipu3: Support IPA tuning file\n ipa: ipu3: Add an uncalibrated.yaml tuning data file\n ipa: ipu3: Register algorithms\n ipa: ipu3: Add YAML tuning file support\n\n src/ipa/ipu3/algorithms/af.cpp | 2 +\n src/ipa/ipu3/algorithms/agc.cpp | 2 +\n src/ipa/ipu3/algorithms/awb.cpp | 2 +\n src/ipa/ipu3/algorithms/blc.cpp | 2 +\n src/ipa/ipu3/algorithms/tone_mapping.cpp | 2 +\n src/ipa/ipu3/data/meson.build | 8 +++\n src/ipa/ipu3/data/uncalibrated.yaml | 11 ++++\n src/ipa/ipu3/ipu3.cpp | 70 ++++++++++++++++++------\n src/ipa/ipu3/meson.build | 1 +\n src/libcamera/pipeline/ipu3/ipu3.cpp | 22 +++++++-\n 10 files changed, 102 insertions(+), 20 deletions(-)\n create mode 100644 src/ipa/ipu3/data/meson.build\n create mode 100644 src/ipa/ipu3/data/uncalibrated.yaml" }