Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/16869/?format=api
{ "id": 16869, "url": "https://patchwork.libcamera.org/api/1.1/covers/16869/?format=api", "web_url": "https://patchwork.libcamera.org/cover/16869/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220729160014.101503-1-jacopo@jmondi.org>", "date": "2022-07-29T16:00:08", "name": "[libcamera-devel,v3,0/6] libcamera: Map multiple V4L2 formats to a single libcamera::format", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "mbox": "https://patchwork.libcamera.org/cover/16869/mbox/", "series": [ { "id": 3350, "url": "https://patchwork.libcamera.org/api/1.1/series/3350/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3350", "date": "2022-07-29T16:00:08", "name": "libcamera: Map multiple V4L2 formats to a single libcamera::format", "version": 3, "mbox": "https://patchwork.libcamera.org/series/3350/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/16869/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B63FDC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Jul 2022 16:00:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E007E63313;\n\tFri, 29 Jul 2022 18:00:23 +0200 (CEST)", "from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::222])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93BD7603EC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Jul 2022 18:00:22 +0200 (CEST)", "(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 1818440006;\n\tFri, 29 Jul 2022 16:00:20 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659110424;\n\tbh=RQLkfWDdVD3M7qnHWr6F7MHlv8NJZOdtxL61N3+6V1g=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=jkZmlJZmpO1F7R3zIgd2QX3VCGvkZKCcUTvOidfEeZtF2rNL7WNkklmIa+gjsWhsp\n\tMZMuMsQWDsoZHjOuMUCHiqhs9VIb4TthafcCQ16kio3qvM6EAjIpPGLCNGXv8bTjwR\n\tZMZ4cTVfX4E50+fsBcgSMyQz36CuQhBTsHZu3C3FMcTjHK8SZtOXOPGBNaqc+x1kqe\n\t0hkNjMf22Rl8cLOeWETti/WF6OwTslqrviieQtLEGanC27DfCg6PcW2ewuOfZdU+AI\n\tRPE/EmLjrj97pwadJ55HNtNiOA56kQIXfEjHVsFiWn05SUq8fb2WHsWiZRYjZ4flc6\n\toQHMJOIn4yGGA==", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 29 Jul 2022 18:00:08 +0200", "Message-Id": "<20220729160014.101503-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.37.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 0/6] libcamera: Map multiple V4L2\n\tformats to a single libcamera::format", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Jacopo Mondi via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Jacopo Mondi <jacopo@jmondi.org>", "Cc": "jozef@mlich.cz, Pavel Machek <pavel@ucw.cz>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This series addresses the requirement of mapping multiple V4L2 pixel formats\nto a single libcamera format. Specifically, it allows to map V4L2_PIX_FMT_JPEG\nand V4L2_PIX_FMT_MJPEG to libcamera::formats::MJPEG.\n\nWhen testing on Pinephone I was able to capture JPEG (but not to inspect images)\nand YUYV. As soon as I was about to run cam with SDL backend on pinephone, the\nback sensor started failing consistently at boot with:\n\n[ 15.772368] ov5640 3-004c: ov5640_init_slave_id: failed with -6\n\nHave I broke my pinephone camera ??\n\nIf anyone else would like to test:\n cam -c2 --stream pixelformat=YUYV,width=640,height=480 -C -S\n\n(Assuming you have SDL2 installed on your system and available at build time)\n\nAnyway, formats mapping works it seems...\n\nI have dropped all tags, as the series is now rather different than v2.\n\nv2->v3:\n- Resorted patches as suggested by Laurent\n- Remove 'multiplanar' argument in the call chain\n- Cache the V4L2VideoDevice formats at open() time\n\nv1->v2:\n- Add a missing conversion using the video device in Simple converter\n- Map formats::MJPEG to V4L2_PIX_FMT_JPEG in v4l2 formats enumeration\n\nJacopo Mondi (6):\n libcamera: formats: Merge V4L2 single and multi formats\n libcamera: formats: Search PixelFormatInfo on multiple formats\n libcamera: v4l2_videodevice: Reintroduce toV4L2PixelFormat()\n libcamera: v4l2_pixelformat: Return the list of V4L2 formats\n libcamera: v4l2_videodevice: Match formats supported by the device\n libcamera: formats: Map V4L2_PIX_FMT_JPEG to formats::MJPEG\n\n Documentation/guides/pipeline-handler.rst | 7 +-\n include/libcamera/internal/formats.h | 5 +-\n include/libcamera/internal/v4l2_pixelformat.h | 5 +-\n include/libcamera/internal/v4l2_videodevice.h | 3 +\n src/libcamera/formats.cpp | 320 +++++-------------\n src/libcamera/pipeline/ipu3/cio2.cpp | 2 +-\n src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n .../pipeline/raspberrypi/raspberrypi.cpp | 34 +-\n src/libcamera/pipeline/rkisp1/rkisp1_path.cpp | 6 +-\n src/libcamera/pipeline/simple/converter.cpp | 10 +-\n src/libcamera/pipeline/simple/simple.cpp | 4 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +-\n src/libcamera/pipeline/vimc/vimc.cpp | 8 +-\n src/libcamera/v4l2_pixelformat.cpp | 23 +-\n src/libcamera/v4l2_videodevice.cpp | 32 ++\n src/v4l2/v4l2_camera_proxy.cpp | 6 +-\n test/libtest/buffer_source.cpp | 2 +-\n 17 files changed, 180 insertions(+), 295 deletions(-)\n\n--\n2.37.1" }